Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time_zone parameter to aws_autoscaling_schedule #19829

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Add time_zone parameter to aws_autoscaling_schedule #19829

merged 4 commits into from
Jul 30, 2021

Conversation

maerlyn
Copy link

@maerlyn maerlyn commented Jun 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAutoscalingSchedule'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAutoscalingSchedule -timeout 180m
go: downloading github.com/pquerna/otp v1.3.0
go: downloading github.com/apparentlymart/go-cidr v1.0.1
go: downloading github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
=== RUN   TestAccAWSAutoscalingSchedule_basic
=== PAUSE TestAccAWSAutoscalingSchedule_basic
=== RUN   TestAccAWSAutoscalingSchedule_disappears
=== PAUSE TestAccAWSAutoscalingSchedule_disappears
=== RUN   TestAccAWSAutoscalingSchedule_recurrence
=== PAUSE TestAccAWSAutoscalingSchedule_recurrence
=== RUN   TestAccAWSAutoscalingSchedule_zeroValues
=== PAUSE TestAccAWSAutoscalingSchedule_zeroValues
=== RUN   TestAccAWSAutoscalingSchedule_negativeOne
=== PAUSE TestAccAWSAutoscalingSchedule_negativeOne
=== CONT  TestAccAWSAutoscalingSchedule_basic
=== CONT  TestAccAWSAutoscalingSchedule_zeroValues
=== CONT  TestAccAWSAutoscalingSchedule_negativeOne
=== CONT  TestAccAWSAutoscalingSchedule_recurrence
=== CONT  TestAccAWSAutoscalingSchedule_disappears
--- PASS: TestAccAWSAutoscalingSchedule_disappears (153.76s)
--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (160.48s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (167.91s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (173.35s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (178.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	178.894s
...

@github-actions github-actions bot added service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 16, 2021
@maerlyn
Copy link
Author

maerlyn commented Jun 16, 2021

I've marked this as a draft, because I'm not sure if this needs more updates to the resource test. I've updated one of the test cases to use the new parameter, maybe it's enough?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @maerlyn 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@maerlyn maerlyn marked this pull request as ready for review June 29, 2021 07:41
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAutoscalingSchedule_ -timeout 180m
=== RUN   TestAccAWSAutoscalingSchedule_basic
=== PAUSE TestAccAWSAutoscalingSchedule_basic
=== RUN   TestAccAWSAutoscalingSchedule_disappears
=== PAUSE TestAccAWSAutoscalingSchedule_disappears
=== RUN   TestAccAWSAutoscalingSchedule_recurrence
=== PAUSE TestAccAWSAutoscalingSchedule_recurrence
=== RUN   TestAccAWSAutoscalingSchedule_zeroValues
=== PAUSE TestAccAWSAutoscalingSchedule_zeroValues
=== RUN   TestAccAWSAutoscalingSchedule_negativeOne
=== PAUSE TestAccAWSAutoscalingSchedule_negativeOne
=== CONT  TestAccAWSAutoscalingSchedule_basic
=== CONT  TestAccAWSAutoscalingSchedule_zeroValues
=== CONT  TestAccAWSAutoscalingSchedule_negativeOne
=== CONT  TestAccAWSAutoscalingSchedule_disappears
=== CONT  TestAccAWSAutoscalingSchedule_recurrence
--- PASS: TestAccAWSAutoscalingSchedule_disappears (139.70s)
--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (139.88s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (140.75s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (142.25s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (143.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	143.223s

@bill-rich bill-rich merged commit c4113a2 into hashicorp:main Jul 30, 2021
@github-actions github-actions bot added this to the v3.53.0 milestone Jul 30, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants