Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/neptune_cluster - add copy_snapshot_to_tags and refactor to use waiters #19899

Merged
merged 5 commits into from
Jun 22, 2021
Merged

r/neptune_cluster - add copy_snapshot_to_tags and refactor to use waiters #19899

merged 5 commits into from
Jun 22, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 19, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19835

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSNeptuneCluster_'
--- PASS: TestAccAWSNeptuneCluster_disappears (199.05s)
--- PASS: TestAccAWSNeptuneCluster_basic (207.84s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (208.65s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (209.52s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (212.36s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (229.47s)
--- PASS: TestAccAWSNeptuneCluster_tags (232.61s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (247.25s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (272.47s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (277.15s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (316.66s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (350.35s)
--- PASS: TestAccAWSNeptuneCluster_copyTagsToSnapshot (350.36s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 19, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 19, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 19, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review June 19, 2021 19:21
ewbankkit
ewbankkit approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneCluster_ -timeout 180m
=== RUN   TestAccAWSNeptuneCluster_basic
=== PAUSE TestAccAWSNeptuneCluster_basic
=== RUN   TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccAWSNeptuneCluster_namePrefix
=== PAUSE TestAccAWSNeptuneCluster_namePrefix
=== RUN   TestAccAWSNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccAWSNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccAWSNeptuneCluster_tags
=== PAUSE TestAccAWSNeptuneCluster_tags
=== RUN   TestAccAWSNeptuneCluster_updateIamRoles
=== PAUSE TestAccAWSNeptuneCluster_updateIamRoles
=== RUN   TestAccAWSNeptuneCluster_kmsKey
=== PAUSE TestAccAWSNeptuneCluster_kmsKey
=== RUN   TestAccAWSNeptuneCluster_encrypted
=== PAUSE TestAccAWSNeptuneCluster_encrypted
=== RUN   TestAccAWSNeptuneCluster_backupsUpdate
=== PAUSE TestAccAWSNeptuneCluster_backupsUpdate
=== RUN   TestAccAWSNeptuneCluster_iamAuth
=== PAUSE TestAccAWSNeptuneCluster_iamAuth
=== RUN   TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== PAUSE TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== RUN   TestAccAWSNeptuneCluster_deleteProtection
=== PAUSE TestAccAWSNeptuneCluster_deleteProtection
=== RUN   TestAccAWSNeptuneCluster_disappears
=== PAUSE TestAccAWSNeptuneCluster_disappears
=== CONT  TestAccAWSNeptuneCluster_basic
=== CONT  TestAccAWSNeptuneCluster_encrypted
=== CONT  TestAccAWSNeptuneCluster_disappears
=== CONT  TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== CONT  TestAccAWSNeptuneCluster_iamAuth
=== CONT  TestAccAWSNeptuneCluster_takeFinalSnapshot
=== CONT  TestAccAWSNeptuneCluster_tags
=== CONT  TestAccAWSNeptuneCluster_kmsKey
=== CONT  TestAccAWSNeptuneCluster_namePrefix
=== CONT  TestAccAWSNeptuneCluster_backupsUpdate
=== CONT  TestAccAWSNeptuneCluster_updateIamRoles
=== CONT  TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== CONT  TestAccAWSNeptuneCluster_deleteProtection
--- PASS: TestAccAWSNeptuneCluster_namePrefix (144.52s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (161.84s)
--- PASS: TestAccAWSNeptuneCluster_basic (162.25s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (162.29s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (164.44s)
--- PASS: TestAccAWSNeptuneCluster_disappears (175.22s)
--- PASS: TestAccAWSNeptuneCluster_tags (185.24s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (205.84s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (210.50s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (225.08s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (232.74s)
--- PASS: TestAccAWSNeptuneCluster_copyTagsToSnapshot (270.12s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (271.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	276.680s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneCluster_ -timeout 180m
=== RUN   TestAccAWSNeptuneCluster_basic
=== PAUSE TestAccAWSNeptuneCluster_basic
=== RUN   TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== PAUSE TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== RUN   TestAccAWSNeptuneCluster_namePrefix
=== PAUSE TestAccAWSNeptuneCluster_namePrefix
=== RUN   TestAccAWSNeptuneCluster_takeFinalSnapshot
=== PAUSE TestAccAWSNeptuneCluster_takeFinalSnapshot
=== RUN   TestAccAWSNeptuneCluster_tags
=== PAUSE TestAccAWSNeptuneCluster_tags
=== RUN   TestAccAWSNeptuneCluster_updateIamRoles
=== PAUSE TestAccAWSNeptuneCluster_updateIamRoles
=== RUN   TestAccAWSNeptuneCluster_kmsKey
=== PAUSE TestAccAWSNeptuneCluster_kmsKey
=== RUN   TestAccAWSNeptuneCluster_encrypted
=== PAUSE TestAccAWSNeptuneCluster_encrypted
=== RUN   TestAccAWSNeptuneCluster_backupsUpdate
=== PAUSE TestAccAWSNeptuneCluster_backupsUpdate
=== RUN   TestAccAWSNeptuneCluster_iamAuth
=== PAUSE TestAccAWSNeptuneCluster_iamAuth
=== RUN   TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== PAUSE TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== RUN   TestAccAWSNeptuneCluster_deleteProtection
=== PAUSE TestAccAWSNeptuneCluster_deleteProtection
=== RUN   TestAccAWSNeptuneCluster_disappears
=== PAUSE TestAccAWSNeptuneCluster_disappears
=== CONT  TestAccAWSNeptuneCluster_basic
=== CONT  TestAccAWSNeptuneCluster_encrypted
=== CONT  TestAccAWSNeptuneCluster_tags
=== CONT  TestAccAWSNeptuneCluster_kmsKey
=== CONT  TestAccAWSNeptuneCluster_deleteProtection
=== CONT  TestAccAWSNeptuneCluster_backupsUpdate
=== CONT  TestAccAWSNeptuneCluster_namePrefix
=== CONT  TestAccAWSNeptuneCluster_iamAuth
=== CONT  TestAccAWSNeptuneCluster_copyTagsToSnapshot
=== CONT  TestAccAWSNeptuneCluster_takeFinalSnapshot
=== CONT  TestAccAWSNeptuneCluster_updateIamRoles
=== CONT  TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== CONT  TestAccAWSNeptuneCluster_disappears
--- PASS: TestAccAWSNeptuneCluster_disappears (123.26s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (139.29s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (149.79s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (152.20s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (155.80s)
--- PASS: TestAccAWSNeptuneCluster_basic (158.61s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (177.83s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (192.48s)
--- PASS: TestAccAWSNeptuneCluster_tags (217.31s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (220.12s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (239.56s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (258.25s)
--- PASS: TestAccAWSNeptuneCluster_copyTagsToSnapshot (260.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	263.444s

@ewbankkit ewbankkit merged commit 9245a3f into hashicorp:main Jun 22, 2021
@github-actions github-actions bot added this to the v3.47.0 milestone Jun 22, 2021
@DrFaust92 DrFaust92 deleted the r/neptune_cluster_snapshot_tags branch June 22, 2021 19:03
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@uadev
Copy link

uadev commented Jul 13, 2021

It would be great to rename this to copy_tags_to_snapshot to avoid confusion.

@ewbankkit
Copy link
Contributor

@uadev The new argument is named copy_tags_to_snapshot 😄. It looks like a typo in the PR title and Release Notes (which I will fix).
Thanks.

@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented Jul 13, 2021 via email

@ewbankkit ewbankkit mentioned this pull request Jul 13, 2021
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.

Add copy_tags_to_snapshot parameter to the aws_neptune_cluster
3 participants
@DrFaust92 @uadev @ewbankkit