Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cognito_user_pool_client default_redirect_uri validation makes it mandatory #19924

Closed
emulanob opened this issue Jun 22, 2021 · 3 comments · Fixed by #20031
Closed

aws_cognito_user_pool_client default_redirect_uri validation makes it mandatory #19924

emulanob opened this issue Jun 22, 2021 · 3 comments · Fixed by #20031
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement.
Milestone

Comments

@emulanob
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.8

  • provider registry.terraform.io/hashicorp/aws v3.46.0

Affected Resource(s)

  • aws_cognito_user_pool_client

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

Example resource block:

variable callback_urls {
  default = []
  type = list(string)
}

variable default_redirect_uri {
  default = ""
}

resource "aws_cognito_user_pool_client" "client" {
  name                 = "client"
  user_pool_id         = aws_cognito_user_pool.pool.id
  callback_urls        = var.callback_urls
  default_redirect_uri = var.default_redirect_url
}

Expected Behavior

The empty values will be ignored and the client will be created without these attributes.

Actual Behavior

A terraform plan throws the following errors:

Error: expected length of default_redirect_uri to be in the range (1 - 1024), got 
Error: invalid value for callback_urls.0 (must satisfy regular expression pattern: [\p{L}\p{M}\p{S}\p{N}\p{P}]+`)

Other info

I'm not sure in which version that validation was introduced because I haven't really touched this particular module in a while, but what it causes is basically making two optional attributes (default_redirect_uri) mandatory. This makes writing reusable modules very complicated as the attribute cannot be null nor empty.
The only way I could get rid of the error was by commenting out the attribute, but again, that makes writing a reusable module impossible.

Maybe I'm missing something here? Please let me know if I can provide any more info.
Thanks.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/cognito labels Jun 22, 2021
@ewbankkit
Copy link
Contributor

Related: #14935.

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 28, 2021
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 9, 2021
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement.
Projects
None yet
2 participants