Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servicecatalog: Test for launch paths data source fails if using assumed role #19998

Closed
YakDriver opened this issue Jun 29, 2021 · 2 comments · Fixed by #20001
Closed

servicecatalog: Test for launch paths data source fails if using assumed role #19998

YakDriver opened this issue Jun 29, 2021 · 2 comments · Fixed by #20001
Labels
service/iam Issues and PRs that pertain to the iam service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sts Issues and PRs that pertain to the sts service.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Jun 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v1.0.1
AWS v3.48.0

Affected Resource(s)

  • aws_servicecatalog_launch_paths

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

data "aws_caller_identity" "current" {}

resource "aws_servicecatalog_principal_portfolio_association" "test" {
  portfolio_id  = aws_servicecatalog_portfolio.test.id
  principal_arn = data. aws_caller_identity.current.arn
}

data "aws_servicecatalog_launch_paths" "test" {
  product_id = aws_servicecatalog_product_portfolio_association.test.product_id

  depends_on = [aws_servicecatalog_principal_portfolio_association.test]
}

Debug Output

=== CONT  TestAccAWSServiceCatalogLaunchPathsDataSource_basic
    data_source_aws_servicecatalog_launch_paths_test.go:18: Step 1/1 error: Error running apply: exit status 1
        
        Error: error associating Service Catalog Principal with Portfolio: InvalidParametersException: Invalid parameter principalArn, assumed-role is not a recognized IAM identity type
        
          with aws_servicecatalog_principal_portfolio_association.test,
          on terraform_plugin_test.tf line 80, in resource "aws_servicecatalog_principal_portfolio_association" "test":
          80: resource "aws_servicecatalog_principal_portfolio_association" "test" {
        
--- FAIL: TestAccAWSServiceCatalogLaunchPathsDataSource_basic (65.72s)

Expected Behavior

Should run test.

Actual Behavior

Test errors.

Steps to Reproduce

  1. TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run='TestAccAWSServiceCatalogLaunchPathsDataSource_basic' -timeout 180m

References

@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sts Issues and PRs that pertain to the sts service. labels Jun 29, 2021
@github-actions github-actions bot added this to the v3.48.0 milestone Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/sts Issues and PRs that pertain to the sts service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant