Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_model - add inference_execution_config #20066

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerModel_'
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (59.35s)
--- PASS: TestAccAWSSagemakerModel_basic (60.46s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerImageConfig (62.06s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (62.73s)
--- PASS: TestAccAWSSagemakerModel_inferenceExecutionConfig (66.34s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (68.95s)
--- PASS: TestAccAWSSagemakerModel_disappears (74.37s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (78.98s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (80.22s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (90.33s)
--- PASS: TestAccAWSSagemakerModel_tags (138.37s)
--- PASS: TestAccAWSSagemakerModel_containers (58.37s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 4, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 4, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review July 4, 2021 06:08
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemakerModel_'                                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModel_ -timeout 180m
=== RUN   TestAccAWSSagemakerModel_basic
=== PAUSE TestAccAWSSagemakerModel_basic
=== RUN   TestAccAWSSagemakerModel_inferenceExecutionConfig
=== PAUSE TestAccAWSSagemakerModel_inferenceExecutionConfig
=== RUN   TestAccAWSSagemakerModel_tags
=== PAUSE TestAccAWSSagemakerModel_tags
=== RUN   TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== RUN   TestAccAWSSagemakerModel_primaryContainerHostname
=== PAUSE TestAccAWSSagemakerModel_primaryContainerHostname
=== RUN   TestAccAWSSagemakerModel_primaryContainerImageConfig
=== PAUSE TestAccAWSSagemakerModel_primaryContainerImageConfig
=== RUN   TestAccAWSSagemakerModel_primaryContainerEnvironment
=== PAUSE TestAccAWSSagemakerModel_primaryContainerEnvironment
=== RUN   TestAccAWSSagemakerModel_primaryContainerModeSingle
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModeSingle
=== RUN   TestAccAWSSagemakerModel_containers
=== PAUSE TestAccAWSSagemakerModel_containers
=== RUN   TestAccAWSSagemakerModel_vpcConfig
=== PAUSE TestAccAWSSagemakerModel_vpcConfig
=== RUN   TestAccAWSSagemakerModel_networkIsolation
=== PAUSE TestAccAWSSagemakerModel_networkIsolation
=== RUN   TestAccAWSSagemakerModel_disappears
=== PAUSE TestAccAWSSagemakerModel_disappears
=== CONT  TestAccAWSSagemakerModel_basic
=== CONT  TestAccAWSSagemakerModel_primaryContainerModeSingle
=== CONT  TestAccAWSSagemakerModel_vpcConfig
=== CONT  TestAccAWSSagemakerModel_containers
=== CONT  TestAccAWSSagemakerModel_disappears
=== CONT  TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_primaryContainerImageConfig
=== CONT  TestAccAWSSagemakerModel_primaryContainerHostname
=== CONT  TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== CONT  TestAccAWSSagemakerModel_tags
=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
=== CONT  TestAccAWSSagemakerModel_inferenceExecutionConfig
--- PASS: TestAccAWSSagemakerModel_networkIsolation (35.38s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (39.00s)
--- PASS: TestAccAWSSagemakerModel_inferenceExecutionConfig (45.13s)
--- PASS: TestAccAWSSagemakerModel_disappears (49.97s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerImageConfig (55.47s)
--- PASS: TestAccAWSSagemakerModel_basic (55.49s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (56.27s)
--- PASS: TestAccAWSSagemakerModel_containers (57.73s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (58.07s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (58.17s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (58.27s)
--- PASS: TestAccAWSSagemakerModel_tags (103.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	106.797s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerModel_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModel_ -timeout 180m
=== RUN   TestAccAWSSagemakerModel_basic
=== PAUSE TestAccAWSSagemakerModel_basic
=== RUN   TestAccAWSSagemakerModel_inferenceExecutionConfig
=== PAUSE TestAccAWSSagemakerModel_inferenceExecutionConfig
=== RUN   TestAccAWSSagemakerModel_tags
=== PAUSE TestAccAWSSagemakerModel_tags
=== RUN   TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== RUN   TestAccAWSSagemakerModel_primaryContainerHostname
=== PAUSE TestAccAWSSagemakerModel_primaryContainerHostname
=== RUN   TestAccAWSSagemakerModel_primaryContainerImageConfig
=== PAUSE TestAccAWSSagemakerModel_primaryContainerImageConfig
=== RUN   TestAccAWSSagemakerModel_primaryContainerEnvironment
=== PAUSE TestAccAWSSagemakerModel_primaryContainerEnvironment
=== RUN   TestAccAWSSagemakerModel_primaryContainerModeSingle
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModeSingle
=== RUN   TestAccAWSSagemakerModel_containers
=== PAUSE TestAccAWSSagemakerModel_containers
=== RUN   TestAccAWSSagemakerModel_vpcConfig
=== PAUSE TestAccAWSSagemakerModel_vpcConfig
=== RUN   TestAccAWSSagemakerModel_networkIsolation
=== PAUSE TestAccAWSSagemakerModel_networkIsolation
=== RUN   TestAccAWSSagemakerModel_disappears
=== PAUSE TestAccAWSSagemakerModel_disappears
=== CONT  TestAccAWSSagemakerModel_basic
=== CONT  TestAccAWSSagemakerModel_primaryContainerHostname
=== CONT  TestAccAWSSagemakerModel_tags
=== CONT  TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
=== CONT  TestAccAWSSagemakerModel_primaryContainerImageConfig
=== CONT  TestAccAWSSagemakerModel_vpcConfig
=== CONT  TestAccAWSSagemakerModel_containers
=== CONT  TestAccAWSSagemakerModel_inferenceExecutionConfig
=== CONT  TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_disappears
=== CONT  TestAccAWSSagemakerModel_primaryContainerModeSingle
--- PASS: TestAccAWSSagemakerModel_networkIsolation (38.14s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModeSingle (38.65s)
--- PASS: TestAccAWSSagemakerModel_basic (51.12s)
--- PASS: TestAccAWSSagemakerModel_inferenceExecutionConfig (51.32s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerImageConfig (54.80s)
--- PASS: TestAccAWSSagemakerModel_disappears (56.85s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (57.93s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (59.18s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (60.40s)
--- PASS: TestAccAWSSagemakerModel_containers (61.73s)
--- PASS: TestAccAWSSagemakerModel_tags (79.27s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (82.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.140s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 98fa3b7 into hashicorp:main Jul 28, 2021
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 28, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_model_inf branch July 28, 2021 20:02
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants