Data ECS Container Definition Secrets

[MarZab]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please expose secrets the same way the environment is exposed on aws_ecs_container_definition.

A common pattern is to allow CI/CD to edit the existing aws_ecs_container_definition for setting the image path, but also setting the environment like VERSION. This requests will allow the secrets to be preserved as well.

New or Affected Resource(s)

• aws_ecs_container_definition

Potential Terraform Configuration

data "aws_ecs_task_definition" "previous" {
  task_definition = "task_name"
}
data "aws_ecs_container_definition" "previous" {
  task_definition = data.aws_ecs_task_definition.previous[0].family
  container_name = "container_name"
}
locals {
  # existing feature
  task_definition_image = data.aws_ecs_container_definition.previous[0].image
  container_environment = merge( data.aws_ecs_container_definition.previous[0].environment, var.container_environment )
  
  # requested feature
  container_secrets = merge( data.aws_ecs_container_definition.previous[0].secrets, var.container_secrets )

  container_definitions = [{
    # snip..
    image = local.task_definition_image
    environment = [for k, v in local.container_environment : tomap({
        name = k,
        value = v
      })],
     secrets = [for k, v in local.container_secrets : tomap({
        name = k,
        valueFrom = v
      })]
  }]
}
resource "aws_ecs_task_definition" "this" {
  # snip..
  container_definitions = jsonencode(local.container_definitions)
}

References

• aws_ecs_task_definition and continuous delivery to ecs #632

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.