r/appconfig_deployment: remove waiter since deployment time is configurable

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20279

Note

• since deployment time is dependent on that defined in the deployment's DeploymentStrategy, it is not practical to have the create CRUD operation wait as the value itself is defined by the practitioner and it can be a value as great as 24hrs (@suzuki-shunsuke points this out in more detail in It failed to create AppConfig Deployment if deployment_duration_in_minutes is over 20 #20279 🙌 ). Instead, this PR will record the deployment's state so practitioners can use that value to track progress and have their configurations complete without error.
• The ConflictException handling is preserved in aws/config.go since it helps automate the resource creation retry but if it's preferred to remove it all together, can do 👍
• Alternatively, we could probably make an API call to GetDeploymentStrategy to first retrieve the expected duration, and then pass that to the waiter..but perhaps even doing so would not guarantee the entire timeout duration 🤔

Output from acceptance testing:

--- PASS: TestAccAWSAppConfigDeployment_basic (23.74s)
--- PASS: TestAccAWSAppConfigDeployment_Tags (49.68s)

[bill-rich]

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigDeployment_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.40.20
=== RUN   TestAccAWSAppConfigDeployment_basic
=== PAUSE TestAccAWSAppConfigDeployment_basic
=== RUN   TestAccAWSAppConfigDeployment_PredefinedStrategy
=== PAUSE TestAccAWSAppConfigDeployment_PredefinedStrategy
=== RUN   TestAccAWSAppConfigDeployment_Tags
=== PAUSE TestAccAWSAppConfigDeployment_Tags
=== CONT  TestAccAWSAppConfigDeployment_basic
=== CONT  TestAccAWSAppConfigDeployment_Tags
=== CONT  TestAccAWSAppConfigDeployment_PredefinedStrategy
--- PASS: TestAccAWSAppConfigDeployment_PredefinedStrategy (145.29s)
--- PASS: TestAccAWSAppConfigDeployment_basic (216.61s)
--- PASS: TestAccAWSAppConfigDeployment_Tags (241.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	241.482s

[github-actions]

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.