Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretsManager Secret Replication #20293

Merged
merged 10 commits into from
Jul 24, 2021
Merged

SecretsManager Secret Replication #20293

merged 10 commits into from
Jul 24, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18280
Closes #17943

Output from acceptance testing (us-west-2):

--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (25.43s)
--- PASS: TestAccAwsSecretsManagerSecret_basic (25.71s)
--- PASS: TestAccAwsSecretsManagerSecret_basicReplica (27.40s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (37.34s)
--- FAIL: TestAccAwsSecretsManagerSecret_policy (39.13s) # pre-existing failure, unrelated to these changes
--- PASS: TestAccAwsSecretsManagerSecret_Description (39.37s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (45.47s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (60.60s)
--- PASS: TestAccAwsSecretsManagerSecret_overwriteReplica (64.59s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (65.90s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (78.11s)

Output from acceptance testing (GovCloud):

--- FAIL: TestAccAwsSecretsManagerSecret_overwriteReplica (2.32s) # test requires 3 regions, govcloud only has 2
--- PASS: TestAccAwsSecretsManagerSecret_basic (29.20s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (29.22s)
--- PASS: TestAccAwsSecretsManagerSecret_basicReplica (30.67s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (44.15s)
--- FAIL: TestAccAwsSecretsManagerSecret_policy (44.81s) # pre-existing failure, unrelated to these changes
--- PASS: TestAccAwsSecretsManagerSecret_Description (47.10s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (52.32s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (66.61s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (74.36s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (75.89s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2021
@YakDriver YakDriver marked this pull request as draft July 23, 2021 19:03
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 24, 2021
@YakDriver YakDriver marked this pull request as ready for review July 24, 2021 01:29
@YakDriver YakDriver changed the title [WIP] SecretsManager Secret Replication SecretsManager Secret Replication Jul 24, 2021
@YakDriver YakDriver self-assigned this Jul 24, 2021
@YakDriver
Copy link
Member Author

This is a continuation/fixup of #18280 started by @TomTucka. (That branch was named "main" so eaiser to cherry pick to a new branch.)

@YakDriver YakDriver added this to the v3.52.0 milestone Jul 24, 2021
@YakDriver YakDriver merged commit eefefe2 into main Jul 24, 2021
@YakDriver YakDriver deleted the f-secretsmanager-replica branch July 24, 2021 02:54
github-actions bot pushed a commit that referenced this pull request Jul 24, 2021
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets Manager: Support Secret Replication
1 participant