Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: dhcp_options_set should explain how to maintain default AWS NS #2031

Closed
alex1x opened this issue Oct 24, 2017 · 1 comment · Fixed by #2033
Closed

Documentation: dhcp_options_set should explain how to maintain default AWS NS #2031

alex1x opened this issue Oct 24, 2017 · 1 comment · Fixed by #2033

Comments

@alex1x
Copy link
Contributor

alex1x commented Oct 24, 2017

The documentation here doesn't mention anything about how to keep the default AWS NS: https://www.terraform.io/docs/providers/aws/r/vpc_dhcp_options.html

More specifically, when you set DHCP options, if you're not specifying external/own DNS NS, then you would (probably) want to default to the standard AWS NS. This should probably be the default behavior, but it isn't. What actually happens when you don't specify domain_name_servers is that resolution breaks (or rather you have to manually configure it to make it work by editing /etc/resolv.conf to point to default AWS NS or such). That's fine, but it should at least be mentioned in the docs.

For more on this: http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_DHCP_Options.html#AmazonDNS

I'll make a PR to include a note and warning about this behavior in the docs.

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant