Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgre_sql_settings configuration block in aws_dms_endpoint #20395

Closed
evairmarinho opened this issue Aug 2, 2021 · 3 comments · Fixed by #34724
Closed

Add postgre_sql_settings configuration block in aws_dms_endpoint #20395

evairmarinho opened this issue Aug 2, 2021 · 3 comments · Fixed by #34724
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@evairmarinho
Copy link

evairmarinho commented Aug 2, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The resource aws_dms_endpoint doesn't have postgre_sql_settings configuration block.

New or Affected Resource(s)

aws_dms_endpoint

Potential Terraform Configuration

resource "aws_dms_endpoint" "my_endpoint" {
 ...
  postgre_sql_settings = {
  after_connect_script = "afterConnectScript=SET session_replication_role='replica' "
  capture_ddls = false
 
  ## To verify other arguments available, access https://docs.aws.amazon.com/cli/latest/reference/dms/create-endpoint.html
  }
...
}

References

https://docs.aws.amazon.com/cli/latest/reference/dms/create-endpoint.html
https://docs.aws.amazon.com/sdk-for-go/api/service/databasemigrationservice/#PostgreSQLSettings

@evairmarinho evairmarinho added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 2, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/databasemigrationservice labels Aug 2, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 18, 2021
@ewbankkit ewbankkit added the service/dms Issues and PRs that pertain to the dms service. label Jun 2, 2022
@YakDriver
Copy link
Member

This should be handled with a new resource instead. See #23506.

Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants