Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appconfig_deployment: add predefined strategies to validation of deployment_strategy_id #20418

Closed
anGie44 opened this issue Aug 3, 2021 · 1 comment · Fixed by #20420
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appconfig Issues and PRs that pertain to the appconfig service.

Comments

@anGie44
Copy link
Contributor

anGie44 commented Aug 3, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

A Deployment's deployment strategy id can now reference predefined Deployment Strategies which are prefixed with AppConfig. Currently, plan-time validation only accounts for ^[a-z0-9]{4,7} patterns.

"deployment_strategy_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringMatch(regexp.MustCompile(`[a-z0-9]{4,7}`), ""),
},

New or Affected Resource(s)

  • aws_appconfig_deployment

References

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 3, 2021
@github-actions github-actions bot added the service/appconfig Issues and PRs that pertain to the appconfig service. label Aug 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appconfig Issues and PRs that pertain to the appconfig service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant