r/apigateway_vpc_link: move stateConf to internal/service/apigateway and update delete target status

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20316

Output from acceptance testing before change:

Error: error waiting for API Gateway VPC Link (63k00x) deletion: couldn't find resource (21 retries)

    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: error waiting for API Gateway VPC Link (63k00x) deletion: couldn't find resource (21 retries)
--- FAIL: TestAccAWSAPIGatewayVpcLink_basic (849.54s)

Output from acceptance testing after change:

--- PASS: TestAccAWSAPIGatewayVpcLink_disappears (704.22s)
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (725.88s)
--- PASS: TestAccAWSAPIGatewayVpcLink_tags (726.58s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_tags (63.22s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayVpcLink_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayVpcLink_ -timeout 180m
=== RUN   TestAccAWSAPIGatewayVpcLink_basic
=== PAUSE TestAccAWSAPIGatewayVpcLink_basic
=== RUN   TestAccAWSAPIGatewayVpcLink_tags
=== PAUSE TestAccAWSAPIGatewayVpcLink_tags
=== RUN   TestAccAWSAPIGatewayVpcLink_disappears
=== PAUSE TestAccAWSAPIGatewayVpcLink_disappears
=== CONT  TestAccAWSAPIGatewayVpcLink_basic
=== CONT  TestAccAWSAPIGatewayVpcLink_disappears
=== CONT  TestAccAWSAPIGatewayVpcLink_tags
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (701.63s)
--- PASS: TestAccAWSAPIGatewayVpcLink_disappears (716.03s)
--- PASS: TestAccAWSAPIGatewayVpcLink_tags (734.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	738.059s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayVpcLink_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayVpcLink_ -timeout 180m
=== RUN   TestAccAWSAPIGatewayVpcLink_basic
=== PAUSE TestAccAWSAPIGatewayVpcLink_basic
=== RUN   TestAccAWSAPIGatewayVpcLink_tags
=== PAUSE TestAccAWSAPIGatewayVpcLink_tags
=== RUN   TestAccAWSAPIGatewayVpcLink_disappears
=== PAUSE TestAccAWSAPIGatewayVpcLink_disappears
=== CONT  TestAccAWSAPIGatewayVpcLink_basic
=== CONT  TestAccAWSAPIGatewayVpcLink_disappears
=== CONT  TestAccAWSAPIGatewayVpcLink_tags
--- PASS: TestAccAWSAPIGatewayVpcLink_disappears (685.10s)
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (693.47s)
--- PASS: TestAccAWSAPIGatewayVpcLink_tags (730.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	733.910s

[lorelei-rupp-imprivata]

Thank you for fixing this issue that was causing us headaches!!! How long till it is in a release usually?

[anGie44]

Hi @lorelei-rupp-imprivata , this will likely be released later today with v3.53.0 of the AWS provider. Our releases are generally every Thursday evening EST.

[github-actions]

This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.