r/aws_synthetics_canary: Correctly report creation errors

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18636.
Closes #18616.

The underlying problem was the retry logic around create - The error code wasn't being checked which meant that resourceAwsSyntheticsCanaryRead() (and hence finder.CanaryByName()) was being called when d.SetId() hadn't.
After correcting that, the underlying acceptance tests errors were all related to an out-of-date runtime.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSyntheticsCanary_'     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSyntheticsCanary_ -timeout 180m
=== RUN   TestAccAWSSyntheticsCanary_basic
=== PAUSE TestAccAWSSyntheticsCanary_basic
=== RUN   TestAccAWSSyntheticsCanary_runtimeVersion
=== PAUSE TestAccAWSSyntheticsCanary_runtimeVersion
=== RUN   TestAccAWSSyntheticsCanary_startCanary
=== PAUSE TestAccAWSSyntheticsCanary_startCanary
=== RUN   TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== PAUSE TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== RUN   TestAccAWSSyntheticsCanary_s3
=== PAUSE TestAccAWSSyntheticsCanary_s3
=== RUN   TestAccAWSSyntheticsCanary_runConfig
=== PAUSE TestAccAWSSyntheticsCanary_runConfig
=== RUN   TestAccAWSSyntheticsCanary_runConfigTracing
=== PAUSE TestAccAWSSyntheticsCanary_runConfigTracing
=== RUN   TestAccAWSSyntheticsCanary_vpc
=== PAUSE TestAccAWSSyntheticsCanary_vpc
=== RUN   TestAccAWSSyntheticsCanary_tags
=== PAUSE TestAccAWSSyntheticsCanary_tags
=== RUN   TestAccAWSSyntheticsCanary_disappears
=== PAUSE TestAccAWSSyntheticsCanary_disappears
=== CONT  TestAccAWSSyntheticsCanary_basic
=== CONT  TestAccAWSSyntheticsCanary_runConfigTracing
=== CONT  TestAccAWSSyntheticsCanary_disappears
=== CONT  TestAccAWSSyntheticsCanary_vpc
=== CONT  TestAccAWSSyntheticsCanary_tags
=== CONT  TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== CONT  TestAccAWSSyntheticsCanary_runConfig
=== CONT  TestAccAWSSyntheticsCanary_runtimeVersion
=== CONT  TestAccAWSSyntheticsCanary_startCanary
=== CONT  TestAccAWSSyntheticsCanary_s3
--- PASS: TestAccAWSSyntheticsCanary_disappears (48.46s)
--- PASS: TestAccAWSSyntheticsCanary_s3 (67.11s)
--- PASS: TestAccAWSSyntheticsCanary_basic (93.51s)
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (96.91s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (97.36s)
--- PASS: TestAccAWSSyntheticsCanary_tags (99.72s)
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (101.69s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (102.51s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (114.58s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (673.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	676.924s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSyntheticsCanary_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSyntheticsCanary_ -timeout 180m
=== RUN   TestAccAWSSyntheticsCanary_basic
=== PAUSE TestAccAWSSyntheticsCanary_basic
=== RUN   TestAccAWSSyntheticsCanary_runtimeVersion
=== PAUSE TestAccAWSSyntheticsCanary_runtimeVersion
=== RUN   TestAccAWSSyntheticsCanary_startCanary
=== PAUSE TestAccAWSSyntheticsCanary_startCanary
=== RUN   TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== PAUSE TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== RUN   TestAccAWSSyntheticsCanary_s3
=== PAUSE TestAccAWSSyntheticsCanary_s3
=== RUN   TestAccAWSSyntheticsCanary_runConfig
=== PAUSE TestAccAWSSyntheticsCanary_runConfig
=== RUN   TestAccAWSSyntheticsCanary_runConfigTracing
=== PAUSE TestAccAWSSyntheticsCanary_runConfigTracing
=== RUN   TestAccAWSSyntheticsCanary_vpc
=== PAUSE TestAccAWSSyntheticsCanary_vpc
=== RUN   TestAccAWSSyntheticsCanary_tags
=== PAUSE TestAccAWSSyntheticsCanary_tags
=== RUN   TestAccAWSSyntheticsCanary_disappears
=== PAUSE TestAccAWSSyntheticsCanary_disappears
=== CONT  TestAccAWSSyntheticsCanary_basic
=== CONT  TestAccAWSSyntheticsCanary_runConfigTracing
=== CONT  TestAccAWSSyntheticsCanary_startCanary_codeChanges
=== CONT  TestAccAWSSyntheticsCanary_s3
=== CONT  TestAccAWSSyntheticsCanary_disappears
=== CONT  TestAccAWSSyntheticsCanary_tags
=== CONT  TestAccAWSSyntheticsCanary_vpc
=== CONT  TestAccAWSSyntheticsCanary_runtimeVersion
=== CONT  TestAccAWSSyntheticsCanary_runConfig
=== CONT  TestAccAWSSyntheticsCanary_startCanary
--- PASS: TestAccAWSSyntheticsCanary_disappears (63.68s)
--- PASS: TestAccAWSSyntheticsCanary_s3 (70.33s)
--- PASS: TestAccAWSSyntheticsCanary_tags (107.20s)
--- PASS: TestAccAWSSyntheticsCanary_basic (108.20s)
--- PASS: TestAccAWSSyntheticsCanary_runConfigTracing (108.31s)
--- PASS: TestAccAWSSyntheticsCanary_runtimeVersion (108.56s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary_codeChanges (116.20s)
--- PASS: TestAccAWSSyntheticsCanary_runConfig (117.67s)
--- PASS: TestAccAWSSyntheticsCanary_startCanary (121.42s)
--- PASS: TestAccAWSSyntheticsCanary_vpc (1788.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1791.753s

[anGie44]

LGTM 🚀

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.