Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo for passwords field in elasticache user and extending timeouts #20530

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

josephkphan
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Resolves #20529

Fix typo in password field in elasticache user update method, and extend the default timeout for the resource. It takes ~4 minutes to update on an average basis

@josephkphan josephkphan changed the title Fixing utypo for passwords field in elasticache user and extending timeouts Fixing typo for passwords field in elasticache user and extending timeouts Aug 11, 2021
@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Aug 11, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @josephkphan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 17, 2021
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Aug 17, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSElasticacheUser_'                             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheUser_ -timeout 180m
=== RUN   TestAccAWSElasticacheUser_basic
=== PAUSE TestAccAWSElasticacheUser_basic
=== RUN   TestAccAWSElasticacheUser_update
=== PAUSE TestAccAWSElasticacheUser_update
=== RUN   TestAccAWSElasticacheUser_tags
=== PAUSE TestAccAWSElasticacheUser_tags
=== RUN   TestAccAWSElasticacheUser_disappears
=== PAUSE TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_basic
=== CONT  TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_update
=== CONT  TestAccAWSElasticacheUser_tags
--- PASS: TestAccAWSElasticacheUser_basic (88.73s)
--- PASS: TestAccAWSElasticacheUser_tags (90.83s)
--- PASS: TestAccAWSElasticacheUser_disappears (94.93s)
--- PASS: TestAccAWSElasticacheUser_update (199.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       203.510s

@ewbankkit
Copy link
Contributor

@josephkphan Thanks for the contribution 🎉 👏.
I removed the custom Create timeout value as it is not referenced in the resource.

@ewbankkit ewbankkit merged commit e8813c9 into hashicorp:main Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in aws_elasticache_user update method is preventing password rotation
3 participants