Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsx backup - new resource #20569

Merged
merged 11 commits into from
Aug 17, 2021
Merged

Fsx backup - new resource #20569

merged 11 commits into from
Aug 17, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19566

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxBackup_'
--- PASS: TestAccAWSFsxBackup_basic (774.71s)
--- PASS: TestAccAWSFsxBackup_disappears_filesystem (811.75s)
--- PASS: TestAccAWSFsxBackup_disappears (822.20s)
--- PASS: TestAccAWSFsxBackup_implictTags (840.82s)
--- PASS: TestAccAWSFsxBackup_tags (936.00s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 14, 2021
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed service/backup Issues and PRs that pertain to the backup service. labels Aug 14, 2021
@github-actions github-actions bot added service/backup Issues and PRs that pertain to the backup service. and removed service/backup Issues and PRs that pertain to the backup service. labels Aug 14, 2021
@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Aug 14, 2021
@DrFaust92 DrFaust92 removed the service/backup Issues and PRs that pertain to the backup service. label Aug 14, 2021
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@github-actions github-actions bot added the service/backup Issues and PRs that pertain to the backup service. label Aug 17, 2021
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@ewbankkit ewbankkit self-assigned this Aug 17, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSFsxBackup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxBackup_ -timeout 180m
=== RUN   TestAccAWSFsxBackup_basic
=== PAUSE TestAccAWSFsxBackup_basic
=== RUN   TestAccAWSFsxBackup_disappears
=== PAUSE TestAccAWSFsxBackup_disappears
=== RUN   TestAccAWSFsxBackup_disappears_filesystem
=== PAUSE TestAccAWSFsxBackup_disappears_filesystem
=== RUN   TestAccAWSFsxBackup_tags
=== PAUSE TestAccAWSFsxBackup_tags
=== RUN   TestAccAWSFsxBackup_implictTags
=== PAUSE TestAccAWSFsxBackup_implictTags
=== CONT  TestAccAWSFsxBackup_basic
=== CONT  TestAccAWSFsxBackup_tags
=== CONT  TestAccAWSFsxBackup_implictTags
=== CONT  TestAccAWSFsxBackup_disappears_filesystem
=== CONT  TestAccAWSFsxBackup_disappears
--- PASS: TestAccAWSFsxBackup_basic (724.25s)
--- PASS: TestAccAWSFsxBackup_tags (763.39s)
--- PASS: TestAccAWSFsxBackup_disappears (784.26s)
--- PASS: TestAccAWSFsxBackup_implictTags (787.03s)
--- PASS: TestAccAWSFsxBackup_disappears_filesystem (1546.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1550.678s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSFsxBackup_'           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxBackup_ -timeout 180m
=== RUN   TestAccAWSFsxBackup_basic
=== PAUSE TestAccAWSFsxBackup_basic
=== RUN   TestAccAWSFsxBackup_disappears
=== PAUSE TestAccAWSFsxBackup_disappears
=== RUN   TestAccAWSFsxBackup_disappears_filesystem
=== PAUSE TestAccAWSFsxBackup_disappears_filesystem
=== RUN   TestAccAWSFsxBackup_tags
=== PAUSE TestAccAWSFsxBackup_tags
=== RUN   TestAccAWSFsxBackup_implictTags
=== PAUSE TestAccAWSFsxBackup_implictTags
=== CONT  TestAccAWSFsxBackup_basic
=== CONT  TestAccAWSFsxBackup_tags
=== CONT  TestAccAWSFsxBackup_implictTags
=== CONT  TestAccAWSFsxBackup_disappears_filesystem
=== CONT  TestAccAWSFsxBackup_disappears
--- PASS: TestAccAWSFsxBackup_disappears (768.91s)
--- PASS: TestAccAWSFsxBackup_basic (770.46s)
--- PASS: TestAccAWSFsxBackup_tags (775.10s)
--- PASS: TestAccAWSFsxBackup_disappears_filesystem (790.10s)
--- PASS: TestAccAWSFsxBackup_implictTags (834.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	838.627s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1b5a715 into hashicorp:main Aug 17, 2021
@ewbankkit ewbankkit removed their assignment Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@DrFaust92 DrFaust92 deleted the fsx_backup branch August 17, 2021 16:44
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants