Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_human_task_ui - new resource #20570

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerHumanTaskUi_'
--- PASS: TestAccAWSSagemakerHumanTaskUi_basic (122.65s)
--- PASS: TestAccAWSSagemakerHumanTaskUi_tags (194.21s)
--- PASS: TestAccAWSSagemakerHumanTaskUi_disappears (40.24s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 14, 2021
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 14, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Aug 14, 2021
@ewbankkit ewbankkit self-assigned this Aug 17, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemakerHumanTaskUi_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerHumanTaskUi_ -timeout 180m
=== RUN   TestAccAWSSagemakerHumanTaskUi_basic
--- PASS: TestAccAWSSagemakerHumanTaskUi_basic (15.94s)
=== RUN   TestAccAWSSagemakerHumanTaskUi_tags
--- PASS: TestAccAWSSagemakerHumanTaskUi_tags (35.72s)
=== RUN   TestAccAWSSagemakerHumanTaskUi_disappears
--- PASS: TestAccAWSSagemakerHumanTaskUi_disappears (11.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       65.856s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerHumanTaskUi_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerHumanTaskUi_ -timeout 180m
=== RUN   TestAccAWSSagemakerHumanTaskUi_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-4457565486406016596): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 562be9d1-34c5-4c9d-ba4e-b47a52f56f15
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
--- SKIP: TestAccAWSSagemakerHumanTaskUi_basic (7.02s)
=== RUN   TestAccAWSSagemakerHumanTaskUi_tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-7446246011339732003): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 3297ba62-19ca-4832-8f7f-0790829ace56
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
--- SKIP: TestAccAWSSagemakerHumanTaskUi_tags (5.64s)
=== RUN   TestAccAWSSagemakerHumanTaskUi_disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker HumanTaskUi (tf-acc-test-7155829206885126599): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 1c025a34-944f-4116-ab69-fbb7097a16cc
        
          with aws_sagemaker_human_task_ui.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_human_task_ui" "test":
           2: resource "aws_sagemaker_human_task_ui" "test" {
        
--- SKIP: TestAccAWSSagemakerHumanTaskUi_disappears (5.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.395s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f2d8fea into hashicorp:main Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@ewbankkit ewbankkit removed their assignment Aug 17, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_human_task_ui branch August 17, 2021 16:44
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants