Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/fsx_windows_fs - create from backup + move fsx common functions to internal package #20643

Merged
merged 6 commits into from
Aug 23, 2021
Merged

r/fsx_windows_fs - create from backup + move fsx common functions to internal package #20643

merged 6 commits into from
Aug 23, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19566

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_'
--- PASS: TestAccAWSFsxLustreFileSystem_disappears
--- PASS: TestAccAWSFsxLustreFileSystem_basic

$ make testacc TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_fromBackup'
--- PASS: TestAccAWSFsxWindowsFileSystem_fromBackup (6268.80s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 20, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 21, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review August 22, 2021 08:32
ewbankkit
ewbankkit approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_\|TestAccAWSFsxWindowsFileSystem_fromBackup\|TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_\|TestAccAWSFsxWindowsFileSystem_fromBackup\|TestAccAWSFsxWindowsFileSystem_basic -timeout 180m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_disappears
=== PAUSE TestAccAWSFsxLustreFileSystem_disappears
=== RUN   TestAccAWSFsxLustreFileSystem_dataCompression
=== PAUSE TestAccAWSFsxLustreFileSystem_dataCompression
=== RUN   TestAccAWSFsxLustreFileSystem_ExportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ExportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== RUN   TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== RUN   TestAccAWSFsxLustreFileSystem_Tags
=== PAUSE TestAccAWSFsxLustreFileSystem_Tags
=== RUN   TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== RUN   TestAccAWSFsxLustreFileSystem_fromBackup
=== PAUSE TestAccAWSFsxLustreFileSystem_fromBackup
=== RUN   TestAccAWSFsxLustreFileSystem_KmsKeyId
=== PAUSE TestAccAWSFsxLustreFileSystem_KmsKeyId
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== RUN   TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== RUN   TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== RUN   TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== RUN   TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== RUN   TestAccAWSFsxWindowsFileSystem_fromBackup
=== PAUSE TestAccAWSFsxWindowsFileSystem_fromBackup
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== CONT  TestAccAWSFsxLustreFileSystem_dataCompression
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_Tags
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== CONT  TestAccAWSFsxWindowsFileSystem_fromBackup
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== CONT  TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== CONT  TestAccAWSFsxLustreFileSystem_KmsKeyId
=== CONT  TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccAWSFsxLustreFileSystem_fromBackup
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== CONT  TestAccAWSFsxLustreFileSystem_ExportPath
=== CONT  TestAccAWSFsxLustreFileSystem_SecurityGroupIds
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (558.51s)
=== CONT  TestAccAWSFsxLustreFileSystem_ImportPath
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (621.05s)
=== CONT  TestAccAWSFsxLustreFileSystem_disappears
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone (661.16s)
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead (686.09s)
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (690.73s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (721.31s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (728.45s)
--- PASS: TestAccAWSFsxLustreFileSystem_copyTagsToBackups (729.17s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (749.79s)
--- PASS: TestAccAWSFsxLustreFileSystem_dataCompression (811.01s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (358.83s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1193.44s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 (532.63s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1246.00s)
--- PASS: TestAccAWSFsxLustreFileSystem_KmsKeyId (1257.43s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1340.02s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1449.84s)
--- PASS: TestAccAWSFsxLustreFileSystem_fromBackup (1455.37s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1494.75s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (1866.25s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1992.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate (2657.71s)
--- PASS: TestAccAWSFsxWindowsFileSystem_fromBackup (3466.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       3469.595s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_\|TestAccAWSFsxWindowsFileSystem_fromBackup\|TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_\|TestAccAWSFsxWindowsFileSystem_fromBackup\|TestAccAWSFsxWindowsFileSystem_basic -timeout 180m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_disappears
=== PAUSE TestAccAWSFsxLustreFileSystem_disappears
=== RUN   TestAccAWSFsxLustreFileSystem_dataCompression
=== PAUSE TestAccAWSFsxLustreFileSystem_dataCompression
=== RUN   TestAccAWSFsxLustreFileSystem_ExportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ExportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== RUN   TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== RUN   TestAccAWSFsxLustreFileSystem_Tags
=== PAUSE TestAccAWSFsxLustreFileSystem_Tags
=== RUN   TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== RUN   TestAccAWSFsxLustreFileSystem_fromBackup
=== PAUSE TestAccAWSFsxLustreFileSystem_fromBackup
=== RUN   TestAccAWSFsxLustreFileSystem_KmsKeyId
=== PAUSE TestAccAWSFsxLustreFileSystem_KmsKeyId
=== RUN   TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== PAUSE TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== RUN   TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== RUN   TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== RUN   TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== RUN   TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== RUN   TestAccAWSFsxWindowsFileSystem_fromBackup
=== PAUSE TestAccAWSFsxWindowsFileSystem_fromBackup
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== CONT  TestAccAWSFsxLustreFileSystem_Tags
=== CONT  TestAccAWSFsxLustreFileSystem_dataCompression
=== CONT  TestAccAWSFsxWindowsFileSystem_fromBackup
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== CONT  TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone
=== CONT  TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead
=== CONT  TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2
=== CONT  TestAccAWSFsxLustreFileSystem_KmsKeyId
=== CONT  TestAccAWSFsxLustreFileSystem_fromBackup
=== CONT  TestAccAWSFsxLustreFileSystem_ImportPath
=== CONT  TestAccAWSFsxLustreFileSystem_disappears
=== CONT  TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate
=== CONT  TestAccAWSFsxLustreFileSystem_ExportPath
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone (565.79s)
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
--- PASS: TestAccAWSFsxLustreFileSystem_copyTagsToBackups (565.84s)
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (650.60s)
=== CONT  TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (652.87s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 (653.44s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (657.31s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (658.12s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead (664.06s)
=== CONT  TestAccAWSFsxWindowsFileSystem_fromBackup
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (740.76s)
--- PASS: TestAccAWSFsxLustreFileSystem_dataCompression (954.36s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (974.68s)
--- PASS: TestAccAWSFsxLustreFileSystem_KmsKeyId (1037.61s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1039.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (510.66s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1081.31s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1081.59s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (432.28s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1104.34s)
--- PASS: TestAccAWSFsxLustreFileSystem_fromBackup (1179.50s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (1251.14s)
--- PASS: TestAccAWSFsxWindowsFileSystem_fromBackup (4655.33s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1103.32s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacityUpdate (2248.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4658.622s

ewbankkit and others added 2 commits August 23, 2021 11:27
@ewbankkit
Tweak error messages.
bb68e59
@DrFaust92 @ewbankkit
Apply suggestions from code review
8e83f52 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@ewbankkit ewbankkit merged commit 1eb1f09 into hashicorp:main Aug 23, 2021
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 23, 2021
@DrFaust92 DrFaust92 deleted the r/fsx_windows_fs_from_backup branch August 23, 2021 16:09
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.56.0
Development

Successfully merging this pull request may close these issues.

Couldn't find FSX API Call - CreateFileSystemFromBackup
2 participants
@DrFaust92 @ewbankkit