Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/route53_health_check - add arn attribute + validations #20653

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 22, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
--- PASS: TestAccAWSRoute53HealthCheck_disappears (72.43s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (113.53s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (115.75s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (119.50s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (122.71s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (155.19s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (169.49s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (174.29s)
--- PASS: TestAccAWSRoute53HealthCheck_Disabled (210.75s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (212.19s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (213.95s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 22, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_ -timeout 180m
=== RUN   TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== RUN   TestAccAWSRoute53HealthCheck_tags
=== PAUSE TestAccAWSRoute53HealthCheck_tags
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
=== PAUSE TestAccAWSRoute53HealthCheck_withSearchString
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== RUN   TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
=== PAUSE TestAccAWSRoute53HealthCheck_IpConfig
=== RUN   TestAccAWSRoute53HealthCheck_Ipv6Config
=== PAUSE TestAccAWSRoute53HealthCheck_Ipv6Config
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== PAUSE TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== RUN   TestAccAWSRoute53HealthCheck_withSNI
=== PAUSE TestAccAWSRoute53HealthCheck_withSNI
=== RUN   TestAccAWSRoute53HealthCheck_Disabled
=== PAUSE TestAccAWSRoute53HealthCheck_Disabled
=== RUN   TestAccAWSRoute53HealthCheck_disappears
=== PAUSE TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_basic
=== CONT  TestAccAWSRoute53HealthCheck_Ipv6Config
=== CONT  TestAccAWSRoute53HealthCheck_withSNI
=== CONT  TestAccAWSRoute53HealthCheck_withSearchString
=== CONT  TestAccAWSRoute53HealthCheck_Disabled
=== CONT  TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== CONT  TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== CONT  TestAccAWSRoute53HealthCheck_tags
=== CONT  TestAccAWSRoute53HealthCheck_IpConfig
=== CONT  TestAccAWSRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccAWSRoute53HealthCheck_disappears (31.76s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (41.74s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (41.74s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (42.01s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (42.90s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (51.52s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (54.19s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (56.53s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (64.28s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (65.73s)
--- PASS: TestAccAWSRoute53HealthCheck_Disabled (65.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.874s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_ -timeout 180m
=== RUN   TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== RUN   TestAccAWSRoute53HealthCheck_tags
=== PAUSE TestAccAWSRoute53HealthCheck_tags
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
=== PAUSE TestAccAWSRoute53HealthCheck_withSearchString
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== RUN   TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
=== PAUSE TestAccAWSRoute53HealthCheck_IpConfig
=== RUN   TestAccAWSRoute53HealthCheck_Ipv6Config
=== PAUSE TestAccAWSRoute53HealthCheck_Ipv6Config
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== PAUSE TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== RUN   TestAccAWSRoute53HealthCheck_withSNI
=== PAUSE TestAccAWSRoute53HealthCheck_withSNI
=== RUN   TestAccAWSRoute53HealthCheck_Disabled
=== PAUSE TestAccAWSRoute53HealthCheck_Disabled
=== RUN   TestAccAWSRoute53HealthCheck_disappears
=== PAUSE TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_basic
=== CONT  TestAccAWSRoute53HealthCheck_Ipv6Config
=== CONT  TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== CONT  TestAccAWSRoute53HealthCheck_IpConfig
=== CONT  TestAccAWSRoute53HealthCheck_Disabled
=== CONT  TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== CONT  TestAccAWSRoute53HealthCheck_withSearchString
=== CONT  TestAccAWSRoute53HealthCheck_tags
=== CONT  TestAccAWSRoute53HealthCheck_withSNI
=== CONT  TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== CONT  TestAccAWSRoute53HealthCheck_withHealthCheckRegions
    provider_test.go:780: skipping tests; current partition (aws-us-gov) does not equal aws
--- SKIP: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (1.29s)
=== CONT  TestAccAWSRoute53HealthCheck_tags
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Regional control plane current does not support latency health check
        	status code: 400, request id: bca15e4e-2ed6-43f7-a4b8-2ad487e77c3c
        
          with aws_route53_health_check.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
           2: resource "aws_route53_health_check" "test" {
        
--- SKIP: TestAccAWSRoute53HealthCheck_tags (16.16s)
=== CONT  TestAccAWSRoute53HealthCheck_withSearchString
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Regional control plane current does not support latency health check
        	status code: 400, request id: 862ff106-5b1c-402b-9f1a-b65094fc6e17
        
          with aws_route53_health_check.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
           2: resource "aws_route53_health_check" "test" {
        
--- SKIP: TestAccAWSRoute53HealthCheck_withSearchString (16.94s)
=== CONT  TestAccAWSRoute53HealthCheck_withSNI
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Regional control plane current does not support latency health check
        	status code: 400, request id: f301ef6f-7b19-4a5c-a40b-2fb70976bfcb
        
          with aws_route53_health_check.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
           2: resource "aws_route53_health_check" "test" {
        
=== CONT  TestAccAWSRoute53HealthCheck_disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Regional control plane current does not support latency health check
        	status code: 400, request id: 6ee7b95c-2bfd-4d7f-9177-8daad2e1366e
        
          with aws_route53_health_check.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
           2: resource "aws_route53_health_check" "test" {
        
--- SKIP: TestAccAWSRoute53HealthCheck_withSNI (17.39s)
=== CONT  TestAccAWSRoute53HealthCheck_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Regional control plane current does not support latency health check
        	status code: 400, request id: 32913224-a4e0-420f-af7b-6f7df44d0bd3
        
          with aws_route53_health_check.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_health_check" "test":
           2: resource "aws_route53_health_check" "test" {
        
--- SKIP: TestAccAWSRoute53HealthCheck_disappears (17.71s)
--- SKIP: TestAccAWSRoute53HealthCheck_basic (17.93s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (40.98s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (43.46s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (43.97s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (52.61s)
--- PASS: TestAccAWSRoute53HealthCheck_Disabled (71.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.638s

@ewbankkit ewbankkit merged commit a6183cc into hashicorp:main Aug 23, 2021
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 23, 2021
@DrFaust92 DrFaust92 deleted the route53_hc_arn branch August 23, 2021 18:55
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants