rd/route53_delegation_set - add arn attribute + remove resource from state when doesn't exist

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53DelegationSet_'
--- PASS: TestAccAWSRoute53DelegationSet_disappears (46.16s)
--- PASS: TestAccAWSRoute53DelegationSet_basic (63.57s)
--- PASS: TestAccAWSRoute53DelegationSet_withZones (126.55s)

$ make testacc TESTARGS='-run=TestAccAWSRoute53DelegationSetDataSource_basic'
--- PASS: TestAccAWSRoute53DelegationSetDataSource_basic (99.35s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSRoute53DelegationSet_\|TestAccAWSRoute53DelegationSetDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53DelegationSet_\|TestAccAWSRoute53DelegationSetDataSource_ -timeout 180m
=== RUN   TestAccAWSRoute53DelegationSetDataSource_basic
--- PASS: TestAccAWSRoute53DelegationSetDataSource_basic (62.28s)
=== RUN   TestAccAWSRoute53DelegationSet_basic
=== PAUSE TestAccAWSRoute53DelegationSet_basic
=== RUN   TestAccAWSRoute53DelegationSet_withZones
=== PAUSE TestAccAWSRoute53DelegationSet_withZones
=== RUN   TestAccAWSRoute53DelegationSet_disappears
=== PAUSE TestAccAWSRoute53DelegationSet_disappears
=== CONT  TestAccAWSRoute53DelegationSet_basic
=== CONT  TestAccAWSRoute53DelegationSet_disappears
=== CONT  TestAccAWSRoute53DelegationSet_withZones
--- PASS: TestAccAWSRoute53DelegationSet_disappears (9.52s)
--- PASS: TestAccAWSRoute53DelegationSet_basic (12.83s)
--- PASS: TestAccAWSRoute53DelegationSet_withZones (59.87s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       125.587s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSRoute53DelegationSet_\|TestAccAWSRoute53DelegationSetDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53DelegationSet_\|TestAccAWSRoute53DelegationSetDataSource_ -timeout 180m
=== RUN   TestAccAWSRoute53DelegationSetDataSource_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 0df4f4ac-879e-49ab-8e6b-ae88673d7cff
        
          with aws_route53_delegation_set.dset,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_delegation_set" "dset":
           2: resource "aws_route53_delegation_set" "dset" {
        
--- SKIP: TestAccAWSRoute53DelegationSetDataSource_basic (7.09s)
=== RUN   TestAccAWSRoute53DelegationSet_basic
=== PAUSE TestAccAWSRoute53DelegationSet_basic
=== RUN   TestAccAWSRoute53DelegationSet_withZones
=== PAUSE TestAccAWSRoute53DelegationSet_withZones
=== RUN   TestAccAWSRoute53DelegationSet_disappears
=== PAUSE TestAccAWSRoute53DelegationSet_disappears
=== CONT  TestAccAWSRoute53DelegationSet_basic
=== CONT  TestAccAWSRoute53DelegationSet_disappears
=== CONT  TestAccAWSRoute53DelegationSet_withZones
=== CONT  TestAccAWSRoute53DelegationSet_disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 6a8621eb-4d70-45b9-86bf-3c5cda7b9eb4
        
          with aws_route53_delegation_set.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_delegation_set" "test":
           2: resource "aws_route53_delegation_set" "test" {
        
=== CONT  TestAccAWSRoute53DelegationSet_withZones
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: 09ae068d-8574-4c06-9bb4-361b621c0fb4
        
          with aws_route53_delegation_set.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_delegation_set" "test":
           2: resource "aws_route53_delegation_set" "test" {
        
=== CONT  TestAccAWSRoute53DelegationSet_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: InvalidInput: Operations related to PublicDNS are not supported in this aws partition.
        	status code: 400, request id: a1759455-7090-4ad9-b500-8fc9edae282f
        
          with aws_route53_delegation_set.test,
          on terraform_plugin_test.tf line 2, in resource "aws_route53_delegation_set" "test":
           2: resource "aws_route53_delegation_set" "test" {
        
--- SKIP: TestAccAWSRoute53DelegationSet_disappears (6.05s)
--- SKIP: TestAccAWSRoute53DelegationSet_withZones (6.07s)
--- SKIP: TestAccAWSRoute53DelegationSet_basic (6.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.470s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.