Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/route53_query_log - add arn attribute + remove resource from state when doesn't exist #20666

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17954.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53QueryLog_'
--- PASS: TestAccAWSRoute53QueryLog_disappears_hostedZone (131.76s)
--- PASS: TestAccAWSRoute53QueryLog_disappears (142.06s)
--- PASS: TestAccAWSRoute53QueryLog_basic (162.43s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 23, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 23, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSRoute53QueryLog_'                               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53QueryLog_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.40.27
=== RUN   TestAccAWSRoute53QueryLog_basic
=== PAUSE TestAccAWSRoute53QueryLog_basic
=== RUN   TestAccAWSRoute53QueryLog_disappears
=== PAUSE TestAccAWSRoute53QueryLog_disappears
=== RUN   TestAccAWSRoute53QueryLog_disappears_hostedZone
=== PAUSE TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT  TestAccAWSRoute53QueryLog_basic
=== CONT  TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT  TestAccAWSRoute53QueryLog_disappears
--- PASS: TestAccAWSRoute53QueryLog_disappears_hostedZone (54.82s)
--- PASS: TestAccAWSRoute53QueryLog_basic (61.39s)
--- PASS: TestAccAWSRoute53QueryLog_disappears (66.37s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.798s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSRoute53QueryLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53QueryLog_ -timeout 180m
=== RUN   TestAccAWSRoute53QueryLog_basic
=== PAUSE TestAccAWSRoute53QueryLog_basic
=== RUN   TestAccAWSRoute53QueryLog_disappears
=== PAUSE TestAccAWSRoute53QueryLog_disappears
=== RUN   TestAccAWSRoute53QueryLog_disappears_hostedZone
=== PAUSE TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT  TestAccAWSRoute53QueryLog_basic
=== CONT  TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT  TestAccAWSRoute53QueryLog_disappears
    route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
=== CONT  TestAccAWSRoute53QueryLog_basic
    route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
--- SKIP: TestAccAWSRoute53QueryLog_disappears (1.33s)
=== CONT  TestAccAWSRoute53QueryLog_disappears_hostedZone
    route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
--- SKIP: TestAccAWSRoute53QueryLog_basic (1.33s)
--- SKIP: TestAccAWSRoute53QueryLog_disappears_hostedZone (1.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.575s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1925aac into hashicorp:main Aug 24, 2021
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 24, 2021
@DrFaust92 DrFaust92 deleted the r/route53_query_log_config_arn branch August 24, 2021 12:16
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if aws_route53_query_log deleted outside of terraform - NoSuchQueryLoggingConfig
2 participants