Add platform_identifier support to r/aws_sagemaker_notebook_instance

[lastlee]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recently added support for PlatformIdentifier: the ability to specify AL1 or AL2 Sagemaker platforms: https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_DescribeNotebookInstance.html#sagemaker-DescribeNotebookInstance-response-PlatformIdentifier

One caveat: aws-sdk-go supports PlatformIdentifier but does not have supporting components for validation

New or Affected Resource(s)

• aws_sagemaker_notebook_instance

Potential Terraform Configuration

resource "aws_sagemaker_notebook_instance" "test" {
  name                = "test-notebook-al2"
  role_arn            = aws_iam_role.test.arn
  instance_type       = "ml.t2.medium"
  platform_identifier = "notebook-al2-v1"
}

References

• https://aws.amazon.com/about-aws/whats-new/2021/08/amazon-sagemaker-notebook-amazon-linux-2/

[anGie44]

@lastlee , thanks for raising this issue! If you're referring to plan-time validation components, within the resource code, you can use a regex instead within the platform_identifier field e.g.

"platform_identifier": {
  Type: schema.TypeString,
  ...,
  ValidateFunc: validation.StringMatch(regexp.MustCompile(`^(notebook-al1-v1|notebook-al2-v1)$`), ""),
}

[github-actions]

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.