Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add settings field to ecs.DescribeClustersInput #20720

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

1newsr
Copy link
Contributor

@1newsr 1newsr commented Aug 30, 2021

Fixed #20684.

In some cases, the result of settings item by ecs describe-clusters call was empty.
Therefore, I added the Include input parameter to explicitly get settings item.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #20684

Output from acceptance testing:

Sorry I couldn't run the acceptance test.
But I locally confirmed that #20684 was resolved after this fix.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/ecs Issues and PRs that pertain to the ecs service. labels Aug 30, 2021
@1newsr 1newsr changed the title Fix: Add setting field to ecs.DescribeClustersInput Fix: Add settings field to ecs.DescribeClustersInput Aug 30, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSEcsCluster_containerInsights\|TestAccAWSEcsCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_containerInsights\|TestAccAWSEcsCluster_basic -timeout 180m
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN   TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== CONT  TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_containerInsights
--- PASS: TestAccAWSEcsCluster_basic (26.64s)
--- PASS: TestAccAWSEcsCluster_containerInsights (64.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.216s

@ewbankkit
Copy link
Contributor

@1newsr Thanks for the contribution 🎉 👏.

@magnetikonline
Copy link
Contributor

Looking forward to this landing in the next release - we've seen this behaviour due to AWS API change overnight. Thanks @1newsr 👍

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS cluster always shows changes when containerInsights set to "disabled"
3 participants