-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add settings field to ecs.DescribeClustersInput #20720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSEcsCluster_containerInsights\|TestAccAWSEcsCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_containerInsights\|TestAccAWSEcsCluster_basic -timeout 180m
=== RUN TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== CONT TestAccAWSEcsCluster_basic
=== CONT TestAccAWSEcsCluster_containerInsights
--- PASS: TestAccAWSEcsCluster_basic (26.64s)
--- PASS: TestAccAWSEcsCluster_containerInsights (64.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 68.216s
@1newsr Thanks for the contribution 🎉 👏. |
Looking forward to this landing in the next release - we've seen this behaviour due to AWS API change overnight. Thanks @1newsr 👍 |
This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fixed #20684.
In some cases, the result of
settings
item by ecsdescribe-clusters
call was empty.Therefore, I added the
Include
input parameter to explicitly getsettings
item.Community Note
Relates OR Closes #20684
Output from acceptance testing:
Sorry I couldn't run the acceptance test.
But I locally confirmed that #20684 was resolved after this fix.