Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ec2_managed_prefix_list - allow updating max_entries #20797

Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20738

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixList_'
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (59.41s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (77.35s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (118.78s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (122.32s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (123.64s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (132.05s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (160.31s)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 4, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 4, 2021
@ewbankkit ewbankkit self-assigned this Sep 10, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixList_'
make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixList_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixList_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
--- PASS: TestAccAwsEc2ManagedPrefixList_disappears (26.34s)
--- PASS: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (32.28s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Name (43.77s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Description (46.81s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (47.29s)
--- PASS: TestAccAwsEc2ManagedPrefixList_basic (48.63s)
--- PASS: TestAccAwsEc2ManagedPrefixList_Tags (60.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.399s
GovCloud
% make testacc TESTARGS='-run=TestAccAwsEc2ManagedPrefixList_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ManagedPrefixList_ -timeout 180m
=== RUN   TestAccAwsEc2ManagedPrefixList_basic
=== PAUSE TestAccAwsEc2ManagedPrefixList_basic
=== RUN   TestAccAwsEc2ManagedPrefixList_disappears
=== PAUSE TestAccAwsEc2ManagedPrefixList_disappears
=== RUN   TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== PAUSE TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== RUN   TestAccAwsEc2ManagedPrefixList_Entry_Description
=== PAUSE TestAccAwsEc2ManagedPrefixList_Entry_Description
=== RUN   TestAccAwsEc2ManagedPrefixList_Name
=== PAUSE TestAccAwsEc2ManagedPrefixList_Name
=== RUN   TestAccAwsEc2ManagedPrefixList_Tags
=== PAUSE TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
=== CONT  TestAccAwsEc2ManagedPrefixList_Tags
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 29f04df5-3df2-4170-a1b0-e8e879d57d09
--- SKIP: TestAccAwsEc2ManagedPrefixList_Tags (1.69s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Cidr
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: f468ee1c-04a2-411a-9c22-f2d770b4b0c1
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Cidr (1.71s)
=== CONT  TestAccAwsEc2ManagedPrefixList_basic
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 0ab3c0ea-0fb4-4871-9f83-7a3ed106cb0c
--- SKIP: TestAccAwsEc2ManagedPrefixList_basic (1.72s)
=== CONT  TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 9933a5de-41b2-4d35-9275-4435f1aa9d3a
--- SKIP: TestAccAwsEc2ManagedPrefixList_AddressFamily_IPv6 (1.72s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Entry_Description
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 2a4d4797-a669-4e56-b08b-095a1b95a9db
--- SKIP: TestAccAwsEc2ManagedPrefixList_Entry_Description (1.72s)
=== CONT  TestAccAwsEc2ManagedPrefixList_Name
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: 5e958f50-7ad2-4581-839b-e453347682bb
--- SKIP: TestAccAwsEc2ManagedPrefixList_Name (1.73s)
=== CONT  TestAccAwsEc2ManagedPrefixList_disappears
    resource_aws_ec2_managed_prefix_list_test.go:366: skipping acceptance testing: InvalidAction: The action DescribeManagedPrefixLists is not valid for this web service.
        	status code: 400, request id: c87cf727-5a1e-4b51-a1f7-92fafae0e41b
--- SKIP: TestAccAwsEc2ManagedPrefixList_disappears (1.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.840s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 018fb5a into hashicorp:main Sep 10, 2021
@DrFaust92 DrFaust92 deleted the r/ec2_managed_prefix_list_max_entries branch September 10, 2021 16:15
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for resizing prefix lists
3 participants