Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kms_key: Updates policy and tag propagation time to 5 minutes #20914

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 15, 2021

Updates policy and tag propagation time to 5 minutes from 2 minutes.

Closes #20588

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKmsKey'

--- PASS: TestAccAWSKmsKey_disappears (24.53s)
--- PASS: TestAccAWSKmsKey_asymmetricKey (24.96s)
--- PASS: TestAccAWSKmsKey_basic (27.23s)
--- PASS: TestAccAWSKmsKey_policy (45.64s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (47.42s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (51.40s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (58.23s)
--- PASS: TestAccAWSKmsKey_tags (90.22s)
--- PASS: TestAccAWSKmsKey_policyBypass (152.64s)
--- PASS: TestAccAWSKmsKey_isEnabled (219.20s)

@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR. and removed service/kms Issues and PRs that pertain to the kms service. labels Sep 15, 2021
@gdavison gdavison marked this pull request as ready for review September 16, 2021 18:22
@ewbankkit
Copy link
Contributor

Add a bug-fix CHANGELOG entry?

@github-actions github-actions bot added the service/kms Issues and PRs that pertain to the kms service. label Sep 16, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSKmsKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsKey_ -timeout 180m
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_asymmetricKey
=== PAUSE TestAccAWSKmsKey_asymmetricKey
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_policyBypass
=== PAUSE TestAccAWSKmsKey_policyBypass
=== RUN   TestAccAWSKmsKey_policyBypassUpdate
=== PAUSE TestAccAWSKmsKey_policyBypassUpdate
=== RUN   TestAccAWSKmsKey_Policy_IamRole
=== PAUSE TestAccAWSKmsKey_Policy_IamRole
=== RUN   TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== PAUSE TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_basic
=== CONT  TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_isEnabled
=== CONT  TestAccAWSKmsKey_asymmetricKey
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_Policy_IamRole
=== CONT  TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== CONT  TestAccAWSKmsKey_policyBypassUpdate
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsKey_policyBypass
--- PASS: TestAccAWSKmsKey_disappears (27.64s)
--- PASS: TestAccAWSKmsKey_asymmetricKey (32.24s)
--- PASS: TestAccAWSKmsKey_basic (36.99s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (55.02s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (55.24s)
--- PASS: TestAccAWSKmsKey_policy (58.06s)
--- PASS: TestAccAWSKmsKey_tags (75.70s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (65.41s)
--- PASS: TestAccAWSKmsKey_policyBypass (161.89s)
--- PASS: TestAccAWSKmsKey_isEnabled (240.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	245.795s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSKmsKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsKey_ -timeout 180m
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_asymmetricKey
=== PAUSE TestAccAWSKmsKey_asymmetricKey
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_policyBypass
=== PAUSE TestAccAWSKmsKey_policyBypass
=== RUN   TestAccAWSKmsKey_policyBypassUpdate
=== PAUSE TestAccAWSKmsKey_policyBypassUpdate
=== RUN   TestAccAWSKmsKey_Policy_IamRole
=== PAUSE TestAccAWSKmsKey_Policy_IamRole
=== RUN   TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== PAUSE TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_basic
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_isEnabled
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_asymmetricKey
=== CONT  TestAccAWSKmsKey_policyBypassUpdate
=== CONT  TestAccAWSKmsKey_policyBypass
=== CONT  TestAccAWSKmsKey_Policy_IamServiceLinkedRole
=== CONT  TestAccAWSKmsKey_Policy_IamRole
--- PASS: TestAccAWSKmsKey_disappears (28.20s)
--- PASS: TestAccAWSKmsKey_asymmetricKey (37.20s)
--- PASS: TestAccAWSKmsKey_basic (37.96s)
--- PASS: TestAccAWSKmsKey_Policy_IamRole (54.09s)
--- PASS: TestAccAWSKmsKey_policy (61.23s)
--- PASS: TestAccAWSKmsKey_Policy_IamServiceLinkedRole (66.01s)
--- PASS: TestAccAWSKmsKey_policyBypassUpdate (115.38s)
--- PASS: TestAccAWSKmsKey_policyBypass (167.71s)
--- PASS: TestAccAWSKmsKey_tags (261.51s)
--- PASS: TestAccAWSKmsKey_isEnabled (472.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	482.038s

@gdavison gdavison merged commit a97de1d into main Sep 16, 2021
@gdavison gdavison deleted the kms-timeout branch September 16, 2021 22:43
@github-actions github-actions bot added this to the v3.59.0 milestone Sep 16, 2021
github-actions bot pushed a commit that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS doesn't work with newest verision of provider
2 participants