-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kms decrypt with asymmetric keys #21054
Conversation
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
7916523
to
a9f2385
Compare
Hey team. Is there anything I can do to help progress this PR? It has been sitting for 4 months now. |
I have created a PR #28604 to cater to this change. |
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds support for algorithm and key_id inputs to the
aws_kms_secrets
data source. This is to support KMS decryption with asymmetric keys where both of these fields are required.I'm struggling on working out what to do for the acceptance test(s). The test could generate an asymmetric KMS key, then encrypt some plain text from the public key (maybe with the TLS provider, go code, or a mock provider?). I'm not sure how that would fit into the current acceptance test framework. If anyone has any examples or pointers I'd appreciate that.
Community Note
Output from acceptance testing: