Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource and data source aws_cloudcontrolapi_resource #21110

Merged
merged 33 commits into from
Sep 30, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 30, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds a new resource and data source to interact generically with the AWS Cloud Control API.

Output from acceptance testing:

Commercial

% make testacc TESTARGS='-run=TestAccAwsCloudControlApiResource_\|TestAccAwsCloudControlApiResourceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudControlApiResource_\|TestAccAwsCloudControlApiResourceDataSource_ -timeout 180m
=== RUN   TestAccAwsCloudControlApiResourceDataSource_basic
=== PAUSE TestAccAwsCloudControlApiResourceDataSource_basic
=== RUN   TestAccAwsCloudControlApiResource_basic
=== PAUSE TestAccAwsCloudControlApiResource_basic
=== RUN   TestAccAwsCloudControlApiResource_disappears
=== PAUSE TestAccAwsCloudControlApiResource_disappears
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_BooleanValueAdded
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_BooleanValueAdded
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_BooleanValueRemoved
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_BooleanValueRemoved
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_BooleanValueUpdate
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_BooleanValueUpdate
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_CreateOnly
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_CreateOnly
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_IntegerValueAdded
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_IntegerValueAdded
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_IntegerValueRemoved
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_IntegerValueRemoved
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_IntegerValueUpdate
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_IntegerValueUpdate
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyName
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyName
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_ObjectValueAdded
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_ObjectValueAdded
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_ObjectValueRemoved
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_ObjectValueRemoved
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_ObjectValueUpdate
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_ObjectValueUpdate
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_StringValueAdded
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_StringValueAdded
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_StringValueRemoved
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_StringValueRemoved
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_StringValueUpdate
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_StringValueUpdate
=== RUN   TestAccAwsCloudControlApiResource_ResourceSchema
=== PAUSE TestAccAwsCloudControlApiResource_ResourceSchema
=== CONT  TestAccAwsCloudControlApiResourceDataSource_basic
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyName
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_BooleanValueUpdate
=== CONT  TestAccAwsCloudControlApiResource_disappears
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_ObjectValueAdded
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_ObjectValueRemoved
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_IntegerValueRemoved
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_IntegerValueAdded
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_BooleanValueAdded
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_ObjectValueUpdate
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_BooleanValueRemoved
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_StringValueAdded
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_StringValueUpdate
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_CreateOnly
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_IntegerValueUpdate
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_StringValueRemoved
=== CONT  TestAccAwsCloudControlApiResource_basic
=== CONT  TestAccAwsCloudControlApiResource_ResourceSchema
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyName (11.79s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue (32.26s)
--- PASS: TestAccAwsCloudControlApiResource_disappears (42.30s)
--- PASS: TestAccAwsCloudControlApiResource_basic (45.12s)
--- PASS: TestAccAwsCloudControlApiResource_ResourceSchema (47.48s)
--- PASS: TestAccAwsCloudControlApiResourceDataSource_basic (48.10s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_IntegerValueUpdate (55.79s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_CreateOnly (60.36s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_IntegerValueAdded (64.16s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_ObjectValueRemoved (68.76s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_BooleanValueAdded (70.56s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_IntegerValueRemoved (72.46s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_BooleanValueUpdate (73.22s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_BooleanValueRemoved (73.48s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_StringValueAdded (74.96s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_StringValueUpdate (79.26s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_ObjectValueAdded (80.16s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_ObjectValueUpdate (84.78s)
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_StringValueRemoved (94.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	97.871s
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSet_\|TestAccAwsCloudformationType_\|TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSet_\|TestAccAwsCloudformationType_\|TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN   TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN   TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN   TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN   TestAccAWSCloudFormationStackSet_basic
=== PAUSE TestAccAWSCloudFormationStackSet_basic
=== RUN   TestAccAWSCloudFormationStackSet_disappears
=== PAUSE TestAccAWSCloudFormationStackSet_disappears
=== RUN   TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== PAUSE TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== RUN   TestAccAWSCloudFormationStackSet_Description
=== PAUSE TestAccAWSCloudFormationStackSet_Description
=== RUN   TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== PAUSE TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== RUN   TestAccAWSCloudFormationStackSet_Name
=== PAUSE TestAccAWSCloudFormationStackSet_Name
=== RUN   TestAccAWSCloudFormationStackSet_Parameters
=== PAUSE TestAccAWSCloudFormationStackSet_Parameters
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_Default
    provider_test.go:58: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_NoEcho
    provider_test.go:58: this resource does not currently ignore CloudFormation template parameters with the NoEcho property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged
    provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Tags
=== PAUSE TestAccAWSCloudFormationStackSet_Tags
=== RUN   TestAccAWSCloudFormationStackSet_TemplateBody
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateBody
=== RUN   TestAccAWSCloudFormationStackSet_TemplateUrl
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateUrl
=== RUN   TestAccAwsCloudformationType_basic
=== PAUSE TestAccAwsCloudformationType_basic
=== RUN   TestAccAwsCloudformationType_disappears
=== PAUSE TestAccAwsCloudformationType_disappears
=== RUN   TestAccAwsCloudformationType_ExecutionRoleArn
=== PAUSE TestAccAwsCloudformationType_ExecutionRoleArn
=== RUN   TestAccAwsCloudformationType_LoggingConfig
=== PAUSE TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAWSCloudFormationStackSetInstance_basic
=== CONT  TestAccAWSCloudFormationStackSet_Name
=== CONT  TestAccAWSCloudFormationStackSet_basic
=== CONT  TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT  TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT  TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== CONT  TestAccAwsCloudformationType_basic
=== CONT  TestAccAWSCloudFormationStackSet_TemplateBody
=== CONT  TestAccAWSCloudFormationStackSet_Tags
=== CONT  TestAccAWSCloudFormationStackSet_Parameters
=== CONT  TestAccAWSCloudFormationStackSet_TemplateUrl
=== CONT  TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== CONT  TestAccAwsCloudformationType_ExecutionRoleArn
=== CONT  TestAccAwsCloudformationType_disappears
=== CONT  TestAccAWSCloudFormationStackSet_disappears
=== CONT  TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== CONT  TestAccAWSCloudFormationStackSet_Description
--- PASS: TestAccAWSCloudFormationStackSet_basic (32.10s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (36.72s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (52.00s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (54.66s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (57.17s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (57.36s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (59.77s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (79.57s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (95.24s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (96.32s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (118.29s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (122.93s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (130.34s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (163.86s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (169.77s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (174.83s)
--- PASS: TestAccAwsCloudformationType_basic (175.07s)
--- PASS: TestAccAwsCloudformationType_disappears (176.02s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (217.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	222.191s
% make testacc TESTARGS='-run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_'                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_ -timeout 180m
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic (118.84s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears (136.27s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired (153.88s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update (200.87s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned (232.25s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags (236.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	239.233s

GovCloud

% make testacc TESTARGS='-run=TestAccAwsCloudControlApiResourceDataSource_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudControlApiResourceDataSource_ -timeout 180m
=== RUN   TestAccAwsCloudControlApiResourceDataSource_basic
=== PAUSE TestAccAwsCloudControlApiResourceDataSource_basic
=== CONT  TestAccAwsCloudControlApiResourceDataSource_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Cloud Control API Resource (AWS::Logs::LogGroup): UnsupportedActionException: Resource type AWS::Logs::LogGroup does not support CREATE action
        
          with aws_cloudcontrolapi_resource.test,
          on terraform_plugin_test.tf line 2, in resource "aws_cloudcontrolapi_resource" "test":
           2: resource "aws_cloudcontrolapi_resource" "test" {
        
--- SKIP: TestAccAwsCloudControlApiResourceDataSource_basic (8.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.843s
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSet_\|TestAccAwsCloudformationType_\|TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSet_\|TestAccAwsCloudformationType_\|TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN   TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN   TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN   TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN   TestAccAWSCloudFormationStackSet_basic
=== PAUSE TestAccAWSCloudFormationStackSet_basic
=== RUN   TestAccAWSCloudFormationStackSet_disappears
=== PAUSE TestAccAWSCloudFormationStackSet_disappears
=== RUN   TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== PAUSE TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== RUN   TestAccAWSCloudFormationStackSet_Description
=== PAUSE TestAccAWSCloudFormationStackSet_Description
=== RUN   TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== PAUSE TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== RUN   TestAccAWSCloudFormationStackSet_Name
=== PAUSE TestAccAWSCloudFormationStackSet_Name
=== RUN   TestAccAWSCloudFormationStackSet_Parameters
=== PAUSE TestAccAWSCloudFormationStackSet_Parameters
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_Default
    provider_test.go:58: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_NoEcho
    provider_test.go:58: this resource does not currently ignore CloudFormation template parameters with the NoEcho property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged
    provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Tags
=== PAUSE TestAccAWSCloudFormationStackSet_Tags
=== RUN   TestAccAWSCloudFormationStackSet_TemplateBody
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateBody
=== RUN   TestAccAWSCloudFormationStackSet_TemplateUrl
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateUrl
=== RUN   TestAccAwsCloudformationType_basic
=== PAUSE TestAccAwsCloudformationType_basic
=== RUN   TestAccAwsCloudformationType_disappears
=== PAUSE TestAccAwsCloudformationType_disappears
=== RUN   TestAccAwsCloudformationType_ExecutionRoleArn
=== PAUSE TestAccAwsCloudformationType_ExecutionRoleArn
=== RUN   TestAccAwsCloudformationType_LoggingConfig
=== PAUSE TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAWSCloudFormationStackSetInstance_basic
=== CONT  TestAccAWSCloudFormationStackSet_Name
=== CONT  TestAccAwsCloudformationType_ExecutionRoleArn
=== CONT  TestAccAwsCloudformationType_basic
=== CONT  TestAccAWSCloudFormationStackSet_basic
=== CONT  TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== CONT  TestAccAWSCloudFormationStackSet_Description
=== CONT  TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== CONT  TestAccAWSCloudFormationStackSet_disappears
=== CONT  TestAccAwsCloudformationType_LoggingConfig
=== CONT  TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT  TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT  TestAccAWSCloudFormationStackSet_TemplateUrl
=== CONT  TestAccAWSCloudFormationStackSet_TemplateBody
=== CONT  TestAccAWSCloudFormationStackSet_Tags
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== CONT  TestAccAwsCloudformationType_disappears
=== CONT  TestAccAWSCloudFormationStackSet_Parameters
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears
--- PASS: TestAccAWSCloudFormationStackSet_disappears (40.77s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (43.97s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (61.54s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (66.14s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (67.58s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (69.56s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (69.76s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (91.61s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (112.97s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (113.34s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (127.12s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (129.21s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (132.28s)
--- PASS: TestAccAwsCloudformationType_basic (157.66s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (161.38s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (161.55s)
--- PASS: TestAccAwsCloudformationType_disappears (166.43s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (194.05s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (240.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	244.956s
% make testacc TESTARGS='-run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_'       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_ -timeout 180m
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears (116.79s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired (119.28s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic (127.68s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update (194.47s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags (230.81s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned (243.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	246.923s

ewbankkit and others added 30 commits September 30, 2021 14:46
…hicorp/aws-cloudformation-resource-schema-sdk-go go mod tidy'.
Output from acceptance testing:

```
--- PASS: TestAccCloudformationResourceDataSource_basic (39.25s)
```
Output from acceptance testing:

```
--- PASS: TestAccAwsCloudformationResource_DesiredState_InvalidPropertyName (7.59s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_InvalidPropertyValue (7.74s)
--- PASS: TestAccAwsCloudformationResource_ResourceSchema (31.22s)
--- PASS: TestAccAwsCloudformationResource_basic (33.56s)
--- PASS: TestAccAwsCloudformationResource_disappears (36.86s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_IntegerValueAdded (50.77s)
--- PASS: TestAccAwsCloudformationResourceDataSource_basic (51.70s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_IntegerValueUpdate (56.02s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_IntegerValueRemoved (62.38s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_BooleanValueAdded (62.46s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_StringValueUpdate (65.68s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_BooleanValueUpdate (67.40s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_StringValueAdded (70.97s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_BooleanValueRemoved (72.22s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_ObjectValueAdded (72.29s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_ObjectValueRemoved (79.59s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_CreateOnly (79.87s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_StringValueRemoved (81.09s)
--- PASS: TestAccAwsCloudformationResource_DesiredState_ObjectValueUpdate (82.10s)
```
…orp/aws-sdk-go-private@499245543dfdf07814cdbcef7e9cabcad81b4a13'.
…a-sdk-go go get github.com/hashicorp/aws-cloudformation-resource-schema-sdk-go@v0.9.0'.
…er.ChangeSetByStackIDAndChangeSetName'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsServerlessApplicationRepositoryCloudFormationStack_ -timeout 180m
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== RUN   TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== PAUSE TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned
=== CONT  TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_disappears (105.46s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_paired (109.86s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_basic (119.13s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_update (228.79s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_Tags (260.04s)
--- PASS: TestAccAwsServerlessApplicationRepositoryCloudFormationStack_versioned (264.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	270.926s
…stance.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_\|TestAccAWSCloudFormationStackSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSetInstance_\|TestAccAWSCloudFormationStackSet_ -timeout 180m
=== RUN   TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN   TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN   TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN   TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN   TestAccAWSCloudFormationStackSet_basic
=== PAUSE TestAccAWSCloudFormationStackSet_basic
=== RUN   TestAccAWSCloudFormationStackSet_disappears
=== PAUSE TestAccAWSCloudFormationStackSet_disappears
=== RUN   TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== PAUSE TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== RUN   TestAccAWSCloudFormationStackSet_Description
=== PAUSE TestAccAWSCloudFormationStackSet_Description
=== RUN   TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== PAUSE TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== RUN   TestAccAWSCloudFormationStackSet_Name
=== PAUSE TestAccAWSCloudFormationStackSet_Name
=== RUN   TestAccAWSCloudFormationStackSet_Parameters
=== PAUSE TestAccAWSCloudFormationStackSet_Parameters
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_Default
    provider_test.go:58: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_NoEcho
    provider_test.go:58: this resource does not currently ignore CloudFormation template parameters with the NoEcho property
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged
    provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSet_PermissionModel_ServiceManaged (0.00s)
=== RUN   TestAccAWSCloudFormationStackSet_Tags
=== PAUSE TestAccAWSCloudFormationStackSet_Tags
=== RUN   TestAccAWSCloudFormationStackSet_TemplateBody
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateBody
=== RUN   TestAccAWSCloudFormationStackSet_TemplateUrl
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateUrl
=== CONT  TestAccAWSCloudFormationStackSetInstance_basic
=== CONT  TestAccAWSCloudFormationStackSet_Description
=== CONT  TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT  TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== CONT  TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT  TestAccAWSCloudFormationStackSet_basic
=== CONT  TestAccAWSCloudFormationStackSet_Tags
=== CONT  TestAccAWSCloudFormationStackSet_TemplateUrl
=== CONT  TestAccAWSCloudFormationStackSet_disappears
=== CONT  TestAccAWSCloudFormationStackSet_Name
=== CONT  TestAccAWSCloudFormationStackSet_TemplateBody
=== CONT  TestAccAWSCloudFormationStackSet_Parameters
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT  TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== CONT  TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
--- PASS: TestAccAWSCloudFormationStackSet_disappears (34.78s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (42.22s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (59.06s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (59.90s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (60.03s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (69.16s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (85.65s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (90.90s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (96.95s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (115.43s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (131.74s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (132.29s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (134.32s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (183.85s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (224.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	228.064s
…a-sdk-go go get github.com/hashicorp/aws-cloudformation-resource-schema-sdk-go@v0.10.0'.
…e empty string."

This reverts commit 72693b9d27c28fdded744b6e8d422a920443857c.
…ype schema."

This reverts commit 4236af145b664d43b75d8a8c7c0e7cad2fbe82cf.
… state.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAwsCloudControlApiResource_ResourceSchema'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudControlApiResource_ResourceSchema -timeout 180m
=== RUN   TestAccAwsCloudControlApiResource_ResourceSchema
=== PAUSE TestAccAwsCloudControlApiResource_ResourceSchema
=== CONT  TestAccAwsCloudControlApiResource_ResourceSchema
--- PASS: TestAccAwsCloudControlApiResource_ResourceSchema (22.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.978s
…loudControlApiResource_DesiredState_InvalidPropertyValue' as validation of properties is now done server-side.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue -timeout 180m
=== RUN   TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
=== PAUSE TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
=== CONT  TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue
--- PASS: TestAccAwsCloudControlApiResource_DesiredState_InvalidPropertyValue (7.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.813s
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 30, 2021
@ewbankkit ewbankkit added this to the v3.61.0 milestone Sep 30, 2021
@ewbankkit ewbankkit changed the title [WIP] New resource and data source aws_cloudcontrolapi_resource New resource and data source aws_cloudcontrolapi_resource Sep 30, 2021
@ewbankkit ewbankkit merged commit 46a8d79 into main Sep 30, 2021
@ewbankkit ewbankkit deleted the f-aws_cloudformation_resource branch September 30, 2021 21:40
github-actions bot pushed a commit that referenced this pull request Sep 30, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants