Fixes a bug and added test sweeper for Appstream Fleets and Stacks #21125

coderGo93 · 2021-10-01T20:46:18Z

Added more error validation for appstream Fleet and Stack to avoid a possibly bug when if fails in other resource even in the appstream resource doesn't show error(e.g., error in subnet configuration).
Added sweepers for Test Appstream Fleet and Stack

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20994
Closes #20993

Output from acceptance testing:

AppStream Fleet

$  make testacc TESTARGS='-run=TestAccAwsAppStreamFleet'                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamFleet -timeout 180m
=== RUN   TestAccAwsAppStreamFleet_basic
=== PAUSE TestAccAwsAppStreamFleet_basic
=== RUN   TestAccAwsAppStreamFleet_disappears
=== PAUSE TestAccAwsAppStreamFleet_disappears
=== RUN   TestAccAwsAppStreamFleet_completeWithStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithStop
=== RUN   TestAccAwsAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithoutStop
=== RUN   TestAccAwsAppStreamFleet_withTags
=== PAUSE TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_basic
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
=== CONT  TestAccAwsAppStreamFleet_disappears
=== CONT  TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
--- PASS: TestAccAwsAppStreamFleet_basic (1186.65s)
--- PASS: TestAccAwsAppStreamFleet_withTags (1220.17s)
--- PASS: TestAccAwsAppStreamFleet_disappears (1221.69s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (1284.49s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (2376.10s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2376.167s


...

AppStream Stack

$ make testacc TESTARGS='-run=TestAccAwsAppStreamStack'                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamStack -timeout 180m
=== RUN   TestAccAwsAppStreamStack_basic
=== PAUSE TestAccAwsAppStreamStack_basic
=== RUN   TestAccAwsAppStreamStack_disappears
=== PAUSE TestAccAwsAppStreamStack_disappears
=== RUN   TestAccAwsAppStreamStack_complete
=== PAUSE TestAccAwsAppStreamStack_complete
=== RUN   TestAccAwsAppStreamStack_withTags
=== PAUSE TestAccAwsAppStreamStack_withTags
=== CONT  TestAccAwsAppStreamStack_basic
=== CONT  TestAccAwsAppStreamStack_withTags
=== CONT  TestAccAwsAppStreamStack_complete
=== CONT  TestAccAwsAppStreamStack_disappears
--- PASS: TestAccAwsAppStreamStack_disappears (20.40s)
--- PASS: TestAccAwsAppStreamStack_basic (25.25s)
--- PASS: TestAccAwsAppStreamStack_withTags (52.00s)
--- PASS: TestAccAwsAppStreamStack_complete (64.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       64.249s


...

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAwsAppStreamFleet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamFleet_ -timeout 180m
=== RUN   TestAccAwsAppStreamFleet_basic
=== PAUSE TestAccAwsAppStreamFleet_basic
=== RUN   TestAccAwsAppStreamFleet_disappears
=== PAUSE TestAccAwsAppStreamFleet_disappears
=== RUN   TestAccAwsAppStreamFleet_completeWithStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithStop
=== RUN   TestAccAwsAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithoutStop
=== RUN   TestAccAwsAppStreamFleet_withTags
=== PAUSE TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_basic
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
=== CONT  TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
=== CONT  TestAccAwsAppStreamFleet_disappears
--- PASS: TestAccAwsAppStreamFleet_disappears (926.54s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (955.72s)
--- PASS: TestAccAwsAppStreamFleet_basic (963.26s)
--- PASS: TestAccAwsAppStreamFleet_withTags (1008.73s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (1303.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1307.404s

GovCloud

% make testacc TESTARGS='-run=TestAccAwsAppStreamFleet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamFleet_ -timeout 180m
=== RUN   TestAccAwsAppStreamFleet_basic
=== PAUSE TestAccAwsAppStreamFleet_basic
=== RUN   TestAccAwsAppStreamFleet_disappears
=== PAUSE TestAccAwsAppStreamFleet_disappears
=== RUN   TestAccAwsAppStreamFleet_completeWithStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithStop
=== RUN   TestAccAwsAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithoutStop
=== RUN   TestAccAwsAppStreamFleet_withTags
=== PAUSE TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_basic
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
=== CONT  TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
=== CONT  TestAccAwsAppStreamFleet_disappears
=== CONT  TestAccAwsAppStreamFleet_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Appstream Fleet (): ResourceNotFoundException: The image Amazon-AppStream2-Sample-Image-02-04-2019 for account 357342307427  does not exist.
        
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 2, in resource "aws_appstream_fleet" "test":
           2: resource "aws_appstream_fleet" "test" {
        
--- SKIP: TestAccAwsAppStreamFleet_basic (908.76s)
=== CONT  TestAccAwsAppStreamFleet_disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Appstream Fleet (): ResourceNotFoundException: The image Amazon-AppStream2-Sample-Image-02-04-2019 for account 357342307427  does not exist.
        
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 2, in resource "aws_appstream_fleet" "test":
           2: resource "aws_appstream_fleet" "test" {
        
--- SKIP: TestAccAwsAppStreamFleet_disappears (908.98s)
=== CONT  TestAccAwsAppStreamFleet_withTags
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Appstream Fleet (): ResourceNotFoundException: The image Amazon-AppStream2-Sample-Image-02-04-2019 for account 357342307427  does not exist.
        
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 22, in resource "aws_appstream_fleet" "test":
          22: resource "aws_appstream_fleet" "test" {
        
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Appstream Fleet (): ResourceNotFoundException: The image Amazon-AppStream2-Sample-Image-02-04-2019 for account 357342307427  does not exist.
        
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 22, in resource "aws_appstream_fleet" "test":
          22: resource "aws_appstream_fleet" "test" {
        
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating Appstream Fleet (): ResourceNotFoundException: The image Amazon-AppStream2-Sample-Image-02-04-2019 for account 357342307427  does not exist.
        
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 22, in resource "aws_appstream_fleet" "test":
          22: resource "aws_appstream_fleet" "test" {
        
--- SKIP: TestAccAwsAppStreamFleet_completeWithStop (920.31s)
--- SKIP: TestAccAwsAppStreamFleet_completeWithoutStop (920.32s)
--- SKIP: TestAccAwsAppStreamFleet_withTags (920.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	924.802s

ewbankkit · 2021-10-05T14:24:47Z

@coderGo93 Thanks for the contribution 🎉 👏.

github-actions · 2022-06-18T02:34:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Edgar Lopez added 3 commits September 29, 2021 18:40

added validation and lister

71125b6

added validation for waiter fleet and stack

f820b5c

refactor sweeper test

29cd848

added changelog

be71013

breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2021

No need to call out sweeper addition in CHANGELOG.

2d598be

ewbankkit approved these changes Oct 5, 2021

View reviewed changes

ewbankkit merged commit b20c3b5 into hashicorp:main Oct 5, 2021

ewbankkit mentioned this pull request Jan 6, 2022

sweeper/AppStream: Delete the correct resource types #22442

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes a bug and added test sweeper for Appstream Fleets and Stacks #21125

Fixes a bug and added test sweeper for Appstream Fleets and Stacks #21125

coderGo93 commented Oct 1, 2021 •

edited by ewbankkit

Loading

ewbankkit left a comment

ewbankkit commented Oct 5, 2021

github-actions bot commented Jun 18, 2022

Fixes a bug and added test sweeper for Appstream Fleets and Stacks #21125

Fixes a bug and added test sweeper for Appstream Fleets and Stacks #21125

Conversation

coderGo93 commented Oct 1, 2021 • edited by ewbankkit Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Oct 5, 2021

github-actions bot commented Jun 18, 2022

coderGo93 commented Oct 1, 2021 •

edited by ewbankkit

Loading