Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource_aws_chime_voice_connector_termination_credentials #21162

Merged
merged 8 commits into from
Oct 13, 2021
Merged

Add new resource_aws_chime_voice_connector_termination_credentials #21162

merged 8 commits into from
Oct 13, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorTerminationCredentials_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorTerminationCredentials_basic
=== PAUSE TestAccAWSChimeVoiceConnectorTerminationCredentials_basic
=== RUN   TestAccAWSChimeVoiceConnectorTerminationCredentials_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorTerminationCredentials_disappears
=== RUN   TestAccAWSChimeVoiceConnectorTerminationCredentials_update
=== PAUSE TestAccAWSChimeVoiceConnectorTerminationCredentials_update
=== CONT  TestAccAWSChimeVoiceConnectorTerminationCredentials_basic
=== CONT  TestAccAWSChimeVoiceConnectorTerminationCredentials_update
=== CONT  TestAccAWSChimeVoiceConnectorTerminationCredentials_disappears
--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_basic (28.59s)
--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_disappears (47.64s)
--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_update (70.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       72.892s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2021
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 5, 2021
@YakDriver YakDriver self-assigned this Oct 13, 2021
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 13, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_basic (12.72s)
--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_update (19.13s)
--- PASS: TestAccAWSChimeVoiceConnectorTerminationCredentials_disappears (24.40s)

@YakDriver YakDriver added this to the v3.63.0 milestone Oct 13, 2021
@YakDriver YakDriver merged commit 8913fd8 into hashicorp:main Oct 13, 2021
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants