fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

awsaxeman · 2021-10-12T23:36:18Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21246.
Relates #20951.
Relates #21406.
Closes #20285.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSRouteTable_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTable_basic -timeout 180m
=== RUN   TestAccAWSRouteTable_basic
=== PAUSE TestAccAWSRouteTable_basic
=== CONT  TestAccAWSRouteTable_basic
--- PASS: TestAccAWSRouteTable_basic (26.17s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.686s
...

…sx_ontap_routes

github-actions

Welcome @awsaxeman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

…om/awsaxeman/terraform-provider-aws into f-route_table_for_fsx_ontap_routes

awsaxeman · 2021-10-17T03:36:32Z

Output from new acceptance tests:

TF_ACC=1 go test ./internal/service/ec2 -v -count 1 -parallel 1 -run='TestAccEC2RouteTable_fsxRouteAndTag' -timeout=180m
=== RUN TestAccEC2RouteTable_fsxRouteAndTag
=== PAUSE TestAccEC2RouteTable_fsxRouteAndTag
=== CONT TestAccEC2RouteTable_fsxRouteAndTag
--- PASS: TestAccEC2RouteTable_fsxRouteAndTag (2461.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 2465.175s

TF_ACC=1 go test ./internal/service/ec2 -v -count 1 -parallel 1 -run='TestAccEC2RouteTableDataSource_fsxRouteAndTag' -timeout=180m
=== RUN TestAccEC2RouteTableDataSource_fsxRouteAndTag
=== PAUSE TestAccEC2RouteTableDataSource_fsxRouteAndTag
=== CONT TestAccEC2RouteTableDataSource_fsxRouteAndTag
--- PASS: TestAccEC2RouteTableDataSource_fsxRouteAndTag (2294.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 2298.306s

zhelding · 2021-10-19T16:33:01Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

ewbankkit · 2021-10-19T18:09:03Z

@awsaxeman Are cross-account ENIs in route table always associated with routes managed by other AWS services?
An alternative could be to filter out any destination in the 198.18. or 198.19. CIDR blocks if we can guarantee that those address ranges always signal a route managed by another AWS service.

awsaxeman · 2021-10-19T20:35:27Z

@ewbankit correct cross-account ENIs are only able to be created by AWS services. Customers and Partners are able to use AWS PrivateLink but that is not typically in routing tables. That is fairly unique to FSx for ONTAP. We can't do it by IP addresses 198.18. or 198.19 because that is not guaranteed as customers can set a custom IP address range. The other way we could do it, which would be very specific to FSx, would be to query all FSx file systems and get each ENI to exclude.

ewbankkit · 2021-10-19T20:52:59Z

@awsaxeman Thanks. We don't want to make FSx calls in an EC2 resource so can stick with the cross-account ENI.
For the tags I think we are going to prefer that customers add AmazonFSx to the provider-level ignore_tags rather than have that logic in this resource. It would be nice if the existing logic to ignore tag keys starting with aws: could be used here...

awsaxeman · 2021-10-19T21:20:05Z

@ewbankkit I already raised the tag naming to our FSx service team to see if it was possible to use the aws: tag going forward but that is still TBD. Two thoughts here, 1/would it makes sense for us to fold this logic into the ignoreAWS() function or create an ignoreFSX() function in key_value_tags.go? There seems to be some other service specific ignores such as ignoreRds() already there. 2/I would be concerned with customers having to add that to the ignore_tags for the provider because they would have to be aware of this ahead of time, it could be different teams working on provider config, fsx, and route tables, and it could be prone to errors.

d/aws_network_interface: Add 'arn' attribute. Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2NetworkInterface_ENI_basic\|TestAccEC2NetworkInterfaceDataSource_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ENI_basic\|TestAccEC2NetworkInterfaceDataSource_basic -timeout 180m === RUN TestAccEC2NetworkInterfaceDataSource_basic === PAUSE TestAccEC2NetworkInterfaceDataSource_basic === RUN TestAccEC2NetworkInterface_ENI_basic === PAUSE TestAccEC2NetworkInterface_ENI_basic === CONT TestAccEC2NetworkInterfaceDataSource_basic === CONT TestAccEC2NetworkInterface_ENI_basic --- PASS: TestAccEC2NetworkInterfaceDataSource_basic (62.12s) --- PASS: TestAccEC2NetworkInterface_ENI_basic (73.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 76.478s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterface_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ -timeout 180m === RUN TestAccEC2NetworkInterface_ENI_basic === PAUSE TestAccEC2NetworkInterface_ENI_basic === RUN TestAccEC2NetworkInterface_ENI_ipv6 === PAUSE TestAccEC2NetworkInterface_ENI_ipv6 === RUN TestAccEC2NetworkInterface_ENI_tags === PAUSE TestAccEC2NetworkInterface_ENI_tags === RUN TestAccEC2NetworkInterface_ENI_ipv6Count === PAUSE TestAccEC2NetworkInterface_ENI_ipv6Count === RUN TestAccEC2NetworkInterface_ENI_disappears === PAUSE TestAccEC2NetworkInterface_ENI_disappears === RUN TestAccEC2NetworkInterface_ENI_description === PAUSE TestAccEC2NetworkInterface_ENI_description === RUN TestAccEC2NetworkInterface_ENI_attachment === PAUSE TestAccEC2NetworkInterface_ENI_attachment === RUN TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === PAUSE TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === RUN TestAccEC2NetworkInterface_ENI_sourceDestCheck === PAUSE TestAccEC2NetworkInterface_ENI_sourceDestCheck === RUN TestAccEC2NetworkInterface_ENI_privateIPsCount === PAUSE TestAccEC2NetworkInterface_ENI_privateIPsCount === RUN TestAccEC2NetworkInterface_ENIInterfaceType_efa === PAUSE TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_basic === CONT TestAccEC2NetworkInterface_ENI_attachment === CONT TestAccEC2NetworkInterface_ENI_sourceDestCheck === CONT TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_disappears === CONT TestAccEC2NetworkInterface_ENI_privateIPsCount === CONT TestAccEC2NetworkInterface_ENI_ipv6Count === CONT TestAccEC2NetworkInterface_ENI_description === CONT TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === CONT TestAccEC2NetworkInterface_ENI_tags === CONT TestAccEC2NetworkInterface_ENI_ipv6 --- PASS: TestAccEC2NetworkInterface_ENI_disappears (47.72s) --- PASS: TestAccEC2NetworkInterface_ENI_basic (58.38s) --- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (60.51s) --- PASS: TestAccEC2NetworkInterface_ENI_description (81.99s) --- PASS: TestAccEC2NetworkInterface_ENI_tags (101.62s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6 (105.45s) --- PASS: TestAccEC2NetworkInterface_ENI_sourceDestCheck (107.26s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6Count (125.96s) --- PASS: TestAccEC2NetworkInterface_ENI_privateIPsCount (132.52s) --- PASS: TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment (145.22s) --- PASS: TestAccEC2NetworkInterface_ENI_attachment (162.14s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 165.460s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterface_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ -timeout 180m === RUN TestAccEC2NetworkInterface_ENI_basic === PAUSE TestAccEC2NetworkInterface_ENI_basic === RUN TestAccEC2NetworkInterface_ENI_ipv6 === PAUSE TestAccEC2NetworkInterface_ENI_ipv6 === RUN TestAccEC2NetworkInterface_ENI_tags === PAUSE TestAccEC2NetworkInterface_ENI_tags === RUN TestAccEC2NetworkInterface_ENI_ipv6Count === PAUSE TestAccEC2NetworkInterface_ENI_ipv6Count === RUN TestAccEC2NetworkInterface_ENI_disappears === PAUSE TestAccEC2NetworkInterface_ENI_disappears === RUN TestAccEC2NetworkInterface_ENI_description === PAUSE TestAccEC2NetworkInterface_ENI_description === RUN TestAccEC2NetworkInterface_ENI_attachment === PAUSE TestAccEC2NetworkInterface_ENI_attachment === RUN TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === PAUSE TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === RUN TestAccEC2NetworkInterface_ENI_sourceDestCheck === PAUSE TestAccEC2NetworkInterface_ENI_sourceDestCheck === RUN TestAccEC2NetworkInterface_ENI_privateIPsCount === PAUSE TestAccEC2NetworkInterface_ENI_privateIPsCount === RUN TestAccEC2NetworkInterface_ENIInterfaceType_efa === PAUSE TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_basic === CONT TestAccEC2NetworkInterface_ENI_attachment === CONT TestAccEC2NetworkInterface_ENI_privateIPsCount === CONT TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === CONT TestAccEC2NetworkInterface_ENI_ipv6Count === CONT TestAccEC2NetworkInterface_ENI_description === CONT TestAccEC2NetworkInterface_ENI_sourceDestCheck === CONT TestAccEC2NetworkInterface_ENI_disappears === CONT TestAccEC2NetworkInterface_ENI_tags === CONT TestAccEC2NetworkInterface_ENI_ipv6 === CONT TestAccEC2NetworkInterface_ENIInterfaceType_efa --- PASS: TestAccEC2NetworkInterface_ENI_disappears (50.79s) --- PASS: TestAccEC2NetworkInterface_ENI_basic (58.37s) --- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (68.21s) --- PASS: TestAccEC2NetworkInterface_ENI_description (92.56s) --- PASS: TestAccEC2NetworkInterface_ENI_sourceDestCheck (111.39s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6 (113.78s) --- PASS: TestAccEC2NetworkInterface_ENI_tags (115.93s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6Count (137.20s) --- PASS: TestAccEC2NetworkInterface_ENI_privateIPsCount (142.19s) --- PASS: TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment (311.93s) --- PASS: TestAccEC2NetworkInterface_ENI_attachment (344.06s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 349.531s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceAttachment_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceAttachment_ -timeout 180m === RUN TestAccEC2NetworkInterfaceAttachment_basic === PAUSE TestAccEC2NetworkInterfaceAttachment_basic === CONT TestAccEC2NetworkInterfaceAttachment_basic --- PASS: TestAccEC2NetworkInterfaceAttachment_basic (325.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 329.262s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceSgAttachment_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceSgAttachment_ -timeout 180m === RUN TestAccEC2NetworkInterfaceSgAttachment_SG_basic === PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_basic === RUN TestAccEC2NetworkInterfaceSgAttachment_SG_disappears === PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_disappears === RUN TestAccEC2NetworkInterfaceSgAttachment_SG_instance === PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_instance === RUN TestAccEC2NetworkInterfaceSgAttachment_SG_multiple === PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_multiple === CONT TestAccEC2NetworkInterfaceSgAttachment_SG_basic === CONT TestAccEC2NetworkInterfaceSgAttachment_SG_multiple === CONT TestAccEC2NetworkInterfaceSgAttachment_SG_instance === CONT TestAccEC2NetworkInterfaceSgAttachment_SG_disappears --- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_basic (29.52s) --- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_disappears (29.61s) --- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_multiple (41.81s) --- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_instance (129.43s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 132.286s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_ -timeout 180m === RUN TestAccEC2NetworkInterfaceDataSource_basic === PAUSE TestAccEC2NetworkInterfaceDataSource_basic === RUN TestAccEC2NetworkInterfaceDataSource_filters === PAUSE TestAccEC2NetworkInterfaceDataSource_filters === RUN TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation === PAUSE TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation === RUN TestAccEC2NetworkInterfaceDataSource_publicIPAssociation === PAUSE TestAccEC2NetworkInterfaceDataSource_publicIPAssociation === CONT TestAccEC2NetworkInterfaceDataSource_basic === CONT TestAccEC2NetworkInterfaceDataSource_publicIPAssociation === CONT TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation === CONT TestAccEC2NetworkInterfaceDataSource_filters --- PASS: TestAccEC2NetworkInterfaceDataSource_filters (32.03s) --- PASS: TestAccEC2NetworkInterfaceDataSource_basic (32.63s) --- PASS: TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation (36.03s) --- PASS: TestAccEC2NetworkInterfaceDataSource_publicIPAssociation (42.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 45.285s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfacesDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfacesDataSource_ -timeout 180m === RUN TestAccEC2NetworkInterfacesDataSource_filter === PAUSE TestAccEC2NetworkInterfacesDataSource_filter === RUN TestAccEC2NetworkInterfacesDataSource_tags === PAUSE TestAccEC2NetworkInterfacesDataSource_tags === CONT TestAccEC2NetworkInterfacesDataSource_filter === CONT TestAccEC2NetworkInterfacesDataSource_tags --- PASS: TestAccEC2NetworkInterfacesDataSource_tags (29.56s) --- PASS: TestAccEC2NetworkInterfacesDataSource_filter (29.84s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.858s

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterface_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ -timeout 180m === RUN TestAccEC2NetworkInterface_ENI_basic === PAUSE TestAccEC2NetworkInterface_ENI_basic === RUN TestAccEC2NetworkInterface_ENI_ipv6 === PAUSE TestAccEC2NetworkInterface_ENI_ipv6 === RUN TestAccEC2NetworkInterface_ENI_tags === PAUSE TestAccEC2NetworkInterface_ENI_tags === RUN TestAccEC2NetworkInterface_ENI_ipv6Count === PAUSE TestAccEC2NetworkInterface_ENI_ipv6Count === RUN TestAccEC2NetworkInterface_ENI_disappears === PAUSE TestAccEC2NetworkInterface_ENI_disappears === RUN TestAccEC2NetworkInterface_ENI_description === PAUSE TestAccEC2NetworkInterface_ENI_description === RUN TestAccEC2NetworkInterface_ENI_attachment === PAUSE TestAccEC2NetworkInterface_ENI_attachment === RUN TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === PAUSE TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === RUN TestAccEC2NetworkInterface_ENI_sourceDestCheck === PAUSE TestAccEC2NetworkInterface_ENI_sourceDestCheck === RUN TestAccEC2NetworkInterface_ENI_privateIPsCount === PAUSE TestAccEC2NetworkInterface_ENI_privateIPsCount === RUN TestAccEC2NetworkInterface_ENIInterfaceType_efa === PAUSE TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_basic === CONT TestAccEC2NetworkInterface_ENI_attachment === CONT TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_ipv6 === CONT TestAccEC2NetworkInterface_ENI_sourceDestCheck === CONT TestAccEC2NetworkInterface_ENI_privateIPsCount === CONT TestAccEC2NetworkInterface_ENI_ipv6Count === CONT TestAccEC2NetworkInterface_ENI_description === CONT TestAccEC2NetworkInterface_ENI_disappears === CONT TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === CONT TestAccEC2NetworkInterface_ENI_tags --- PASS: TestAccEC2NetworkInterface_ENI_disappears (47.48s) --- PASS: TestAccEC2NetworkInterface_ENI_basic (48.34s) --- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (52.39s) --- PASS: TestAccEC2NetworkInterface_ENI_description (81.72s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6 (92.79s) --- PASS: TestAccEC2NetworkInterface_ENI_tags (94.86s) --- PASS: TestAccEC2NetworkInterface_ENI_sourceDestCheck (99.54s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6Count (114.31s) --- PASS: TestAccEC2NetworkInterface_ENI_privateIPsCount (119.80s) --- PASS: TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment (273.63s) --- PASS: TestAccEC2NetworkInterface_ENI_attachment (344.90s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 348.007s

…6_prefix' and 'ipv6_prefix_count' arguments.

…me fo IPv6).

…after create.

Acceptance test output: % make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterface_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ -timeout 180m === RUN TestAccEC2NetworkInterface_ENI_basic === PAUSE TestAccEC2NetworkInterface_ENI_basic === RUN TestAccEC2NetworkInterface_ENI_ipv6 === PAUSE TestAccEC2NetworkInterface_ENI_ipv6 === RUN TestAccEC2NetworkInterface_ENI_tags === PAUSE TestAccEC2NetworkInterface_ENI_tags === RUN TestAccEC2NetworkInterface_ENI_ipv6Count === PAUSE TestAccEC2NetworkInterface_ENI_ipv6Count === RUN TestAccEC2NetworkInterface_ENI_disappears === PAUSE TestAccEC2NetworkInterface_ENI_disappears === RUN TestAccEC2NetworkInterface_ENI_description === PAUSE TestAccEC2NetworkInterface_ENI_description === RUN TestAccEC2NetworkInterface_ENI_attachment === PAUSE TestAccEC2NetworkInterface_ENI_attachment === RUN TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === PAUSE TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === RUN TestAccEC2NetworkInterface_ENI_sourceDestCheck === PAUSE TestAccEC2NetworkInterface_ENI_sourceDestCheck === RUN TestAccEC2NetworkInterface_ENI_privateIPsCount === PAUSE TestAccEC2NetworkInterface_ENI_privateIPsCount === RUN TestAccEC2NetworkInterface_ENIInterfaceType_efa === PAUSE TestAccEC2NetworkInterface_ENIInterfaceType_efa === RUN TestAccEC2NetworkInterface_ENI_ipv4Prefix === PAUSE TestAccEC2NetworkInterface_ENI_ipv4Prefix === RUN TestAccEC2NetworkInterface_ENI_ipv4PrefixCount === PAUSE TestAccEC2NetworkInterface_ENI_ipv4PrefixCount === RUN TestAccEC2NetworkInterface_ENI_ipv6Prefix === PAUSE TestAccEC2NetworkInterface_ENI_ipv6Prefix === RUN TestAccEC2NetworkInterface_ENI_ipv6PrefixCount === PAUSE TestAccEC2NetworkInterface_ENI_ipv6PrefixCount === CONT TestAccEC2NetworkInterface_ENI_basic === CONT TestAccEC2NetworkInterface_ENI_sourceDestCheck === CONT TestAccEC2NetworkInterface_ENI_disappears === CONT TestAccEC2NetworkInterface_ENI_tags === CONT TestAccEC2NetworkInterface_ENI_ipv6 === CONT TestAccEC2NetworkInterface_ENI_ipv4PrefixCount === CONT TestAccEC2NetworkInterface_ENI_ipv6PrefixCount === CONT TestAccEC2NetworkInterface_ENI_ipv6Prefix === CONT TestAccEC2NetworkInterface_ENIInterfaceType_efa === CONT TestAccEC2NetworkInterface_ENI_ipv4Prefix === CONT TestAccEC2NetworkInterface_ENI_description === CONT TestAccEC2NetworkInterface_ENI_ipv6Count === CONT TestAccEC2NetworkInterface_ENI_privateIPsCount === CONT TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment === CONT TestAccEC2NetworkInterface_ENI_attachment --- PASS: TestAccEC2NetworkInterface_ENI_disappears (48.88s) --- PASS: TestAccEC2NetworkInterface_ENI_basic (54.46s) --- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (55.39s) --- PASS: TestAccEC2NetworkInterface_ENI_description (79.83s) --- PASS: TestAccEC2NetworkInterface_ENI_sourceDestCheck (100.99s) --- PASS: TestAccEC2NetworkInterface_ENI_tags (101.36s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6 (105.92s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6Prefix (105.92s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv4Prefix (105.94s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv4PrefixCount (122.78s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6Count (127.57s) --- PASS: TestAccEC2NetworkInterface_ENI_ipv6PrefixCount (127.58s) --- PASS: TestAccEC2NetworkInterface_ENI_privateIPsCount (131.80s) --- PASS: TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment (302.54s) --- PASS: TestAccEC2NetworkInterface_ENI_attachment (335.89s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 338.767s

ewbankkit

LGTM 🚀.

% make testacc PKG_NAME=internal/service/fsx TESTARGS='-run=TestAccFSxOntapFileSystem_routeTableIDs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxOntapFileSystem_routeTableIDs -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_routeTableIDs
=== PAUSE TestAccFSxOntapFileSystem_routeTableIDs
=== CONT  TestAccFSxOntapFileSystem_routeTableIDs
--- PASS: TestAccFSxOntapFileSystem_routeTableIDs (2442.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2444.924s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2RouteTableDataSource_\|TestAccEC2RouteTable_' ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run=TestAccEC2RouteTableDataSource_\|TestAccEC2RouteTable_ -timeout 180m
=== RUN   TestAccEC2RouteTableDataSource_basic
=== PAUSE TestAccEC2RouteTableDataSource_basic
=== RUN   TestAccEC2RouteTableDataSource_main
=== PAUSE TestAccEC2RouteTableDataSource_main
=== RUN   TestAccEC2RouteTable_basic
=== PAUSE TestAccEC2RouteTable_basic
=== RUN   TestAccEC2RouteTable_disappears
=== PAUSE TestAccEC2RouteTable_disappears
=== RUN   TestAccEC2RouteTable_Disappears_subnetAssociation
=== PAUSE TestAccEC2RouteTable_Disappears_subnetAssociation
=== RUN   TestAccEC2RouteTable_ipv4ToInternetGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToInternetGateway
=== RUN   TestAccEC2RouteTable_ipv4ToInstance
=== PAUSE TestAccEC2RouteTable_ipv4ToInstance
=== RUN   TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
=== RUN   TestAccEC2RouteTable_tags
=== PAUSE TestAccEC2RouteTable_tags
=== RUN   TestAccEC2RouteTable_requireRouteDestination
=== PAUSE TestAccEC2RouteTable_requireRouteDestination
=== RUN   TestAccEC2RouteTable_requireRouteTarget
=== PAUSE TestAccEC2RouteTable_requireRouteTarget
=== RUN   TestAccEC2RouteTable_Route_mode
=== PAUSE TestAccEC2RouteTable_Route_mode
=== RUN   TestAccEC2RouteTable_ipv4ToTransitGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToTransitGateway
=== RUN   TestAccEC2RouteTable_ipv4ToVPCEndpoint
=== PAUSE TestAccEC2RouteTable_ipv4ToVPCEndpoint
=== RUN   TestAccEC2RouteTable_ipv4ToCarrierGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToCarrierGateway
=== RUN   TestAccEC2RouteTable_ipv4ToLocalGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToLocalGateway
=== RUN   TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
=== PAUSE TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
=== RUN   TestAccEC2RouteTable_vgwRoutePropagation
=== PAUSE TestAccEC2RouteTable_vgwRoutePropagation
=== RUN   TestAccEC2RouteTable_conditionalCIDRBlock
=== PAUSE TestAccEC2RouteTable_conditionalCIDRBlock
=== RUN   TestAccEC2RouteTable_ipv4ToNatGateway
=== PAUSE TestAccEC2RouteTable_ipv4ToNatGateway
=== RUN   TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
=== PAUSE TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
=== RUN   TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
=== PAUSE TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
=== RUN   TestAccEC2RouteTable_vpcMultipleCIDRs
=== PAUSE TestAccEC2RouteTable_vpcMultipleCIDRs
=== RUN   TestAccEC2RouteTable_vpcClassicLink
=== PAUSE TestAccEC2RouteTable_vpcClassicLink
=== RUN   TestAccEC2RouteTable_gatewayVPCEndpoint
=== PAUSE TestAccEC2RouteTable_gatewayVPCEndpoint
=== RUN   TestAccEC2RouteTable_multipleRoutes
=== PAUSE TestAccEC2RouteTable_multipleRoutes
=== RUN   TestAccEC2RouteTable_prefixListToInternetGateway
=== PAUSE TestAccEC2RouteTable_prefixListToInternetGateway
=== CONT  TestAccEC2RouteTableDataSource_basic
=== CONT  TestAccEC2RouteTable_ipv4ToLocalGateway
=== CONT  TestAccEC2RouteTable_prefixListToInternetGateway
=== CONT  TestAccEC2RouteTable_tags
=== CONT  TestAccEC2RouteTable_multipleRoutes
=== CONT  TestAccEC2RouteTable_ipv4ToLocalGateway
    acctest.go:1955: skipping since no Outposts found
--- SKIP: TestAccEC2RouteTable_ipv4ToLocalGateway (1.42s)
=== CONT  TestAccEC2RouteTable_gatewayVPCEndpoint
--- PASS: TestAccEC2RouteTableDataSource_basic (38.52s)
=== CONT  TestAccEC2RouteTable_vpcClassicLink
--- PASS: TestAccEC2RouteTable_prefixListToInternetGateway (40.35s)
=== CONT  TestAccEC2RouteTable_vpcMultipleCIDRs
--- PASS: TestAccEC2RouteTable_gatewayVPCEndpoint (39.27s)
=== CONT  TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached
--- PASS: TestAccEC2RouteTable_tags (61.12s)
=== CONT  TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached
--- PASS: TestAccEC2RouteTable_vpcClassicLink (25.52s)
=== CONT  TestAccEC2RouteTable_ipv4ToNatGateway
--- PASS: TestAccEC2RouteTable_vpcMultipleCIDRs (47.87s)
=== CONT  TestAccEC2RouteTable_conditionalCIDRBlock
--- PASS: TestAccEC2RouteTable_IPv6ToNetworkInterface_unattached (64.22s)
=== CONT  TestAccEC2RouteTable_vgwRoutePropagation
--- PASS: TestAccEC2RouteTable_conditionalCIDRBlock (61.23s)
=== CONT  TestAccEC2RouteTable_ipv4ToVPCPeeringConnection
--- PASS: TestAccEC2RouteTable_IPv4ToNetworkInterfaces_unattached (141.08s)
=== CONT  TestAccEC2RouteTable_ipv4ToTransitGateway
--- PASS: TestAccEC2RouteTable_ipv4ToVPCPeeringConnection (32.68s)
=== CONT  TestAccEC2RouteTable_ipv4ToCarrierGateway
--- PASS: TestAccEC2RouteTable_ipv4ToCarrierGateway (29.48s)
=== CONT  TestAccEC2RouteTable_ipv4ToVPCEndpoint
--- PASS: TestAccEC2RouteTable_vgwRoutePropagation (95.98s)
=== CONT  TestAccEC2RouteTable_Disappears_subnetAssociation
--- PASS: TestAccEC2RouteTable_Disappears_subnetAssociation (28.74s)
=== CONT  TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccEC2RouteTable_multipleRoutes (253.11s)
=== CONT  TestAccEC2RouteTable_ipv4ToInstance
--- PASS: TestAccEC2RouteTable_ipv4ToNatGateway (212.28s)
=== CONT  TestAccEC2RouteTable_ipv4ToInternetGateway
--- PASS: TestAccEC2RouteTable_ipv6ToEgressOnlyInternetGateway (45.39s)
=== CONT  TestAccEC2RouteTable_basic
--- PASS: TestAccEC2RouteTable_basic (27.68s)
=== CONT  TestAccEC2RouteTable_disappears
--- PASS: TestAccEC2RouteTable_ipv4ToInternetGateway (66.24s)
=== CONT  TestAccEC2RouteTable_requireRouteTarget
--- PASS: TestAccEC2RouteTable_ipv4ToVPCEndpoint (338.15s)
=== CONT  TestAccEC2RouteTable_Route_mode
--- PASS: TestAccEC2RouteTable_disappears (21.45s)
=== CONT  TestAccEC2RouteTableDataSource_main
--- PASS: TestAccEC2RouteTable_requireRouteTarget (14.70s)
=== CONT  TestAccEC2RouteTable_requireRouteDestination
--- PASS: TestAccEC2RouteTableDataSource_main (21.31s)
--- PASS: TestAccEC2RouteTable_ipv4ToInstance (123.71s)
--- PASS: TestAccEC2RouteTable_Route_mode (79.30s)
--- PASS: TestAccEC2RouteTable_ipv4ToTransitGateway (397.96s)
--- PASS: TestAccEC2RouteTable_requireRouteDestination (332.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	693.028s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceSgAttachment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceSgAttachment_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceSgAttachment_SG_basic
=== PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_basic
=== RUN   TestAccEC2NetworkInterfaceSgAttachment_SG_disappears
=== PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_disappears
=== RUN   TestAccEC2NetworkInterfaceSgAttachment_SG_instance
=== PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_instance
=== RUN   TestAccEC2NetworkInterfaceSgAttachment_SG_multiple
=== PAUSE TestAccEC2NetworkInterfaceSgAttachment_SG_multiple
=== CONT  TestAccEC2NetworkInterfaceSgAttachment_SG_basic
=== CONT  TestAccEC2NetworkInterfaceSgAttachment_SG_multiple
=== CONT  TestAccEC2NetworkInterfaceSgAttachment_SG_instance
=== CONT  TestAccEC2NetworkInterfaceSgAttachment_SG_disappears
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_basic (29.52s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_disappears (29.61s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_multiple (41.81s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_SG_instance (129.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	132.286s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceAttachment_'     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceAttachment_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceAttachment_basic
=== PAUSE TestAccEC2NetworkInterfaceAttachment_basic
=== CONT  TestAccEC2NetworkInterfaceAttachment_basic
--- PASS: TestAccEC2NetworkInterfaceAttachment_basic (325.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	329.262s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceDataSource_basic
=== PAUSE TestAccEC2NetworkInterfaceDataSource_basic
=== RUN   TestAccEC2NetworkInterfaceDataSource_filters
=== PAUSE TestAccEC2NetworkInterfaceDataSource_filters
=== RUN   TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== RUN   TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_basic
=== CONT  TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_filters
--- PASS: TestAccEC2NetworkInterfaceDataSource_filters (32.03s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_basic (32.63s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation (36.03s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_publicIPAssociation (42.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	45.285s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfacesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfacesDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfacesDataSource_filter
=== PAUSE TestAccEC2NetworkInterfacesDataSource_filter
=== RUN   TestAccEC2NetworkInterfacesDataSource_tags
=== PAUSE TestAccEC2NetworkInterfacesDataSource_tags
=== CONT  TestAccEC2NetworkInterfacesDataSource_filter
=== CONT  TestAccEC2NetworkInterfacesDataSource_tags
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (29.56s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (29.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.858s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterface_'                   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ -timeout 180m
=== RUN   TestAccEC2NetworkInterface_ENI_basic
=== PAUSE TestAccEC2NetworkInterface_ENI_basic
=== RUN   TestAccEC2NetworkInterface_ENI_ipv6
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv6
=== RUN   TestAccEC2NetworkInterface_ENI_tags
=== PAUSE TestAccEC2NetworkInterface_ENI_tags
=== RUN   TestAccEC2NetworkInterface_ENI_ipv6Count
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv6Count
=== RUN   TestAccEC2NetworkInterface_ENI_disappears
=== PAUSE TestAccEC2NetworkInterface_ENI_disappears
=== RUN   TestAccEC2NetworkInterface_ENI_description
=== PAUSE TestAccEC2NetworkInterface_ENI_description
=== RUN   TestAccEC2NetworkInterface_ENI_attachment
=== PAUSE TestAccEC2NetworkInterface_ENI_attachment
=== RUN   TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment
=== PAUSE TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment
=== RUN   TestAccEC2NetworkInterface_ENI_sourceDestCheck
=== PAUSE TestAccEC2NetworkInterface_ENI_sourceDestCheck
=== RUN   TestAccEC2NetworkInterface_ENI_privateIPsCount
=== PAUSE TestAccEC2NetworkInterface_ENI_privateIPsCount
=== RUN   TestAccEC2NetworkInterface_ENIInterfaceType_efa
=== PAUSE TestAccEC2NetworkInterface_ENIInterfaceType_efa
=== RUN   TestAccEC2NetworkInterface_ENI_ipv4Prefix
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv4Prefix
=== RUN   TestAccEC2NetworkInterface_ENI_ipv4PrefixCount
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv4PrefixCount
=== RUN   TestAccEC2NetworkInterface_ENI_ipv6Prefix
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv6Prefix
=== RUN   TestAccEC2NetworkInterface_ENI_ipv6PrefixCount
=== PAUSE TestAccEC2NetworkInterface_ENI_ipv6PrefixCount
=== CONT  TestAccEC2NetworkInterface_ENI_basic
=== CONT  TestAccEC2NetworkInterface_ENI_sourceDestCheck
=== CONT  TestAccEC2NetworkInterface_ENI_disappears
=== CONT  TestAccEC2NetworkInterface_ENI_tags
=== CONT  TestAccEC2NetworkInterface_ENI_ipv6
=== CONT  TestAccEC2NetworkInterface_ENI_ipv4PrefixCount
=== CONT  TestAccEC2NetworkInterface_ENI_ipv6PrefixCount
=== CONT  TestAccEC2NetworkInterface_ENI_ipv6Prefix
=== CONT  TestAccEC2NetworkInterface_ENIInterfaceType_efa
=== CONT  TestAccEC2NetworkInterface_ENI_ipv4Prefix
=== CONT  TestAccEC2NetworkInterface_ENI_description
=== CONT  TestAccEC2NetworkInterface_ENI_ipv6Count
=== CONT  TestAccEC2NetworkInterface_ENI_privateIPsCount
=== CONT  TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment
=== CONT  TestAccEC2NetworkInterface_ENI_attachment
--- PASS: TestAccEC2NetworkInterface_ENI_disappears (48.88s)
--- PASS: TestAccEC2NetworkInterface_ENI_basic (54.46s)
--- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (55.39s)
--- PASS: TestAccEC2NetworkInterface_ENI_description (79.83s)
--- PASS: TestAccEC2NetworkInterface_ENI_sourceDestCheck (100.99s)
--- PASS: TestAccEC2NetworkInterface_ENI_tags (101.36s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6 (105.92s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6Prefix (105.92s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv4Prefix (105.94s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv4PrefixCount (122.78s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6Count (127.57s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6PrefixCount (127.58s)
--- PASS: TestAccEC2NetworkInterface_ENI_privateIPsCount (131.80s)
--- PASS: TestAccEC2NetworkInterface_ENI_ignoreExternalAttachment (302.54s)
--- PASS: TestAccEC2NetworkInterface_ENI_attachment (335.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	338.767s
% make testacc PKG_NAME=internal/service/lambda TESTARGS='-run=TestAccLambdaFunction_vpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaFunction_vpc -timeout 180m
=== RUN   TestAccLambdaFunction_vpc
=== PAUSE TestAccLambdaFunction_vpc
=== RUN   TestAccLambdaFunction_vpcRemoval
=== PAUSE TestAccLambdaFunction_vpcRemoval
=== RUN   TestAccLambdaFunction_vpcUpdate
=== PAUSE TestAccLambdaFunction_vpcUpdate
=== CONT  TestAccLambdaFunction_vpc
=== CONT  TestAccLambdaFunction_vpcUpdate
=== CONT  TestAccLambdaFunction_vpcRemoval
--- PASS: TestAccLambdaFunction_vpc (412.33s)
--- PASS: TestAccLambdaFunction_vpcRemoval (813.06s)
--- PASS: TestAccLambdaFunction_vpcUpdate (843.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	846.176s

ewbankkit · 2021-11-02T22:21:15Z

@awsaxeman Thanks for the contribution 🎉 👏.

github-actions · 2021-11-04T18:24:10Z

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-11T02:31:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

awsaxeman and others added 4 commits October 11, 2021 13:08

ignore cross account ENIs and FSx Tag

0026f9e

Merge remote-tracking branch 'upstream/main' into f-route_table_for_f…

b0c1e67

…sx_ontap_routes

Merge branch 'hashicorp:main' into f-route_table_for_fsx_ontap_routes

34460ea

ignore cross account ENIs and FSx Tag

50c946d

github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Oct 12, 2021

github-actions bot reviewed Oct 12, 2021

View reviewed changes

awsaxeman and others added 6 commits October 13, 2021 12:15

added change log

e57cb05

Merge branch 'hashicorp:main' into f-route_table_for_fsx_ontap_routes

5869f47

Merge branch 'f-route_table_for_fsx_ontap_routes' of https://github.c…

5a837fe

…om/awsaxeman/terraform-provider-aws into f-route_table_for_fsx_ontap_routes

added changelog

970b3f2

added test for FSx route update

1abdf63

resolve conflict

39389cf

github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Oct 16, 2021

ignore cross account ENIs and FSx Tag updated to new schema

3c8c3d3

awsaxeman changed the title ~~[WIP] fix route table for fsx ontap routes and tag~~ fix route table for Amazon FSx for NetApp ONTAP routes and tag Oct 17, 2021

awsaxeman marked this pull request as ready for review October 17, 2021 03:39

ewbankkit added 16 commits October 26, 2021 17:15

r/aws_network_interface: Alphabetize attributes.

c81688d

Tweak CHANGELOG entry.

82bfdfb

r/aws_network_interface: Move wait functionality.

cb30abe

Add constants for network interface attach/detach timeouts.

8f8b316

r/aws_network_interface: Add 'ipv4_prefix', 'ipv4_prefix_count', 'ipv…

3e2f231

…6_prefix' and 'ipv6_prefix_count' arguments.

r/aws_network_interface: 'ipv4_prefix' -> 'ipv4_prefixes' (and the sa…

52e7b77

…me fo IPv6).

r/aws_network_interface: If IPv4 or IPv6 prefixes are specified, tag …

aca0e4f

…after create.

github-actions bot added documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. labels Nov 2, 2021

ewbankkit mentioned this pull request Nov 2, 2021

tech debt: three identical implementations of detaching and deleting ENIs in EC2, ELB, and ELBv2 packages #21406

Closed

ewbankkit approved these changes Nov 2, 2021

View reviewed changes

Merge branch 'main' into HEAD

2d84e21

Fix terrafmt errors.

787bf3a

ewbankkit merged commit aa38005 into hashicorp:main Nov 2, 2021

github-actions bot added this to the v3.64.0 milestone Nov 2, 2021

ewbankkit mentioned this pull request Nov 5, 2021

data aws_network_interface bug #21647

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

awsaxeman commented Oct 12, 2021 •

edited by ewbankkit

Loading

github-actions bot left a comment

awsaxeman commented Oct 17, 2021

zhelding commented Oct 19, 2021

ewbankkit commented Oct 19, 2021

awsaxeman commented Oct 19, 2021

ewbankkit commented Oct 19, 2021

awsaxeman commented Oct 19, 2021

ewbankkit left a comment

ewbankkit commented Nov 2, 2021

github-actions bot commented Nov 4, 2021

github-actions bot commented Jun 11, 2022

fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

Conversation

awsaxeman commented Oct 12, 2021 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

awsaxeman commented Oct 17, 2021

zhelding commented Oct 19, 2021

ewbankkit commented Oct 19, 2021

awsaxeman commented Oct 19, 2021

ewbankkit commented Oct 19, 2021

awsaxeman commented Oct 19, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Nov 2, 2021

github-actions bot commented Nov 4, 2021

github-actions bot commented Jun 11, 2022

awsaxeman commented Oct 12, 2021 •

edited by ewbankkit

Loading