Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: aws/resource_aws_vpc_flow_log destination_options parquet #21285

Merged
merged 7 commits into from
Oct 13, 2021
Merged

enhancement: aws/resource_aws_vpc_flow_log destination_options parquet #21285

merged 7 commits into from
Oct 13, 2021

Conversation

drewmullen
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFlowLog'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFlowLog -timeout 180m
=== RUN   TestAccAWSFlowLog_VPCID
=== PAUSE TestAccAWSFlowLog_VPCID
=== RUN   TestAccAWSFlowLog_LogFormat
=== PAUSE TestAccAWSFlowLog_LogFormat
=== RUN   TestAccAWSFlowLog_SubnetID
=== PAUSE TestAccAWSFlowLog_SubnetID
=== RUN   TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== PAUSE TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== RUN   TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== PAUSE TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== RUN   TestAccAWSFlowLog_tags
=== PAUSE TestAccAWSFlowLog_tags
=== RUN   TestAccAWSFlowLog_disappears
=== PAUSE TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_VPCID
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== CONT  TestAccAWSFlowLog_tags
=== CONT  TestAccAWSFlowLog_SubnetID
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3
=== CONT  TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== CONT  TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== CONT  TestAccAWSFlowLog_LogFormat
=== CONT  TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (20.40s)
--- PASS: TestAccAWSFlowLog_disappears (33.27s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval (37.73s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet (37.80s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible (38.04s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (38.13s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour (38.19s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText (38.23s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (38.37s)
--- PASS: TestAccAWSFlowLog_SubnetID (38.41s)
--- PASS: TestAccAWSFlowLog_VPCID (51.16s)
--- PASS: TestAccAWSFlowLog_LogFormat (52.50s)
--- PASS: TestAccAWSFlowLog_tags (63.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       66.480s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 13, 2021
@drewmullen drewmullen force-pushed the f-aws-vpc-flow-logs-parquet branch from fb7a80b to bdbdccc Compare October 13, 2021 18:35
@ewbankkit ewbankkit self-assigned this Oct 13, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 13, 2021
@drewmullen
Copy link
Collaborator Author

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateFlowLogs.html & https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DestinationOptionsRequest.html

ewbankkit
ewbankkit approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSFlowLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFlowLog_ -timeout 180m
=== RUN   TestAccAWSFlowLog_VPCID
=== PAUSE TestAccAWSFlowLog_VPCID
=== RUN   TestAccAWSFlowLog_LogFormat
=== PAUSE TestAccAWSFlowLog_LogFormat
=== RUN   TestAccAWSFlowLog_SubnetID
=== PAUSE TestAccAWSFlowLog_SubnetID
=== RUN   TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== PAUSE TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== RUN   TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== PAUSE TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== RUN   TestAccAWSFlowLog_tags
=== PAUSE TestAccAWSFlowLog_tags
=== RUN   TestAccAWSFlowLog_disappears
=== PAUSE TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_VPCID
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== CONT  TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_LogFormat
=== CONT  TestAccAWSFlowLog_tags
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== CONT  TestAccAWSFlowLog_SubnetID
=== CONT  TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== CONT  TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_Invalid
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (20.62s)
--- PASS: TestAccAWSFlowLog_disappears (39.04s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (50.61s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval (51.10s)
--- PASS: TestAccAWSFlowLog_SubnetID (53.57s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (54.35s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible (54.39s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText (54.40s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour (54.40s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible (54.41s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet (54.50s)
--- PASS: TestAccAWSFlowLog_VPCID (70.41s)
--- PASS: TestAccAWSFlowLog_LogFormat (77.56s)
--- PASS: TestAccAWSFlowLog_tags (89.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	92.817s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSFlowLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFlowLog_ -timeout 180m
=== RUN   TestAccAWSFlowLog_VPCID
=== PAUSE TestAccAWSFlowLog_VPCID
=== RUN   TestAccAWSFlowLog_LogFormat
=== PAUSE TestAccAWSFlowLog_LogFormat
=== RUN   TestAccAWSFlowLog_SubnetID
=== PAUSE TestAccAWSFlowLog_SubnetID
=== RUN   TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== PAUSE TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== RUN   TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== PAUSE TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== RUN   TestAccAWSFlowLog_tags
=== PAUSE TestAccAWSFlowLog_tags
=== RUN   TestAccAWSFlowLog_disappears
=== PAUSE TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_VPCID
=== CONT  TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval
=== CONT  TestAccAWSFlowLog_tags
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour
=== CONT  TestAccAWSFlowLog_SubnetID
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3
=== CONT  TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== CONT  TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_LogFormat
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (32.44s)
--- PASS: TestAccAWSFlowLog_disappears (46.71s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_MaxAggregationInterval (51.63s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (51.99s)
--- PASS: TestAccAWSFlowLog_SubnetID (54.99s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet (55.76s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible_PerHour (58.46s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (58.67s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText_HiveCompatible (58.68s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_Parquet_HiveCompatible (58.68s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_DO_PlainText (58.74s)
--- PASS: TestAccAWSFlowLog_VPCID (71.63s)
--- PASS: TestAccAWSFlowLog_LogFormat (80.22s)
--- PASS: TestAccAWSFlowLog_tags (87.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.821s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@drewmullen drewmullen mentioned this pull request Oct 13, 2021
Merged
1 task
@ewbankkit ewbankkit merged commit 027a9b9 into hashicorp:main Oct 13, 2021
@github-actions github-actions bot added this to the v3.63.0 milestone Oct 13, 2021
@ewbankkit ewbankkit mentioned this pull request Oct 13, 2021
Merged
@ewbankkit
Copy link
Contributor

Announcement.

@ewbankkit ewbankkit mentioned this pull request Oct 14, 2021
Merged
@github-actions
Copy link

This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Oct 20, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drewmullen @ewbankkit @justinretzolk