Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "priority" parameter in aws_appmesh_gateway_route #21345

Closed
mkielar opened this issue Oct 18, 2021 · 4 comments · Fixed by #29064
Closed

Add support for "priority" parameter in aws_appmesh_gateway_route #21345

mkielar opened this issue Oct 18, 2021 · 4 comments · Fixed by #29064
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@mkielar
Copy link
Contributor

mkielar commented Oct 18, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Allow providing priorities for Virtual Gateway Routes, similar to how it's possible for Virtual Router Routes.

New or Affected Resource(s)

  • aws_appmesh_gateway_route

Potential Terraform Configuration

resource "aws_appmesh_gateway_route" "example" {
  name                 = "example-gateway-route"
  mesh_name            = "example-service-mesh"
  virtual_gateway_name = aws_appmesh_virtual_gateway.example.name

  spec {
    priority = 7  # <<< new attribute!
  
    http_route {
      action {
        target {
          virtual_service {
            virtual_service_name = aws_appmesh_virtual_service.example.name
          }
        }
      }

      match {
        prefix = "/"
      }
    }
  }

  tags = {
    Environment = "test"
  }
}

References

@mkielar mkielar added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 18, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/appmesh Issues and PRs that pertain to the appmesh service. labels Oct 18, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 22, 2021
@ckonefke
Copy link

I think this is more than enhancement. When you have more than one gateway route, you really need them prioritized so they get matched in the proper order.

@AdamTylerLynch AdamTylerLynch self-assigned this Sep 14, 2022
@AdamTylerLynch
Copy link
Collaborator

@justinretzolk I'll pick this up.

@brandocomando
Copy link

Any updates on this?

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants