Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/neptune_cluster: support in-place update of engine_version #21760

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Nov 12, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21378

Output from acceptance testing:

--- PASS: TestAccNeptuneCluster_updateEngineVersion (1659.73s)

--- PASS: TestAccNeptuneClusterParameterGroup_description (50.76s)
--- PASS: TestAccNeptuneClusterParameterGroup_basic (51.99s)
--- PASS: TestAccNeptuneClusterParameterGroup_generatedName (52.91s)
--- PASS: TestAccNeptuneClusterParameterGroup_namePrefix (53.21s)
--- PASS: TestAccNeptuneClusterParameterGroup_NamePrefix_parameter (67.93s)
--- PASS: TestAccNeptuneClusterParameterGroup_parameter (68.82s)
--- PASS: TestAccNeptuneClusterParameterGroup_tags (82.36s)
--- PASS: TestAccNeptuneCluster_basic (163.58s)
--- PASS: TestAccNeptuneCluster_namePrefix (134.36s)
--- PASS: TestAccNeptuneClusterEndpoint_Disappears_cluster (196.53s)
--- PASS: TestAccNeptuneCluster_kmsKey (158.87s)
--- PASS: TestAccNeptuneCluster_updateIAMRoles (177.79s)
--- PASS: TestAccNeptuneCluster_encrypted (164.08s)
--- PASS: TestAccNeptuneClusterEndpoint_tags (274.00s)
--- PASS: TestAccNeptuneCluster_takeFinalSnapshot (225.76s)
--- PASS: TestAccNeptuneClusterSnapshot_basic (289.31s)
--- PASS: TestAccNeptuneCluster_backupsUpdate (207.18s)
--- PASS: TestAccNeptuneClusterEndpoint_disappears (290.69s)
--- PASS: TestAccNeptuneCluster_iamAuth (128.90s)
--- PASS: TestAccNeptuneClusterEndpoint_basic (293.70s)
--- PASS: TestAccNeptuneCluster_copyTagsToSnapshot (295.20s)
--- PASS: TestAccNeptuneCluster_tags (246.26s)
--- PASS: TestAccNeptuneCluster_disappears (165.95s)
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (234.08s)
--- PASS: TestAccNeptuneCluster_deleteProtection (231.15s)
--- PASS: TestAccNeptuneClusterInstance_namePrefix (745.17s)
--- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (773.37s)
--- PASS: TestAccNeptuneClusterInstance_kmsKey (815.54s)
--- PASS: TestAccNeptuneClusterInstance_withAZ (952.68s)
--- PASS: TestAccNeptuneClusterInstance_generatedName (1714.76s)
--- PASS: TestAccNeptuneClusterInstance_basic (2030.08s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/neptune Issues and PRs that pertain to the neptune service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 12, 2021
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 12, 2021
@anGie44 anGie44 marked this pull request as ready for review November 15, 2021 01:41
@ewbankkit ewbankkit self-assigned this Nov 15, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=internal/service/neptune TESTARGS='-run=TestAccNeptuneCluster_updateEngineVersion\|TestAccNeptuneCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run=TestAccNeptuneCluster_updateEngineVersion\|TestAccNeptuneCluster_basic -timeout 180m
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_updateEngineVersion
=== PAUSE TestAccNeptuneCluster_updateEngineVersion
=== CONT  TestAccNeptuneCluster_basic
=== CONT  TestAccNeptuneCluster_updateEngineVersion
--- PASS: TestAccNeptuneCluster_basic (156.88s)
--- PASS: TestAccNeptuneCluster_updateEngineVersion (1569.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	1575.245s

@ewbankkit ewbankkit removed their assignment Nov 15, 2021
@anGie44 anGie44 added this to the v3.66.0 milestone Nov 15, 2021
@anGie44 anGie44 merged commit 4ddd35b into main Nov 15, 2021
@anGie44 anGie44 deleted the e-neptune-cluster-update-engine-version-inplace branch November 15, 2021 15:50
github-actions bot pushed a commit that referenced this pull request Nov 15, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/neptune Issues and PRs that pertain to the neptune service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_neptune_cluster - Changing engine_version update in place
2 participants