Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_load_balancer_policy: suppress computed policy_attribute diffs #21776

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Nov 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2867
Closes #995

Output from acceptance testing (commercial):

--- PASS: TestAccELBPolicy_basic (24.17s)
--- PASS: TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly (24.19s)
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly (40.09s)
--- PASS: TestAccELBPolicy_SSLSecurityPolicy_predefined (43.73s)
--- PASS: TestAccELBPolicy_updateWhileAssigned (47.47s)
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy (47.48s)
--- PASS: TestAccELBPolicy_disappears (63.98s)

@github-actions github-actions bot added service/elb Issues and PRs that pertain to the elb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Nov 15, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 21, 2021
@anGie44 anGie44 force-pushed the b-elb-policy-predefined-ssl branch from 9d2b653 to 6de3d52 Compare December 21, 2021 16:27
@anGie44 anGie44 marked this pull request as ready for review December 21, 2021 16:29
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Dec 21, 2021
@anGie44 anGie44 force-pushed the b-elb-policy-predefined-ssl branch from 6de3d52 to 06860b8 Compare December 21, 2021 16:34
@gdavison gdavison self-assigned this Jan 14, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

--- PASS: TestAccELBPolicy_basic (43.59s)
--- PASS: TestAccELBPolicy_LBCookieStickinessPolicyType_computedAttributesOnly (51.87s)
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_computedAttributesOnly (58.22s)
--- PASS: TestAccELBPolicy_disappears (78.84s)
--- PASS: TestAccELBPolicy_updateWhileAssigned (79.88s)
--- PASS: TestAccELBPolicy_SSLNegotiationPolicyType_customPolicy (89.50s)
--- PASS: TestAccELBPolicy_SSLSecurityPolicy_predefined (89.75s)

internal/service/elb/policy_test.go Outdated Show resolved Hide resolved
@gdavison gdavison removed their assignment Jan 15, 2022
Co-authored-by: Graham Davison <gdavison@hashicorp.com>
@anGie44 anGie44 added this to the v3.73.0 milestone Jan 18, 2022
@anGie44 anGie44 merged commit 307876f into main Jan 18, 2022
@anGie44 anGie44 deleted the b-elb-policy-predefined-ssl branch January 18, 2022 17:28
github-actions bot pushed a commit that referenced this pull request Jan 18, 2022
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elb Issues and PRs that pertain to the elb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants