Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption-in-transit-supported attribute to aws_ec2_instance_type #21837

Conversation

rrangith
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21624

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2InstanceTypeDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypeDataSource' -timeout 180m
=== RUN   TestAccEC2InstanceTypeDataSource_basic
=== PAUSE TestAccEC2InstanceTypeDataSource_basic
=== RUN   TestAccEC2InstanceTypeDataSource_metal
=== PAUSE TestAccEC2InstanceTypeDataSource_metal
=== RUN   TestAccEC2InstanceTypeDataSource_gpu
=== PAUSE TestAccEC2InstanceTypeDataSource_gpu
=== RUN   TestAccEC2InstanceTypeDataSource_fpga
=== PAUSE TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_basic
=== CONT  TestAccEC2InstanceTypeDataSource_gpu
=== CONT  TestAccEC2InstanceTypeDataSource_metal
=== CONT  TestAccEC2InstanceTypeDataSource_fpga
--- PASS: TestAccEC2InstanceTypeDataSource_basic (38.18s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (39.79s)
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (39.87s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (40.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        42.123s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 18, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rrangith 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 18, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEC2InstanceTypeDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypeDataSource_' -timeout 180m
=== RUN   TestAccEC2InstanceTypeDataSource_basic
=== PAUSE TestAccEC2InstanceTypeDataSource_basic
=== RUN   TestAccEC2InstanceTypeDataSource_metal
=== PAUSE TestAccEC2InstanceTypeDataSource_metal
=== RUN   TestAccEC2InstanceTypeDataSource_gpu
=== PAUSE TestAccEC2InstanceTypeDataSource_gpu
=== RUN   TestAccEC2InstanceTypeDataSource_fpga
=== PAUSE TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_basic
=== CONT  TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_gpu
=== CONT  TestAccEC2InstanceTypeDataSource_metal
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (12.31s)
--- PASS: TestAccEC2InstanceTypeDataSource_basic (12.32s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (12.34s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (12.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	15.943s

@ewbankkit
Copy link
Contributor

@rrangith Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f6c1bd4 into hashicorp:main Nov 18, 2021
@github-actions github-actions bot added this to the v3.66.0 milestone Nov 18, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add encryption-in-transit-supported attribute to aws_ec2_instance_type
2 participants