👽 add support for aws_autoscaling_group filters

[danquack]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Some people have asked me on the 👽 . These emojis are defined by gitmoji.dev, which relates to Update code due to external API changes.

Relates OR Closes #3534

Output from acceptance testing:

~ make testacc TESTARGS="-run=TestAccAutoScalingGroupsDataSource_basic" PKG_NAME="./internal/service/autoscaling" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/autoscaling/... -v -count 1 -parallel 3 -run=TestAccAutoScalingGroupsDataSource_basic -timeout 180m
=== RUN   TestAccAutoScalingGroupsDataSource_basic
=== PAUSE TestAccAutoScalingGroupsDataSource_basic
=== CONT  TestAccAutoScalingGroupsDataSource_basic
--- PASS: TestAccAutoScalingGroupsDataSource_basic (75.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        79.298s

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Welcome @danquack 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[danquack]

The resources were not being created with this function, but rather using the testAccCheckGroupsConfig above resources. Therefore, I removed some of this cruft.

[drewmullen]

great work! thanks for your contribution. 1 🎨 stylistic change requested

[drewmullen]

lgtm! 🚀

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS="-run=TestAccAutoScalingGroupsDataSource_basic" PKG_NAME="./internal/service/autoscaling"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/autoscaling/... -v -count 1 -parallel 20 -run=TestAccAutoScalingGroupsDataSource_basic -timeout 180m
=== RUN   TestAccAutoScalingGroupsDataSource_basic
=== PAUSE TestAccAutoScalingGroupsDataSource_basic
=== CONT  TestAccAutoScalingGroupsDataSource_basic
--- PASS: TestAccAutoScalingGroupsDataSource_basic (47.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	51.526s

[ewbankkit]

@danquack Thanks for the contribution.
In general the changes look great. I went ahead and simplified the acceptance testing configuration(s) even more, consolidating into a single generating function (the fact that the data sources weren't referencing or depending on any of the autoscaling group resources may lead to intermittent tests failures).

[github-actions]

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.