Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hugging Face DLC images to sagemaker pre-built ecr image #21983

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

philschmid
Copy link
Contributor

@philschmid philschmid commented Dec 1, 2021

What does this PR do?

This PR adds the Hugging Face DLCs to the aws_sagemaker_prebuilt_ecr_image data source. The Hugging Face DLCs include flavors for TensorFlow and PyTorch with Training and Inference Containers. I checked the region account mapping.

example

data "aws_sagemaker_prebuilt_ecr_image" "test" {
  repository_name = "huggingface-pytorch-inference"
  image_tag       = "1.7.1-transformers4.6.1-gpu-py36-cu110-ubuntu18.04"
}

I hope the .changelog is correct.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ AWS_PROFILE=hf-sm make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_basic PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_basic' -timeout 180m
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_basic
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_basic
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_basic
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_basic (15.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  17.434s```

```bash
$ AWS_PROFILE=hf-sm make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_region PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_region' -timeout 180m
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_region
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_region
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_region
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_region (15.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  17.370s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR. labels Dec 1, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @philschmid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 5, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_ PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_' -timeout 180m
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_basic
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_basic
=== RUN   TestAccSageMakerPrebuiltECRImageDataSource_region
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_region
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_basic
=== CONT  TestAccSageMakerPrebuiltECRImageDataSource_region
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_basic (8.17s)
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_region (8.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	11.618s

@ewbankkit
Copy link
Contributor

@philschmid Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b9b1bf8 into hashicorp:main Dec 10, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 10, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@philschmid
Copy link
Contributor Author

Hey @ewbankkit,
I just noticed i forgot to add them to the documentation. I opened a new PR for it.

@github-actions github-actions bot modified the milestones: v3.70.0, v3.71.0 Dec 17, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants