-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hugging Face DLC images to sagemaker pre-built ecr image #21983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @philschmid 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccSageMakerPrebuiltECRImageDataSource_ PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerPrebuiltECRImageDataSource_' -timeout 180m
=== RUN TestAccSageMakerPrebuiltECRImageDataSource_basic
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_basic
=== RUN TestAccSageMakerPrebuiltECRImageDataSource_region
=== PAUSE TestAccSageMakerPrebuiltECRImageDataSource_region
=== CONT TestAccSageMakerPrebuiltECRImageDataSource_basic
=== CONT TestAccSageMakerPrebuiltECRImageDataSource_region
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_basic (8.17s)
--- PASS: TestAccSageMakerPrebuiltECRImageDataSource_region (8.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 11.618s
@philschmid Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Hey @ewbankkit, |
This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
What does this PR do?
This PR adds the Hugging Face DLCs to the
aws_sagemaker_prebuilt_ecr_image
data source. The Hugging Face DLCs include flavors for TensorFlow and PyTorch with Training and Inference Containers. I checked the region account mapping.example
I hope the
.changelog
is correct.Community Note
Output from acceptance testing: