Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_region_settings: Add ResourceTypeManagementPreference #22021

Merged

Conversation

iwparker
Copy link
Contributor

@iwparker iwparker commented Dec 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22012

Release note for CHANGELOG:

resource/aws_backup_region_settings: Add resource_type_management_preference argument

Output from acceptance testing:

$ make testacc TESTS=TestAccBackupRegionSettings PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupRegionSettings' -timeout 180m
=== RUN   TestAccBackupRegionSettings_basic
=== PAUSE TestAccBackupRegionSettings_basic
=== CONT  TestAccBackupRegionSettings_basic
--- PASS: TestAccBackupRegionSettings_basic (31.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	33.840s

@iwparker iwparker requested a review from ewbankkit as a code owner December 2, 2021 19:12
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 2, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @iwparker 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2021
@ewbankkit
Copy link
Contributor

Relates: #16114.

…rce_type_management_preference as Optional+Computed.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccBackupRegionSettings_basic' PKG_NAME=internal/service/backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run=TestAccBackupRegionSettings_basic -timeout 180m
=== RUN   TestAccBackupRegionSettings_basic
=== PAUSE TestAccBackupRegionSettings_basic
=== CONT  TestAccBackupRegionSettings_basic
--- PASS: TestAccBackupRegionSettings_basic (33.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	36.856s
@github-actions github-actions bot added the flex Pertains to FLatteners and EXpanders. label Dec 2, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBackupRegionSettings_basic' PKG_NAME=internal/service/backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 20 -run=TestAccBackupRegionSettings_basic -timeout 180m
=== RUN   TestAccBackupRegionSettings_basic
=== PAUSE TestAccBackupRegionSettings_basic
=== CONT  TestAccBackupRegionSettings_basic
--- PASS: TestAccBackupRegionSettings_basic (33.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	36.856s

@ewbankkit
Copy link
Contributor

@iwparker Thanks for the contribution 🎉 👏.
In general everything looks great.
To maintain backwards compatibility with existing configurations I changed resource_type_management_preference to be Optional and Computed instead of Required.

@ewbankkit ewbankkit merged commit 5a3afdb into hashicorp:main Dec 2, 2021
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 2, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ResourceTypeManagementPreference to aws_backup_region_settings
2 participants