Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/transfer: add lambda identity provider support #22039

Merged
merged 8 commits into from
Dec 3, 2021

Conversation

nij4t
Copy link
Contributor

@nij4t nij4t commented Dec 3, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22038.
Closes #22041.

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. labels Dec 3, 2021
@nij4t nij4t changed the title r/transfer: add identity provider details field r/transfer: add lambda identity provider field Dec 3, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 3, 2021
@nij4t nij4t changed the title r/transfer: add lambda identity provider field r/transfer: add lambda identity provider support Dec 3, 2021
@nij4t nij4t force-pushed the lamda_identity_provider branch from 351e617 to 4aa2a2d Compare December 3, 2021 17:50
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. labels Dec 3, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nij4t 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 3, 2021
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 3, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/basic' PKG_NAME=internal/service/transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/basic -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (203.56s)
    --- PASS: TestAccTransfer_serial/Server (203.56s)
        --- PASS: TestAccTransfer_serial/Server/basic (203.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	208.884s
% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/LambdaFunction' PKG_NAME=internal/service/transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run=TestAccTransfer_serial/Server/LambdaFunction -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
--- PASS: TestAccTransfer_serial (192.18s)
    --- PASS: TestAccTransfer_serial/Server (192.18s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (192.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	197.640s

@ewbankkit
Copy link
Contributor

@nij4t Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Dec 3, 2021
@ewbankkit ewbankkit merged commit 340fa9d into hashicorp:main Dec 3, 2021
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 3, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/transfer Issues and PRs that pertain to the transfer service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants