New resource for Detective Graph

[coderGo93]

Added a new resource, doc and tests for Detective Graph called aws_detective_graph

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11672

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsDetectiveGraph' PKG_NAME=internal/service/detective 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20 -run=TestAccAwsDetectiveGraph -timeout 180m
=== RUN   TestAccAwsDetectiveGraph_basic
--- PASS: TestAccAwsDetectiveGraph_basic (23.30s)
=== RUN   TestAccAwsDetectiveGraph_WithTags
--- PASS: TestAccAwsDetectiveGraph_WithTags (37.13s)
=== RUN   TestAccAwsDetectiveGraph_disappears
--- PASS: TestAccAwsDetectiveGraph_disappears (14.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  77.034s


...

[zhelding]

Hi @coderGo93! Thanks so much for the PR.

I've gone ahead and made a handful of comments, mostly small in scope.

The major change required is to add support for modifying the tags of a Detective graph in-place, i.e. the addition of a resourceGraphUpdate function. Adding and removing tags from a Detective graph does not in fact force a new resource, so we need update support for this resource.

[zhelding]

Hi @coderGo93! Thanks for your fixes.

I've gone ahead and made a few final additional tweaks -- namely:

• Added in the CustomizeDIff: verify.SetTagsDiff handler to properly detect tag diffs
• Added a -ListTags flag to detective/generate.go and used the generated ListTags function in resourceGraphRead instead of calling the AWS operation directly
• Renamed the tagging acceptance test configs for clarity
• Swapped out diag.FromErr(fmt.Errorf()) with the simpler equivalent diag.Errorf()
• Clarified docs a bit more re: provisioning multiple Detective graphs

I'm going to wait for our final CI checks to pass while I look over the code once more, but then I think this is good to merge!

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.