remove :* suffix on cloudwatchlog group datasource

[maquessime]

Closes #15073.

To match what we have on the resource create/read in

terraform-provider-aws/internal/service/cloudwatchlogs/group.go

Line 142 in 187f165

d.Set("arn", TrimLogGroupARNWildcardSuffix(aws.StringValue(lg.Arn)))

Potential breaking change since we don't know what string manipulation clients do on their end :/

I'll add acctest output and changelog if that makes since to merge this PR.

Potential refactor : reuse what we do after

terraform-provider-aws/internal/service/cloudwatchlogs/group.go

Line 131 in 187f165

lg, err := LookupGroup(conn, d.Id())

in https://github.com/hashicorp/terraform-provider-aws/blame/187f1659a4fef11ac314567273b5470afe6b662f/internal/service/cloudwatchlogs/group_data_source.go#L46 - out of scope of this PR however.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[github-actions]

Welcome @maquessime 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[anGie44]

Hi @maquessime , thank you for this PR! I'll be reviewing and updating this PR if needed to get it into our major release, though the code change itself LGTM 👍

[anGie44]

Thanks again @maquessime 🚀 !

Output of acceptance tests:

--- FAIL: TestAccCloudWatchLogsGroup_tagging (92.14s) -- related to empty tags issue https://github.com/hashicorp/terraform-provider-aws/issues/20371 
--- PASS: TestAccCloudWatchLogsGroupDataSource_basic (56.88s)
--- PASS: TestAccCloudWatchLogsGroupDataSource_kms (60.96s)
--- PASS: TestAccCloudWatchLogsGroupDataSource_retention (57.11s)
--- PASS: TestAccCloudWatchLogsGroupDataSource_tags (56.44s)
--- PASS: TestAccCloudWatchLogsGroup_NamePrefix_retention (75.10s)
--- PASS: TestAccCloudWatchLogsGroup_basic (63.20s)
--- PASS: TestAccCloudWatchLogsGroup_disappears (52.01s)
--- PASS: TestAccCloudWatchLogsGroup_generatedName (62.76s)
--- PASS: TestAccCloudWatchLogsGroup_kmsKey (80.69s)
--- PASS: TestAccCloudWatchLogsGroup_multiple (61.82s)
--- PASS: TestAccCloudWatchLogsGroup_namePrefix (62.97s)
--- PASS: TestAccCloudWatchLogsGroup_retentionPolicy (76.66s)
--- PASS: TestAccCloudWatchLogsGroupsDataSource_basic (55.66s)

[maquessime]

cool thanks @anGie44

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.