b/aws_redshift_cluster: Adds retries to enabling and disabling the redshift cluster's logging

[larssnellman]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds retries to actions that enable or disable the redshift cluster's logging when returned the error code "InvalidClusterState".

Closes #21815

Output from acceptance testing:

TF_ACC=1 go test ./internal/service/redshift -v -count 1 -parallel 20 -run=TestAccRedshiftCluster_loggingEnabled -timeout 180m
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (311.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	314.640s
...

Previously:
(Test would intermittently fail, in this example we fail on removing logging)

lars@Lars's-MacBook-Pro terraform-provider-aws % TF_ACC=1 go test ./internal/service/redshift -v -count 1 -parallel 20 -run=TestAccRedshiftCluster_loggingEnabled -timeout 180m
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (260.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   262.972s
lars@Lars's-MacBook-Pro terraform-provider-aws % TF_ACC=1 go test ./internal/service/redshift -v -count 1 -parallel 20 -run=TestAccRedshiftCluster_loggingEnabled -timeout 180m
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftCluster_loggingEnabled
    cluster_test.go:191: Step 3/3 error: Error running apply: exit status 1

        Error: InvalidClusterState: There is an operation running on the Cluster. Please try to disable logging at a later time.
                status code: 400, request id: a30468db-ea8e-4b9e-b92f-f338ca5db0fd

          with aws_redshift_cluster.test,
          on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "test":
          12: resource "aws_redshift_cluster" "test" {

--- FAIL: TestAccRedshiftCluster_loggingEnabled (279.75s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/redshift   282.620s
FAIL

[ewbankkit]

We have a failing CI test:

=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftCluster_loggingEnabled
cluster_test.go:191: Step 3/3 error: Error running apply: exit status 1
Error: InvalidClusterState: There is an operation running on the Cluster. Please try to disable logging at a later time.
  status code: 400, request id: 2aaa7058-dc20-4da5-8953-7d2fa4ebeaed
with aws_redshift_cluster.test,
on terraform_plugin_test.tf line 12, in resource "aws_redshift_cluster" "test":
12: resource "aws_redshift_cluster" "test" {

[ewbankkit]

LGTM 🚀.

% make testacc PKG=redshift TESTS=TestAccRedshiftCluster_loggingEnabled                                                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftCluster_loggingEnabled' -timeout 180m
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_loggingEnabled (297.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	301.171s

[ewbankkit]

@larssnellman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.