Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events/bus_policy: Fix diffs with policy #22165

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21968

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccEventsBusPolicy_ PKG=events 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBusPolicy_' -timeout 180m
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (22.35s)
--- PASS: TestAccEventsBusPolicy_basic (27.73s)
--- PASS: TestAccEventsBusPolicy_disappears (133.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	135.115s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccEventsBusPolicy_ PKG=events 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBusPolicy_' -timeout 180m
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (27.80s)
--- PASS: TestAccEventsBusPolicy_basic (34.88s)
--- PASS: TestAccEventsBusPolicy_disappears (138.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	139.324s

@github-actions github-actions bot added service/events Issues and PRs that pertain to the events service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Dec 10, 2021
@YakDriver YakDriver force-pushed the b-events-bus-policy-diffs branch from 0d7cb1d to e151577 Compare December 10, 2021 19:07
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccEventsBusPolicy_ PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsBusPolicy_' -timeout 180m
=== RUN   TestAccEventsBusPolicy_basic
=== PAUSE TestAccEventsBusPolicy_basic
=== RUN   TestAccEventsBusPolicy_ignoreEquivalent
=== PAUSE TestAccEventsBusPolicy_ignoreEquivalent
=== RUN   TestAccEventsBusPolicy_disappears
=== PAUSE TestAccEventsBusPolicy_disappears
=== CONT  TestAccEventsBusPolicy_basic
=== CONT  TestAccEventsBusPolicy_disappears
=== CONT  TestAccEventsBusPolicy_ignoreEquivalent
--- PASS: TestAccEventsBusPolicy_ignoreEquivalent (24.56s)
--- PASS: TestAccEventsBusPolicy_basic (29.90s)
--- PASS: TestAccEventsBusPolicy_disappears (135.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	140.823s

@YakDriver YakDriver merged commit a5897a0 into main Dec 13, 2021
@YakDriver YakDriver deleted the b-events-bus-policy-diffs branch December 13, 2021 17:04
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 13, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/events Issues and PRs that pertain to the events service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants