-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glacier/vault: Fix spurious policy diffs #22166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlacierVaultLock_\|TestAccGlacierVault_' PKG=glacier
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glacier/... -v -count 1 -parallel 20 -run=TestAccGlacierVaultLock_\|TestAccGlacierVault_ -timeout 180m
=== RUN TestAccGlacierVaultLock_basic
=== PAUSE TestAccGlacierVaultLock_basic
=== RUN TestAccGlacierVaultLock_completeLock
=== PAUSE TestAccGlacierVaultLock_completeLock
=== RUN TestAccGlacierVaultLock_ignoreEquivalentPolicy
=== PAUSE TestAccGlacierVaultLock_ignoreEquivalentPolicy
=== RUN TestAccGlacierVault_basic
=== PAUSE TestAccGlacierVault_basic
=== RUN TestAccGlacierVault_notification
=== PAUSE TestAccGlacierVault_notification
=== RUN TestAccGlacierVault_policy
=== PAUSE TestAccGlacierVault_policy
=== RUN TestAccGlacierVault_tags
=== PAUSE TestAccGlacierVault_tags
=== RUN TestAccGlacierVault_disappears
=== PAUSE TestAccGlacierVault_disappears
=== RUN TestAccGlacierVault_ignoreEquivalent
=== PAUSE TestAccGlacierVault_ignoreEquivalent
=== CONT TestAccGlacierVaultLock_basic
=== CONT TestAccGlacierVault_policy
=== CONT TestAccGlacierVault_disappears
=== CONT TestAccGlacierVault_notification
=== CONT TestAccGlacierVault_tags
=== CONT TestAccGlacierVaultLock_ignoreEquivalentPolicy
=== CONT TestAccGlacierVault_basic
=== CONT TestAccGlacierVault_ignoreEquivalent
=== CONT TestAccGlacierVaultLock_completeLock
--- PASS: TestAccGlacierVault_disappears (17.45s)
--- PASS: TestAccGlacierVault_basic (22.40s)
--- PASS: TestAccGlacierVaultLock_basic (24.51s)
--- PASS: TestAccGlacierVaultLock_completeLock (25.10s)
--- PASS: TestAccGlacierVault_ignoreEquivalent (30.38s)
--- PASS: TestAccGlacierVaultLock_ignoreEquivalentPolicy (31.58s)
--- PASS: TestAccGlacierVault_tags (51.51s)
--- PASS: TestAccGlacierVault_policy (52.37s)
--- PASS: TestAccGlacierVault_notification (55.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glacier 59.565s
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21968
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):