Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkfirewall/resource_policy: Fix equivalent policy diffs #22171

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21968

Output from acceptance testing:

(For failure, see #22174)

--- FAIL: TestAccNetworkFirewallResourcePolicy_disappears (11.17s) (* failing prior to this PR)
--- PASS: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (146.07s)
--- PASS: TestAccNetworkFirewallResourcePolicy_basic (148.90s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (150.59s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (154.69s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (156.17s)

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccNetworkFirewallResourcePolicy PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallResourcePolicy' -timeout 180m
--- SKIP: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (19.72s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_basic (25.46s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (25.74s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_ruleGroup (26.10s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_disappears (28.29s)
--- SKIP: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (29.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	30.575s

@github-actions github-actions bot added service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/XS Managed by automation to categorize the size of a PR. labels Dec 10, 2021
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 10, 2021
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Dec 10, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccNetworkFirewallResourcePolicy_ PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallResourcePolicy_' -timeout 180m
=== RUN   TestAccNetworkFirewallResourcePolicy_basic
=== PAUSE TestAccNetworkFirewallResourcePolicy_basic
=== RUN   TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== PAUSE TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== RUN   TestAccNetworkFirewallResourcePolicy_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_ruleGroup
=== RUN   TestAccNetworkFirewallResourcePolicy_disappears
=== PAUSE TestAccNetworkFirewallResourcePolicy_disappears
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== RUN   TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_basic
=== CONT  TestAccNetworkFirewallResourcePolicy_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== CONT  TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT  TestAccNetworkFirewallResourcePolicy_disappears
--- PASS: TestAccNetworkFirewallResourcePolicy_basic (149.80s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (151.27s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (157.61s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (157.65s)
--- PASS: TestAccNetworkFirewallResourcePolicy_disappears (157.95s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (158.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	162.632s

@YakDriver YakDriver merged commit b26ba26 into main Dec 13, 2021
@YakDriver YakDriver deleted the b-networkfw-resource-policy-diffs branch December 13, 2021 17:06
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 13, 2021
github-actions bot pushed a commit that referenced this pull request Dec 13, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants