-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networkfirewall/resource_policy: Fix equivalent policy diffs #22171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccNetworkFirewallResourcePolicy_ PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallResourcePolicy_' -timeout 180m
=== RUN TestAccNetworkFirewallResourcePolicy_basic
=== PAUSE TestAccNetworkFirewallResourcePolicy_basic
=== RUN TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== PAUSE TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== RUN TestAccNetworkFirewallResourcePolicy_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_ruleGroup
=== RUN TestAccNetworkFirewallResourcePolicy_disappears
=== PAUSE TestAccNetworkFirewallResourcePolicy_disappears
=== RUN TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== RUN TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== PAUSE TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT TestAccNetworkFirewallResourcePolicy_basic
=== CONT TestAccNetworkFirewallResourcePolicy_ruleGroup
=== CONT TestAccNetworkFirewallResourcePolicy_ignoreEquivalent
=== CONT TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy
=== CONT TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup
=== CONT TestAccNetworkFirewallResourcePolicy_disappears
--- PASS: TestAccNetworkFirewallResourcePolicy_basic (149.80s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ruleGroup (151.27s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_ruleGroup (157.61s)
--- PASS: TestAccNetworkFirewallResourcePolicy_Disappears_firewallPolicy (157.65s)
--- PASS: TestAccNetworkFirewallResourcePolicy_disappears (157.95s)
--- PASS: TestAccNetworkFirewallResourcePolicy_ignoreEquivalent (158.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 162.632s
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21968
Output from acceptance testing:
(For failure, see #22174)
Output from acceptance testing (GovCloud):