-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/iam_service_linked_role - tagging support #22185
r/iam_service_linked_role - tagging support #22185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTS=TestAccIAMServiceLinkedRole_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServiceLinkedRole_' -timeout 180m
=== RUN TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN TestAccIAMServiceLinkedRole_customSuffix
=== PAUSE TestAccIAMServiceLinkedRole_customSuffix
=== RUN TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== PAUSE TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== RUN TestAccIAMServiceLinkedRole_description
=== PAUSE TestAccIAMServiceLinkedRole_description
=== RUN TestAccIAMServiceLinkedRole_tags
=== PAUSE TestAccIAMServiceLinkedRole_tags
=== RUN TestAccIAMServiceLinkedRole_disappears
=== PAUSE TestAccIAMServiceLinkedRole_disappears
=== CONT TestAccIAMServiceLinkedRole_basic
=== CONT TestAccIAMServiceLinkedRole_tags
=== CONT TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== CONT TestAccIAMServiceLinkedRole_disappears
=== CONT TestAccIAMServiceLinkedRole_description
=== CONT TestAccIAMServiceLinkedRole_customSuffix
--- PASS: TestAccIAMServiceLinkedRole_disappears (23.64s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_basic (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_description (34.87s)
--- PASS: TestAccIAMServiceLinkedRole_tags (53.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 57.111s
GovCloud
% make testacc TESTS=TestAccIAMServiceLinkedRole_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServiceLinkedRole_' -timeout 180m
=== RUN TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN TestAccIAMServiceLinkedRole_customSuffix
=== PAUSE TestAccIAMServiceLinkedRole_customSuffix
=== RUN TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== PAUSE TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== RUN TestAccIAMServiceLinkedRole_description
=== PAUSE TestAccIAMServiceLinkedRole_description
=== RUN TestAccIAMServiceLinkedRole_tags
=== PAUSE TestAccIAMServiceLinkedRole_tags
=== RUN TestAccIAMServiceLinkedRole_disappears
=== PAUSE TestAccIAMServiceLinkedRole_disappears
=== CONT TestAccIAMServiceLinkedRole_basic
=== CONT TestAccIAMServiceLinkedRole_tags
=== CONT TestAccIAMServiceLinkedRole_customSuffix
=== CONT TestAccIAMServiceLinkedRole_disappears
=== CONT TestAccIAMServiceLinkedRole_description
=== CONT TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
--- PASS: TestAccIAMServiceLinkedRole_disappears (28.06s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (34.44s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (34.45s)
--- PASS: TestAccIAMServiceLinkedRole_basic (41.29s)
--- PASS: TestAccIAMServiceLinkedRole_description (48.10s)
--- PASS: TestAccIAMServiceLinkedRole_tags (60.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 64.154s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22057
Output from acceptance testing: