Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/iam_service_linked_role - tagging support #22185

Merged
merged 9 commits into from
Dec 13, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22057

Output from acceptance testing:

$ make testacc TESTS=TestAccIAMServiceLinkedRole_ PKG=iam
--- PASS: TestAccIAMServiceLinkedRole_disappears (66.79s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (82.35s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (82.50s)
--- PASS: TestAccIAMServiceLinkedRole_basic (83.02s)
--- PASS: TestAccIAMServiceLinkedRole_description (108.35s)
--- PASS: TestAccIAMServiceLinkedRole_tags (138.13s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 12, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 12, 2021
@DrFaust92 DrFaust92 changed the title R/iam service linked role tags r/iam_service_linked_role - tagging support Dec 12, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccIAMServiceLinkedRole_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServiceLinkedRole_' -timeout 180m
=== RUN   TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN   TestAccIAMServiceLinkedRole_customSuffix
=== PAUSE TestAccIAMServiceLinkedRole_customSuffix
=== RUN   TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== PAUSE TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== RUN   TestAccIAMServiceLinkedRole_description
=== PAUSE TestAccIAMServiceLinkedRole_description
=== RUN   TestAccIAMServiceLinkedRole_tags
=== PAUSE TestAccIAMServiceLinkedRole_tags
=== RUN   TestAccIAMServiceLinkedRole_disappears
=== PAUSE TestAccIAMServiceLinkedRole_disappears
=== CONT  TestAccIAMServiceLinkedRole_basic
=== CONT  TestAccIAMServiceLinkedRole_tags
=== CONT  TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== CONT  TestAccIAMServiceLinkedRole_disappears
=== CONT  TestAccIAMServiceLinkedRole_description
=== CONT  TestAccIAMServiceLinkedRole_customSuffix
--- PASS: TestAccIAMServiceLinkedRole_disappears (23.64s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_basic (30.59s)
--- PASS: TestAccIAMServiceLinkedRole_description (34.87s)
--- PASS: TestAccIAMServiceLinkedRole_tags (53.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	57.111s
GovCloud
% make testacc TESTS=TestAccIAMServiceLinkedRole_ PKG=iam                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServiceLinkedRole_' -timeout 180m
=== RUN   TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN   TestAccIAMServiceLinkedRole_customSuffix
=== PAUSE TestAccIAMServiceLinkedRole_customSuffix
=== RUN   TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== PAUSE TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
=== RUN   TestAccIAMServiceLinkedRole_description
=== PAUSE TestAccIAMServiceLinkedRole_description
=== RUN   TestAccIAMServiceLinkedRole_tags
=== PAUSE TestAccIAMServiceLinkedRole_tags
=== RUN   TestAccIAMServiceLinkedRole_disappears
=== PAUSE TestAccIAMServiceLinkedRole_disappears
=== CONT  TestAccIAMServiceLinkedRole_basic
=== CONT  TestAccIAMServiceLinkedRole_tags
=== CONT  TestAccIAMServiceLinkedRole_customSuffix
=== CONT  TestAccIAMServiceLinkedRole_disappears
=== CONT  TestAccIAMServiceLinkedRole_description
=== CONT  TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc
--- PASS: TestAccIAMServiceLinkedRole_disappears (28.06s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (34.44s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (34.45s)
--- PASS: TestAccIAMServiceLinkedRole_basic (41.29s)
--- PASS: TestAccIAMServiceLinkedRole_description (48.10s)
--- PASS: TestAccIAMServiceLinkedRole_tags (60.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	64.154s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5ef6419 into hashicorp:main Dec 13, 2021
@github-actions github-actions bot added this to the v3.70.0 milestone Dec 13, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/iam_service_linked_role_tags branch December 26, 2021 21:58
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tags for aws_iam_service_linked_role resource
2 participants