Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/codebuild_project - add support for bucket_access_owner and public_visibility #22189

Merged
merged 8 commits into from
Dec 20, 2021
Merged

r/codebuild_project - add support for bucket_access_owner and public_visibility #22189

merged 8 commits into from
Dec 20, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 13, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20126

Output from acceptance testing:

$ make testacc TESTS=TestAccCodeBuildProject_ PKG=codebuild
--- PASS: TestAccCodeBuildProject_disappears (129.86s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_type (130.68s)
--- PASS: TestAccCodeBuildProject_SourceType_gitHubEnterprise (154.35s)
--- PASS: TestAccCodeBuildProject_SecondarySources_codeCommit (173.95s)
--- PASS: TestAccCodeBuildProject_SourceType_s3 (185.09s)
--- PASS: TestAccCodeBuildProject_Source_gitCloneDepth (189.97s)
--- PASS: TestAccCodeBuildProject_secondaryArtifacts (205.45s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (217.74s)
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (219.06s)
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (235.55s)
--- PASS: TestAccCodeBuildProject_Environment_registryCredential (240.28s)
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (124.48s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_path (254.70s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_packaging (266.81s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_location (294.41s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (296.43s)
--- PASS: TestAccCodeBuildProject_SourceType_bitbucket (151.45s)
--- PASS: TestAccCodeBuildProject_Artifacts_type (316.51s)
--- PASS: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (117.13s)
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (344.03s)
--- PASS: TestAccCodeBuildProject_Artifacts_encryptionDisabled (348.60s)
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (185.92s)
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (207.19s)
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (218.58s)
--- PASS: TestAccCodeBuildProject_Source_insecureSSL (205.04s)
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (88.49s)
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (201.65s)
--- PASS: TestAccCodeBuildProject_encryptionKey (121.78s)
--- PASS: TestAccCodeBuildProject_armContainer (149.34s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (207.02s)
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (246.30s)
--- PASS: TestAccCodeBuildProject_windowsServer2019Container (176.62s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (216.84s)
--- PASS: TestAccCodeBuildProject_Artifacts_artifactIdentifier (217.11s)
--- PASS: TestAccCodeBuildProject_Environment_certificate (107.76s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (279.74s)
--- PASS: TestAccCodeBuildProject_Artifacts_path (251.66s)
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (330.94s)
--- PASS: TestAccCodeBuildProject_tags (251.27s)
--- PASS: TestAccCodeBuildProject_sourceVersion (117.59s)
--- PASS: TestAccCodeBuildProject_vpc (345.17s)
--- PASS: TestAccCodeBuildProject_Artifacts_namespaceType (210.15s)
--- PASS: TestAccCodeBuildProject_buildTimeout (156.24s)
--- PASS: TestAccCodeBuildProject_Artifacts_name (231.83s)
--- PASS: TestAccCodeBuildProject_Logs_cloudWatchLogs (296.39s)
--- PASS: TestAccCodeBuildProject_Logs_s3Logs (329.03s)
--- PASS: TestAccCodeBuildProject_Artifacts_location (234.07s)
--- PASS: TestAccCodeBuildProject_badgeEnabled (136.61s)
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (326.76s)
--- PASS: TestAccCodeBuildProject_queuedTimeout (232.23s)
--- PASS: TestAccCodeBuildProject_Environment_environmentVariable (366.99s)
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (415.04s)
--- PASS: TestAccCodeBuildProject_fileSystemLocations (459.01s)
--- PASS: TestAccCodeBuildProject_basic (123.24s)
--- PASS: TestAccCodeBuildProject_cache (574.92s)
--- PASS: TestAccCodeBuildProject_publicVisibility (377.97s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 13, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 13, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review December 13, 2021 16:41
@DrFaust92 DrFaust92 marked this pull request as draft December 13, 2021 17:15
@DrFaust92 DrFaust92 changed the title r/codebuild_project - add support for bucket_access_owner r/codebuild_project - add support for bucket_access_owner and public_visibility Dec 13, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review December 13, 2021 17:37
ewbankkit
ewbankkit approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCodeBuildProject_ PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_' -timeout 180m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_publicVisibility
=== PAUSE TestAccCodeBuildProject_publicVisibility
=== RUN   TestAccCodeBuildProject_badgeEnabled
=== PAUSE TestAccCodeBuildProject_badgeEnabled
=== RUN   TestAccCodeBuildProject_buildTimeout
=== PAUSE TestAccCodeBuildProject_buildTimeout
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== RUN   TestAccCodeBuildProject_description
=== PAUSE TestAccCodeBuildProject_description
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== RUN   TestAccCodeBuildProject_sourceVersion
=== PAUSE TestAccCodeBuildProject_sourceVersion
=== RUN   TestAccCodeBuildProject_encryptionKey
=== PAUSE TestAccCodeBuildProject_encryptionKey
=== RUN   TestAccCodeBuildProject_Environment_environmentVariable
=== PAUSE TestAccCodeBuildProject_Environment_environmentVariable
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== RUN   TestAccCodeBuildProject_Environment_certificate
=== PAUSE TestAccCodeBuildProject_Environment_certificate
=== RUN   TestAccCodeBuildProject_Logs_cloudWatchLogs
=== PAUSE TestAccCodeBuildProject_Logs_cloudWatchLogs
=== RUN   TestAccCodeBuildProject_Logs_s3Logs
=== PAUSE TestAccCodeBuildProject_Logs_s3Logs
=== RUN   TestAccCodeBuildProject_buildBatch
=== PAUSE TestAccCodeBuildProject_buildBatch
=== RUN   TestAccCodeBuildProject_Source_gitCloneDepth
=== PAUSE TestAccCodeBuildProject_Source_gitCloneDepth
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_Source_insecureSSL
=== PAUSE TestAccCodeBuildProject_Source_insecureSSL
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceType_bitbucket
=== RUN   TestAccCodeBuildProject_SourceType_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceType_codeCommit
=== RUN   TestAccCodeBuildProject_SourceType_codePipeline
=== PAUSE TestAccCodeBuildProject_SourceType_codePipeline
=== RUN   TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_s3
=== PAUSE TestAccCodeBuildProject_SourceType_s3
=== RUN   TestAccCodeBuildProject_SourceType_noSource
=== PAUSE TestAccCodeBuildProject_SourceType_noSource
=== RUN   TestAccCodeBuildProject_SourceType_noSourceInvalid
=== PAUSE TestAccCodeBuildProject_SourceType_noSourceInvalid
=== RUN   TestAccCodeBuildProject_tags
=== PAUSE TestAccCodeBuildProject_tags
=== RUN   TestAccCodeBuildProject_vpc
=== PAUSE TestAccCodeBuildProject_vpc
=== RUN   TestAccCodeBuildProject_windowsServer2019Container
=== PAUSE TestAccCodeBuildProject_windowsServer2019Container
=== RUN   TestAccCodeBuildProject_armContainer
=== PAUSE TestAccCodeBuildProject_armContainer
=== RUN   TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_Artifacts_location
=== PAUSE TestAccCodeBuildProject_Artifacts_location
=== RUN   TestAccCodeBuildProject_Artifacts_name
=== PAUSE TestAccCodeBuildProject_Artifacts_name
=== RUN   TestAccCodeBuildProject_Artifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_Artifacts_namespaceType
=== RUN   TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_Artifacts_packaging
=== PAUSE TestAccCodeBuildProject_Artifacts_packaging
=== RUN   TestAccCodeBuildProject_Artifacts_path
=== PAUSE TestAccCodeBuildProject_Artifacts_path
=== RUN   TestAccCodeBuildProject_Artifacts_type
=== PAUSE TestAccCodeBuildProject_Artifacts_type
=== RUN   TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== PAUSE TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== RUN   TestAccCodeBuildProject_secondaryArtifacts
=== PAUSE TestAccCodeBuildProject_secondaryArtifacts
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_location
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_location
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_name
    acctest.go:66: Currently no solution to allow updates on name attribute
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_name (0.00s)
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_path
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_path
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_type
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_type
=== RUN   TestAccCodeBuildProject_SecondarySources_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySources_codeCommit
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== RUN   TestAccCodeBuildProject_Environment_registryCredential
=== PAUSE TestAccCodeBuildProject_Environment_registryCredential
=== RUN   TestAccCodeBuildProject_disappears
=== PAUSE TestAccCodeBuildProject_disappears
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== CONT  TestAccCodeBuildProject_buildBatch
=== CONT  TestAccCodeBuildProject_Artifacts_type
=== CONT  TestAccCodeBuildProject_disappears
=== CONT  TestAccCodeBuildProject_Environment_registryCredential
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
=== CONT  TestAccCodeBuildProject_SecondarySources_codeCommit
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_type
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_path
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_location
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== CONT  TestAccCodeBuildProject_secondaryArtifacts
=== CONT  TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== CONT  TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
--- PASS: TestAccCodeBuildProject_disappears (46.61s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
--- PASS: TestAccCodeBuildProject_basic (56.23s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
--- PASS: TestAccCodeBuildProject_SecondarySources_codeCommit (56.88s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_type (69.68s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== CONT  TestAccCodeBuildProject_SourceType_codeCommit
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (77.53s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (80.38s)
=== CONT  TestAccCodeBuildProject_SourceType_codePipeline
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier (84.55s)
=== CONT  TestAccCodeBuildProject_SourceType_bitbucket
--- PASS: TestAccCodeBuildProject_Artifacts_type (84.77s)
=== CONT  TestAccCodeBuildProject_sourceVersion
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_location (89.39s)
=== CONT  TestAccCodeBuildProject_queuedTimeout
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (97.92s)
=== CONT  TestAccCodeBuildProject_Logs_s3Logs
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_packaging (99.15s)
=== CONT  TestAccCodeBuildProject_fileSystemLocations
--- PASS: TestAccCodeBuildProject_SourceType_gitHubEnterprise (104.86s)
=== CONT  TestAccCodeBuildProject_description
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_path (104.87s)
=== CONT  TestAccCodeBuildProject_cache
--- PASS: TestAccCodeBuildProject_sourceVersion (29.26s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
--- PASS: TestAccCodeBuildProject_secondaryArtifacts (114.06s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (117.83s)
=== CONT  TestAccCodeBuildProject_Logs_cloudWatchLogs
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (119.47s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
--- PASS: TestAccCodeBuildProject_buildBatch (120.05s)
=== CONT  TestAccCodeBuildProject_Environment_environmentVariable
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (53.00s)
=== CONT  TestAccCodeBuildProject_Environment_certificate
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (76.55s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
--- PASS: TestAccCodeBuildProject_SourceType_bitbucket (51.06s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHub
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (57.67s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (88.77s)
=== CONT  TestAccCodeBuildProject_Source_gitCloneDepth
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (147.52s)
=== CONT  TestAccCodeBuildProject_Source_insecureSSL
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (108.51s)
=== CONT  TestAccCodeBuildProject_Artifacts_artifactIdentifier
--- PASS: TestAccCodeBuildProject_Environment_certificate (35.49s)
=== CONT  TestAccCodeBuildProject_Artifacts_path
--- PASS: TestAccCodeBuildProject_SourceType_codeCommit (82.25s)
=== CONT  TestAccCodeBuildProject_badgeEnabled
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (50.51s)
=== CONT  TestAccCodeBuildProject_Artifacts_packaging
--- PASS: TestAccCodeBuildProject_description (64.44s)
=== CONT  TestAccCodeBuildProject_buildTimeout
--- PASS: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (174.90s)
=== CONT  TestAccCodeBuildProject_Artifacts_overrideArtifactName
--- PASS: TestAccCodeBuildProject_Source_insecureSSL (41.93s)
=== CONT  TestAccCodeBuildProject_Artifacts_name
--- PASS: TestAccCodeBuildProject_queuedTimeout (109.23s)
=== CONT  TestAccCodeBuildProject_Artifacts_namespaceType
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (68.15s)
=== CONT  TestAccCodeBuildProject_publicVisibility
--- PASS: TestAccCodeBuildProject_Logs_s3Logs (105.91s)
=== CONT  TestAccCodeBuildProject_encryptionKey
--- PASS: TestAccCodeBuildProject_badgeEnabled (47.68s)
=== CONT  TestAccCodeBuildProject_armContainer
--- PASS: TestAccCodeBuildProject_buildTimeout (48.21s)
=== CONT  TestAccCodeBuildProject_tags
--- PASS: TestAccCodeBuildProject_Logs_cloudWatchLogs (104.39s)
=== CONT  TestAccCodeBuildProject_SourceType_noSourceInvalid
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (109.80s)
=== CONT  TestAccCodeBuildProject_SourceType_noSource
--- PASS: TestAccCodeBuildProject_Artifacts_path (80.04s)
=== CONT  TestAccCodeBuildProject_Artifacts_location
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (19.96s)
=== CONT  TestAccCodeBuildProject_vpc
--- PASS: TestAccCodeBuildProject_Source_gitCloneDepth (97.22s)
=== CONT  TestAccCodeBuildProject_Artifacts_encryptionDisabled
--- PASS: TestAccCodeBuildProject_Artifacts_artifactIdentifier (88.65s)
=== CONT  TestAccCodeBuildProject_windowsServer2019Container
--- PASS: TestAccCodeBuildProject_encryptionKey (40.20s)
=== CONT  TestAccCodeBuildProject_SourceType_s3
--- PASS: TestAccCodeBuildProject_armContainer (38.44s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (123.66s)
--- PASS: TestAccCodeBuildProject_SourceType_noSource (37.95s)
--- PASS: TestAccCodeBuildProject_Artifacts_overrideArtifactName (88.81s)
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (130.45s)
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (144.65s)
--- PASS: TestAccCodeBuildProject_Artifacts_name (81.52s)
--- PASS: TestAccCodeBuildProject_Artifacts_namespaceType (72.41s)
--- PASS: TestAccCodeBuildProject_Artifacts_packaging (106.81s)
--- PASS: TestAccCodeBuildProject_tags (56.95s)
--- PASS: TestAccCodeBuildProject_publicVisibility (72.58s)
--- PASS: TestAccCodeBuildProject_Environment_environmentVariable (157.03s)
--- PASS: TestAccCodeBuildProject_windowsServer2019Container (41.74s)
--- PASS: TestAccCodeBuildProject_SourceType_s3 (43.17s)
--- PASS: TestAccCodeBuildProject_Artifacts_encryptionDisabled (60.37s)
--- PASS: TestAccCodeBuildProject_Artifacts_location (69.75s)
--- PASS: TestAccCodeBuildProject_Environment_registryCredential (309.43s)
--- PASS: TestAccCodeBuildProject_cache (209.72s)
--- PASS: TestAccCodeBuildProject_vpc (79.63s)
--- PASS: TestAccCodeBuildProject_fileSystemLocations (234.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	337.361s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit aac85d6 into hashicorp:main Dec 20, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Dec 20, 2021
@DrFaust92 DrFaust92 deleted the r/codebuild_project_bucket_owner branch December 20, 2021 17:00
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@fdamstra fdamstra mentioned this pull request Mar 22, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.71.0
Development

Successfully merging this pull request may close these issues.

aws_codebuild_project: service_role attribute is required and optional
2 participants
@DrFaust92 @ewbankkit