sns/topic: Fix diffs with policies

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21968

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccSNSTopicPolicy_ PKG=sns                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicPolicy_' -timeout 180m
--- PASS: TestAccSNSTopicPolicy_Disappears_topic (17.72s)
--- PASS: TestAccSNSTopicPolicy_disappears (21.62s)
--- PASS: TestAccSNSTopicPolicy_basic (24.81s)
--- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (32.55s)
--- PASS: TestAccSNSTopicPolicy_updated (38.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	40.226s
% make testacc TESTS=TestAccSNSTopic_ PKG=sns 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_' -timeout 180m
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (7.26s)
--- PASS: TestAccSNSTopic_disappears (32.27s)
--- PASS: TestAccSNSTopic_policy (46.66s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (46.66s)
--- PASS: TestAccSNSTopic_name (46.78s)
--- PASS: TestAccSNSTopic_basic (46.88s)
--- PASS: TestAccSNSTopic_namePrefix (47.11s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (47.27s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (47.49s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (47.52s)
--- PASS: TestAccSNSTopic_withIAMRole (55.03s)
--- PASS: TestAccSNSTopic_deliveryStatus (57.77s)
--- PASS: TestAccSNSTopic_encryption (65.32s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (65.66s)
--- PASS: TestAccSNSTopic_tags (77.69s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (135.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	136.596s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccSNSTopic_ PKG=sns 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic_' -timeout 180m
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (12.33s)
--- SKIP: TestAccSNSTopic_NameGenerated_fifoTopic (23.33s)
--- SKIP: TestAccSNSTopic_NamePrefix_fifoTopic (23.33s)
--- SKIP: TestAccSNSTopic_fifoWithContentBasedDeduplication (23.42s)
--- SKIP: TestAccSNSTopic_Name_fifoTopic (23.56s)
--- PASS: TestAccSNSTopic_disappears (36.94s)
--- PASS: TestAccSNSTopic_basic (44.87s)
--- PASS: TestAccSNSTopic_namePrefix (44.88s)
--- PASS: TestAccSNSTopic_name (44.91s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (45.04s)
--- PASS: TestAccSNSTopic_policy (45.05s)
--- PASS: TestAccSNSTopic_withIAMRole (49.98s)
--- PASS: TestAccSNSTopic_deliveryStatus (55.48s)
--- PASS: TestAccSNSTopic_encryption (59.90s)
--- PASS: TestAccSNSTopic_tags (72.52s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (145.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	147.414s
% make testacc TESTS=TestAccSNSTopicPolicy_ PKG=sns 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicPolicy_' -timeout 180m
--- PASS: TestAccSNSTopicPolicy_Disappears_topic (17.84s)
--- PASS: TestAccSNSTopicPolicy_disappears (21.87s)
--- PASS: TestAccSNSTopicPolicy_basic (25.02s)
--- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (31.22s)
--- PASS: TestAccSNSTopicPolicy_updated (37.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	39.339s             

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccSNSTopic PKG=sns 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopic' -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.42.23
go: downloading golang.org/x/net v0.0.0-20211209124913-491a49abca63
=== RUN   TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== RUN   TestAccSNSTopicPolicy_basic
=== PAUSE TestAccSNSTopicPolicy_basic
=== RUN   TestAccSNSTopicPolicy_updated
=== PAUSE TestAccSNSTopicPolicy_updated
=== RUN   TestAccSNSTopicPolicy_Disappears_topic
=== PAUSE TestAccSNSTopicPolicy_Disappears_topic
=== RUN   TestAccSNSTopicPolicy_disappears
=== PAUSE TestAccSNSTopicPolicy_disappears
=== RUN   TestAccSNSTopicPolicy_ignoreEquivalent
=== PAUSE TestAccSNSTopicPolicy_ignoreEquivalent
=== RUN   TestAccSNSTopicSubscription_basic
=== PAUSE TestAccSNSTopicSubscription_basic
=== RUN   TestAccSNSTopicSubscription_filterPolicy
=== PAUSE TestAccSNSTopicSubscription_filterPolicy
=== RUN   TestAccSNSTopicSubscription_deliveryPolicy
=== PAUSE TestAccSNSTopicSubscription_deliveryPolicy
=== RUN   TestAccSNSTopicSubscription_redrivePolicy
=== PAUSE TestAccSNSTopicSubscription_redrivePolicy
=== RUN   TestAccSNSTopicSubscription_rawMessageDelivery
=== PAUSE TestAccSNSTopicSubscription_rawMessageDelivery
=== RUN   TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== RUN   TestAccSNSTopicSubscription_email
=== PAUSE TestAccSNSTopicSubscription_email
=== RUN   TestAccSNSTopicSubscription_firehose
=== PAUSE TestAccSNSTopicSubscription_firehose
=== RUN   TestAccSNSTopicSubscription_disappears
=== PAUSE TestAccSNSTopicSubscription_disappears
=== RUN   TestAccSNSTopicSubscription_Disappears_topic
=== PAUSE TestAccSNSTopicSubscription_Disappears_topic
=== RUN   TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN   TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN   TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN   TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN   TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN   TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN   TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN   TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN   TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN   TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN   TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN   TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN   TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN   TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== RUN   TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN   TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== CONT  TestAccSNSTopicDataSource_basic
=== CONT  TestAccSNSTopic_basic
=== CONT  TestAccSNSTopic_disappears
=== CONT  TestAccSNSTopic_tags
=== CONT  TestAccSNSTopic_encryption
=== CONT  TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== CONT  TestAccSNSTopic_fifoWithContentBasedDeduplication
=== CONT  TestAccSNSTopic_NamePrefix_fifoTopic
=== CONT  TestAccSNSTopic_Name_fifoTopic
=== CONT  TestAccSNSTopic_NameGenerated_fifoTopic
=== CONT  TestAccSNSTopic_deliveryStatus
=== CONT  TestAccSNSTopic_withDeliveryPolicy
=== CONT  TestAccSNSTopic_withFakeIAMRole
=== CONT  TestAccSNSTopic_withIAMRole
=== CONT  TestAccSNSTopic_policy
=== CONT  TestAccSNSTopic_namePrefix
=== CONT  TestAccSNSTopic_name
=== CONT  TestAccSNSTopicSubscription_redrivePolicy
=== CONT  TestAccSNSTopicSubscription_Disappears_topic
=== CONT  TestAccSNSTopicSubscription_disappears
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (8.34s)
=== CONT  TestAccSNSTopicSubscription_firehose
=== CONT  TestAccSNSTopicSubscription_email
--- PASS: TestAccSNSTopic_disappears (30.83s)
--- PASS: TestAccSNSTopic_basic (33.07s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
--- PASS: TestAccSNSTopicDataSource_basic (36.41s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccSNSTopic_Name_fifoTopic (37.02s)
=== CONT  TestAccSNSTopicSubscription_rawMessageDelivery
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (38.49s)
=== CONT  TestAccSNSTopicPolicy_ignoreEquivalent
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (41.53s)
=== CONT  TestAccSNSTopicSubscription_deliveryPolicy
--- PASS: TestAccSNSTopic_name (41.66s)
=== CONT  TestAccSNSTopicSubscription_filterPolicy
--- PASS: TestAccSNSTopic_namePrefix (41.70s)
=== CONT  TestAccSNSTopicSubscription_basic
--- PASS: TestAccSNSTopic_policy (41.87s)
=== CONT  TestAccSNSTopicPolicy_Disappears_topic
--- PASS: TestAccSNSTopic_withDeliveryPolicy (42.16s)
=== CONT  TestAccSNSTopicPolicy_disappears
--- PASS: TestAccSNSTopic_withIAMRole (54.54s)
=== CONT  TestAccSNSTopicPolicy_updated
--- PASS: TestAccSNSTopic_deliveryStatus (59.29s)
=== CONT  TestAccSNSTopicPolicy_basic
--- PASS: TestAccSNSTopicSubscription_email (30.57s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (62.33s)
--- PASS: TestAccSNSTopic_encryption (62.72s)
--- PASS: TestAccSNSTopicPolicy_Disappears_topic (24.31s)
--- PASS: TestAccSNSTopicPolicy_disappears (28.18s)
--- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (36.50s)
--- PASS: TestAccSNSTopicSubscription_Disappears_topic (76.63s)
--- PASS: TestAccSNSTopic_tags (78.48s)
--- PASS: TestAccSNSTopicPolicy_basic (22.26s)
--- PASS: TestAccSNSTopicSubscription_disappears (88.50s)
--- PASS: TestAccSNSTopicPolicy_updated (37.88s)
--- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (61.83s)
--- PASS: TestAccSNSTopicSubscription_deliveryPolicy (62.49s)
--- PASS: TestAccSNSTopicSubscription_filterPolicy (63.12s)
--- PASS: TestAccSNSTopicSubscription_basic (79.46s)
--- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (101.04s)
--- PASS: TestAccSNSTopicSubscription_redrivePolicy (134.11s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (138.82s)
--- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (134.69s)
--- PASS: TestAccSNSTopicSubscription_firehose (217.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	229.362s

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.