Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloudfront_response_headers_policy resource reference is missing cors_config.origin_override on Argument Reference #22220

Closed
LegendaryMM opened this issue Dec 14, 2021 · 3 comments
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/cloudfront Issues and PRs that pertain to the cloudfront service.

Comments

@LegendaryMM
Copy link

The cors_config.origin_override argument is shown in the example on the aws_cloudfront_response_headers_policy resource reference page. But the cors_config.origin_override is missing in the cors_config Argument Reference section.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 14, 2021
@LegendaryMM LegendaryMM changed the title aws_cloudfront_response_headers_policy missing cors_config.origin_override on Argument Reference aws_cloudfront_response_headers_policy resource reference is missing cors_config.origin_override on Argument Reference Dec 14, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. bug Addresses a defect in current functionality. labels Dec 15, 2021
@Lucifer0x17
Copy link

Hey, if no one is working on the issue I would like to work on it.

@LegendaryMM
Copy link
Author

Looks like origin_override also needs to be added on the data page https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/cloudfront_response_headers_policy

Also, the documentation lists access_control_max_age_sec as required when I think it might be optional and just default to 600 when not provided.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Projects
None yet
Development

No branches or pull requests

3 participants