Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/appstream_fleet: correctly create resource with stream_view argument #22395

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21718

Output from acceptance testing:

--- PASS: TestAccAppStreamFleet_basic (819.92s)
--- PASS: TestAccAppStreamFleet_completeWithStop (2087.37s)
--- PASS: TestAccAppStreamFleet_completeWithoutStop (912.51s)

@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Jan 3, 2022
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 3, 2022
@anGie44 anGie44 marked this pull request as ready for review January 3, 2022 22:34
@ewbankkit ewbankkit self-assigned this Jan 4, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppStreamFleet_basic\|TestAccAppStreamFleet_completeWith' PKG_NAME=internal/service/appstream
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run=TestAccAppStreamFleet_basic\|TestAccAppStreamFleet_completeWith -timeout 180m
=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== RUN   TestAccAppStreamFleet_completeWithStop
=== PAUSE TestAccAppStreamFleet_completeWithStop
=== RUN   TestAccAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAppStreamFleet_completeWithoutStop
=== CONT  TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_completeWithStop
=== CONT  TestAccAppStreamFleet_completeWithoutStop
--- PASS: TestAccAppStreamFleet_completeWithoutStop (838.45s)
--- PASS: TestAccAppStreamFleet_basic (946.52s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1908.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	1912.179s

@ewbankkit ewbankkit removed their assignment Jan 4, 2022
@anGie44 anGie44 added this to the v3.71.0 milestone Jan 4, 2022
@anGie44 anGie44 merged commit 35d834f into main Jan 4, 2022
@anGie44 anGie44 deleted the b-appstream-fleet-stream-view branch January 4, 2022 14:36
github-actions bot pushed a commit that referenced this pull request Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_appstream_fleet stream_view does not work
2 participants