Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_cognito_user_pool_client lookup single client attributes #22477

Merged
merged 7 commits into from
Jan 10, 2022

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15972

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccCognitoIDPUserPoolClientDataSource_basic" PKG_NAME="./internal/service/cognitoidp" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/cognitoidp/... -v -count 1 -parallel 3 -run=TestAccCognitoIDPUserPoolClientDataSource_basic -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientDataSource_basic (25.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	26.952s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cognitoidentityprovider tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 7, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 9, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Jan 9, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClientDataSource_' PKG_NAME=internal/service/cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run=TestAccCognitoIDPUserPoolClientDataSource_ -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientDataSource_basic (18.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 21.586s
GovCloud
% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClientDataSource_' PKG_NAME=internal/service/cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run=TestAccCognitoIDPUserPoolClientDataSource_ -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClientDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolClientDataSource_basic
=== CONT  TestAccCognitoIDPUserPoolClientDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolClientDataSource_basic (25.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 28.860s

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 70cb6a1 into hashicorp:main Jan 10, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 10, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
@danquack danquack deleted the client-info branch May 27, 2022 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cognito identity pool / user pool: app client IDs not available to reference in code
2 participants